From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A98FC433DB for ; Fri, 19 Mar 2021 17:44:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D9BDD6197B for ; Fri, 19 Mar 2021 17:44:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D9BDD6197B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 720646B0078; Fri, 19 Mar 2021 13:44:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F5A16B007B; Fri, 19 Mar 2021 13:44:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 596476B007D; Fri, 19 Mar 2021 13:44:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0198.hostedemail.com [216.40.44.198]) by kanga.kvack.org (Postfix) with ESMTP id 3CCE36B0078 for ; Fri, 19 Mar 2021 13:44:18 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id F2246180275D9 for ; Fri, 19 Mar 2021 17:44:17 +0000 (UTC) X-FDA: 77937347754.06.154D3B0 Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) by imf24.hostedemail.com (Postfix) with ESMTP id 07A1FA000680 for ; Fri, 19 Mar 2021 17:44:11 +0000 (UTC) Received: by mail-lf1-f41.google.com with SMTP id b83so11242588lfd.11 for ; Fri, 19 Mar 2021 10:44:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=gq4UIk+ByEdA/Jn9oEYE7L3pIna4OdrooJuJgf5IZnk=; b=uMS9Ttr4YOy2CbXHUE4FhhR3hZMFun1WDEUYtrYbtMLHcT++dD6nYgKvBT2ZR/PByh cudf3+Zx7IO6Z/V2yjkIBkBasjdD/zcGulHderIjLybhn1jWEEvotzkxN9jDEw5NMyc9 s0CwM5LXfynfaj7Ij8eoqJLRt2dO7x/z4K915KJr6Qfz0eqBj0qcELhCVR13BMx5yUvq yyFvqUwAQ+EaxFWPjnM5u1Pz4s5pln+2AhrKTVfsxmvK2SaY1fTWZ8mhAD2OjPU0kwVM vNdvmMOVXhTxPZNx/Dc0JiyaUx50MzUOnYU/nCt/V6C/QpinpgReJ9LFVnmlVIRdjZOx PRvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=gq4UIk+ByEdA/Jn9oEYE7L3pIna4OdrooJuJgf5IZnk=; b=r8CBHB15md8CTx2bFn3aG1S104A4CAeGWPicAizQ0QSOYn2mztWWqLKtkReIbx/e0H Ule1V0l3L2oiTUTRui6O3gjFkH81rK3mtZNbBX9MZcssGfcIsyh3gvvWvD8eBMqp7v7X Kce6Qm3rA2hMdTASeL+VRZkVtQPZIm8GRfXSasULM4Y9Ifyrdyu8eaZyyR2hl7AAFOn9 dX3XtC+kjBPNAi9g7SPoVVDDD4VW/L5o28SaVoT8leBgY7hqbytNGIFpfFbGE+R13Mo+ PP+c2NVN+L0eWQ7yCO35snMc8G6yIRn+fwVr+bloLhxRziERXu+g/pUi5m7QXMtPKpU7 O95A== X-Gm-Message-State: AOAM5308LW+GT66WkQBAv2mIeRdXwkrMLwQhYDdLbH3ZUX13b9MB7irl 8KvJIhIFFoqcngi+06fsRXE= X-Google-Smtp-Source: ABdhPJw2DmuYYVAqrwygwCq3lofBMOROw4yRj8tSgDsg18peqRXYn+0/Jyf1Y/OhtXfh6VB/SOWB0A== X-Received: by 2002:ac2:53a1:: with SMTP id j1mr1472374lfh.298.1616175850302; Fri, 19 Mar 2021 10:44:10 -0700 (PDT) Received: from [192.168.2.145] (109-252-193-52.dynamic.spd-mgts.ru. [109.252.193.52]) by smtp.googlemail.com with ESMTPSA id a1sm698495lfh.142.2021.03.19.10.44.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Mar 2021 10:44:10 -0700 (PDT) Subject: Re: [PATCH v4] mm: cma: support sysfs From: Dmitry Osipenko To: Minchan Kim Cc: Greg Kroah-Hartman , Andrew Morton , linux-mm , LKML , joaodias@google.com, willy@infradead.org, david@redhat.com, surenb@google.com, John Hubbard , Nicolas Chauvet , "linux-tegra@vger.kernel.org" References: <33ec18ef-8652-643a-1a53-ff7c3caf4399@gmail.com> <78883205-e6da-5bc4-dcec-b6eb921567b1@gmail.com> <72db59eb-75dc-d1ed-7a83-17052e8f22a8@gmail.com> <82bde114-60c0-3fde-43f4-844522b80673@gmail.com> Message-ID: Date: Fri, 19 Mar 2021 20:44:09 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Stat-Signature: wddj8twxywir664u8fbdzpbcux83bsuz X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 07A1FA000680 Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf24; identity=mailfrom; envelope-from=""; helo=mail-lf1-f41.google.com; client-ip=209.85.167.41 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616175851-197296 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 19.03.2021 20:41, Dmitry Osipenko =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > 19.03.2021 20:29, Dmitry Osipenko =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >> +void cma_sysfs_alloc_pages_count(struct cma *cma, size_t count) >> +{ >> + atomic64_add(count, &cma->nr_pages_succeeded); >> +} >> + >> +void cma_sysfs_fail_pages_count(struct cma *cma, size_t count) >> +{ >> + atomic64_add(count, &cma->nr_pages_failed); >> +} >=20 > The atomic looks good, but aren't CMA allocations already protected by > the CMA core? Do we really need to worry about racing here? >=20 Although, please scratch that. I see now that these functions are called outside of the lock.