From: Coly Li <colyli@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: dm-devel@redhat.com, linux-xfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-um@lists.infradead.org,
linux-block@vger.kernel.org, drbd-dev@lists.linbit.com,
Jens Axboe <axboe@kernel.dk>,
nbd@other.debian.org, ceph-devel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org,
linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org,
linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org,
linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org,
target-devel@vger.kernel.org, linux-btrfs@vger.kernel.org,
linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com,
jfs-discussion@lists.sourceforge.net,
linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev,
ocfs2-devel@oss.oracle.com, linux-mm@kvack.org
Subject: Re: [PATCH 25/27] block: remove QUEUE_FLAG_DISCARD
Date: Thu, 7 Apr 2022 13:18:49 +0800 [thread overview]
Message-ID: <f326944f-46b1-e888-18f6-97dcf69d945d@suse.de> (raw)
In-Reply-To: <20220406060516.409838-26-hch@lst.de>
On 4/6/22 2:05 PM, Christoph Hellwig wrote:
> Just use a non-zero max_discard_sectors as an indicator for discard
> support, similar to what is done for write zeroes.
>
> The only places where needs special attention is the RAID5 driver,
> which must clear discard support for security reasons by default,
> even if the default stacking rules would allow for it.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
For the bcache part,
Acked-by: Coly Li <colyli@suse.de>
Thanks.
Coly Li
> ---
> arch/um/drivers/ubd_kern.c | 2 --
> block/blk-mq-debugfs.c | 1 -
> drivers/block/drbd/drbd_nl.c | 15 ---------------
> drivers/block/loop.c | 2 --
> drivers/block/nbd.c | 3 ---
> drivers/block/null_blk/main.c | 1 -
> drivers/block/rbd.c | 1 -
> drivers/block/rnbd/rnbd-clt.c | 2 --
> drivers/block/virtio_blk.c | 2 --
> drivers/block/xen-blkfront.c | 2 --
> drivers/block/zram/zram_drv.c | 1 -
> drivers/md/bcache/super.c | 1 -
> drivers/md/dm-table.c | 5 +----
> drivers/md/dm-thin.c | 2 --
> drivers/md/dm.c | 1 -
> drivers/md/md-linear.c | 9 ---------
> drivers/md/raid0.c | 7 -------
> drivers/md/raid1.c | 14 --------------
> drivers/md/raid10.c | 14 --------------
> drivers/md/raid5.c | 12 ++++--------
> drivers/mmc/core/queue.c | 1 -
> drivers/mtd/mtd_blkdevs.c | 1 -
> drivers/nvme/host/core.c | 6 ++----
> drivers/s390/block/dasd_fba.c | 1 -
> drivers/scsi/sd.c | 2 --
> include/linux/blkdev.h | 2 --
> 26 files changed, 7 insertions(+), 103 deletions(-)
[snipped]
> diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
> index 296f200b2e208..2f49e31142f62 100644
> --- a/drivers/md/bcache/super.c
> +++ b/drivers/md/bcache/super.c
> @@ -973,7 +973,6 @@ static int bcache_device_init(struct bcache_device *d, unsigned int block_size,
>
> blk_queue_flag_set(QUEUE_FLAG_NONROT, d->disk->queue);
> blk_queue_flag_clear(QUEUE_FLAG_ADD_RANDOM, d->disk->queue);
> - blk_queue_flag_set(QUEUE_FLAG_DISCARD, d->disk->queue);
>
> blk_queue_write_cache(q, true, true);
>
[snipped]
next prev parent reply other threads:[~2022-04-07 5:19 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 6:04 use block_device based APIs in block layer consumers Christoph Hellwig
2022-04-06 6:04 ` [PATCH 01/27] target: remove an incorrect unmap zeroes data deduction Christoph Hellwig
2022-04-07 3:05 ` [dm-devel] " Martin K. Petersen
2022-04-07 3:06 ` Martin K. Petersen
2022-04-06 6:04 ` [PATCH 02/27] target: pass a block_device to target_configure_unmap_from_queue Christoph Hellwig
2022-04-07 3:07 ` Martin K. Petersen
2022-04-06 6:04 ` [PATCH 03/27] target: fix discard alignment on partitions Christoph Hellwig
2022-04-07 3:14 ` [dm-devel] " Martin K. Petersen
2022-04-06 6:04 ` [PATCH 05/27] drbd: use bdev based limit helpers in drbd_send_sizes Christoph Hellwig
2022-04-06 6:04 ` [PATCH 06/27] drbd: cleanup decide_on_discard_support Christoph Hellwig
2022-04-06 6:04 ` [PATCH 07/27] btrfs: use bdev_max_active_zones instead of open coding it Christoph Hellwig
2022-04-06 9:56 ` Johannes Thumshirn
2022-04-07 15:20 ` David Sterba
2022-04-07 15:26 ` Christoph Hellwig
2022-04-06 6:04 ` [PATCH 08/27] ntfs3: use bdev_logical_block_size " Christoph Hellwig
2022-04-06 6:04 ` [PATCH 09/27] mm: use bdev_is_zoned in claim_swapfile Christoph Hellwig
2022-04-06 6:04 ` [PATCH 10/27] block: add a bdev_nonrot helper Christoph Hellwig
2022-04-07 3:16 ` [Ocfs2-devel] " Martin K. Petersen
2022-04-07 15:21 ` David Sterba
2022-04-06 6:05 ` [PATCH 11/27] block: add a bdev_write_cache helper Christoph Hellwig
2022-04-07 3:17 ` [Ocfs2-devel] " Martin K. Petersen
2022-04-07 15:21 ` David Sterba
2022-04-06 6:05 ` [PATCH 12/27] block: add a bdev_fua helper Christoph Hellwig
2022-04-07 3:17 ` [Ocfs2-devel] " Martin K. Petersen
2022-04-06 6:05 ` [PATCH 13/27] block: add a bdev_stable_writes helper Christoph Hellwig
2022-04-07 3:18 ` [Ocfs2-devel] " Martin K. Petersen
2022-04-06 6:05 ` [PATCH 14/27] block: add a bdev_max_zone_append_sectors helper Christoph Hellwig
2022-04-06 8:52 ` Damien Le Moal
2022-04-06 9:58 ` Johannes Thumshirn
2022-04-07 3:15 ` [dm-devel] " Martin K. Petersen
2022-04-06 6:05 ` [PATCH 15/27] block: use bdev_alignment_offset in part_alignment_offset_show Christoph Hellwig
2022-04-07 3:19 ` [Ocfs2-devel] " Martin K. Petersen
2022-04-06 6:05 ` [PATCH 16/27] drbd: use bdev_alignment_offset instead of queue_alignment_offset Christoph Hellwig
2022-04-06 6:05 ` [PATCH 17/27] block: use bdev_alignment_offset in disk_alignment_offset_show Christoph Hellwig
2022-04-07 3:20 ` [Ocfs2-devel] " Martin K. Petersen
2022-04-06 6:05 ` [PATCH 18/27] block: move bdev_alignment_offset and queue_limit_alignment_offset out of line Christoph Hellwig
2022-04-07 3:21 ` [Ocfs2-devel] " Martin K. Petersen
2022-04-06 6:05 ` [PATCH 19/27] block: remove queue_discard_alignment Christoph Hellwig
2022-04-07 3:21 ` [Ocfs2-devel] " Martin K. Petersen
2022-04-06 6:05 ` [PATCH 20/27] block: use bdev_discard_alignment in part_discard_alignment_show Christoph Hellwig
2022-04-07 3:22 ` [Ocfs2-devel] " Martin K. Petersen
2022-04-06 6:05 ` [PATCH 21/27] block: move {bdev,queue_limit}_discard_alignment out of line Christoph Hellwig
2022-04-07 3:27 ` [Ocfs2-devel] [PATCH 21/27] block: move {bdev, queue_limit}_discard_alignment " Martin K. Petersen
2022-04-06 6:05 ` [PATCH 22/27] block: refactor discard bio size limiting Christoph Hellwig
2022-04-07 3:29 ` [Ocfs2-devel] " Martin K. Petersen
2022-04-07 8:03 ` Coly Li
2022-04-06 6:05 ` [PATCH 23/27] block: add a bdev_max_discard_sectors helper Christoph Hellwig
2022-04-06 9:53 ` [Cluster-devel] " Andreas Gruenbacher
2022-04-06 17:28 ` Ryusuke Konishi
2022-04-07 3:30 ` [Ocfs2-devel] " Martin K. Petersen
2022-04-07 5:16 ` Coly Li
2022-04-07 15:22 ` David Sterba
2022-04-06 6:05 ` [PATCH 24/27] block: add a bdev_discard_granularity helper Christoph Hellwig
2022-04-06 18:26 ` Ryusuke Konishi
2022-04-07 3:32 ` [Ocfs2-devel] " Martin K. Petersen
2022-04-07 15:26 ` David Sterba
2022-04-06 6:05 ` [PATCH 25/27] block: remove QUEUE_FLAG_DISCARD Christoph Hellwig
2022-04-07 3:34 ` [Ocfs2-devel] " Martin K. Petersen
2022-04-07 5:18 ` Coly Li [this message]
2022-04-06 6:05 ` [PATCH 26/27] block: uncouple REQ_OP_SECURE_ERASE from REQ_OP_DISCARD Christoph Hellwig
2022-04-07 3:36 ` [Ocfs2-devel] " Martin K. Petersen
2022-04-07 6:09 ` Coly Li
2022-04-07 7:01 ` Ryusuke Konishi
2022-04-07 15:26 ` David Sterba
2022-04-11 18:24 ` [f2fs-dev] " Jaegeuk Kim
2022-04-06 6:05 ` [PATCH 27/27] direct-io: remove random prefetches Christoph Hellwig
[not found] ` <0b7ae3df301c4fdd8d37f773d8d1eb93@FR3P281MB0843.DEUP281.PROD.OUTLOOK.COM>
2022-04-06 7:04 ` [PATCH 15/27] block: use bdev_alignment_offset in part_alignment_offset_show Alan Robinson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f326944f-46b1-e888-18f6-97dcf69d945d@suse.de \
--to=colyli@suse.de \
--cc=axboe@kernel.dk \
--cc=ceph-devel@vger.kernel.org \
--cc=cluster-devel@redhat.com \
--cc=dm-devel@redhat.com \
--cc=drbd-dev@lists.linbit.com \
--cc=hch@lst.de \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-nilfs@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=linux-xfs@vger.kernel.org \
--cc=nbd@other.debian.org \
--cc=ntfs3@lists.linux.dev \
--cc=ocfs2-devel@oss.oracle.com \
--cc=target-devel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).