From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC7B4C433EF for ; Thu, 14 Oct 2021 15:36:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5F75A60F70 for ; Thu, 14 Oct 2021 15:36:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5F75A60F70 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id F3AB7900003; Thu, 14 Oct 2021 11:36:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EC24F900002; Thu, 14 Oct 2021 11:36:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D63B0900003; Thu, 14 Oct 2021 11:36:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0233.hostedemail.com [216.40.44.233]) by kanga.kvack.org (Postfix) with ESMTP id C59A0900002 for ; Thu, 14 Oct 2021 11:36:24 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 8B9E3231C7 for ; Thu, 14 Oct 2021 15:36:24 +0000 (UTC) X-FDA: 78695444688.12.C73B733 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf02.hostedemail.com (Postfix) with ESMTP id 1527B7001A24 for ; Thu, 14 Oct 2021 15:36:22 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 113832199D; Thu, 14 Oct 2021 15:36:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1634225783; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hfCwUxPav+5NMXp6E/NQJY5UwNLjQOLziGSbZZ1HUl4=; b=zskhCKQR7MLMfGBQG9LY4tClO48hLJyuPFIryiADcJuXnMzpI5PNhcLhEuF5wvLph9Qfbq lOG91gsXPBeZp6OkNp8RVvzUJJD2oVWIuASBZZvIXA/zNHibzIfvu+nrZD+euj8d0PfZRp M6upmWMdkaY21VS7Bu1HrAWUrprrN40= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1634225783; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hfCwUxPav+5NMXp6E/NQJY5UwNLjQOLziGSbZZ1HUl4=; b=AtVsJG+JtGYst8VgqzZHtsBbJGyCbw4oMCR1gH0Zsm2CMx8Z89cB+729ieNEwejGkqPcSA IbbDBgZHcvTFNACw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D242413D9F; Thu, 14 Oct 2021 15:36:22 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id nX2OMnZOaGFRHgAAMHmgww (envelope-from ); Thu, 14 Oct 2021 15:36:22 +0000 Message-ID: Date: Thu, 14 Oct 2021 17:36:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH 5/8] mm/page_alloc: Remove the throttling logic from the page allocator Content-Language: en-US To: Mel Gorman , Linux-MM Cc: NeilBrown , Theodore Ts'o , Andreas Dilger , "Darrick J . Wong" , Matthew Wilcox , Michal Hocko , Dave Chinner , Rik van Riel , Johannes Weiner , Jonathan Corbet , Linux-fsdevel , LKML References: <20211008135332.19567-1-mgorman@techsingularity.net> <20211008135332.19567-6-mgorman@techsingularity.net> From: Vlastimil Babka In-Reply-To: <20211008135332.19567-6-mgorman@techsingularity.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 1527B7001A24 X-Stat-Signature: mqxe41fxjc11fyrx1ph3eofyrrwke7nd Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=zskhCKQR; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=AtVsJG+J; dmarc=none; spf=pass (imf02.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz X-HE-Tag: 1634225782-996677 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/8/21 15:53, Mel Gorman wrote: > The page allocator stalls based on the number of pages that are > waiting for writeback to start but this should now be redundant. > shrink_inactive_list() will wake flusher threads if the LRU tail are > unqueued dirty pages so the flusher should be active. If it fails to make > progress due to pages under writeback not being completed quickly then > it should stall on VMSCAN_THROTTLE_WRITEBACK. > > Signed-off-by: Mel Gorman Acked-by: Vlastimil Babka > --- > mm/page_alloc.c | 21 +-------------------- > 1 file changed, 1 insertion(+), 20 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 78e538067651..8fa0109ff417 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -4795,30 +4795,11 @@ should_reclaim_retry(gfp_t gfp_mask, unsigned order, > trace_reclaim_retry_zone(z, order, reclaimable, > available, min_wmark, *no_progress_loops, wmark); > if (wmark) { > - /* > - * If we didn't make any progress and have a lot of > - * dirty + writeback pages then we should wait for > - * an IO to complete to slow down the reclaim and > - * prevent from pre mature OOM > - */ > - if (!did_some_progress) { > - unsigned long write_pending; > - > - write_pending = zone_page_state_snapshot(zone, > - NR_ZONE_WRITE_PENDING); > - > - if (2 * write_pending > reclaimable) { > - congestion_wait(BLK_RW_ASYNC, HZ/10); > - return true; > - } > - } > - > ret = true; > - goto out; > + break; > } > } > > -out: > /* > * Memory allocation/reclaim might be called from a WQ context and the > * current implementation of the WQ concurrency control doesn't >