From: Vasily Averin <vvs@virtuozzo.com>
To: Johannes Weiner <hannes@cmpxchg.org>, Shakeel Butt <shakeelb@google.com>
Cc: Michal Hocko <mhocko@suse.com>,
Mel Gorman <mgorman@techsingularity.net>,
Uladzislau Rezki <urezki@gmail.com>, Roman Gushchin <guro@fb.com>,
Andrew Morton <akpm@linux-foundation.org>,
Cgroups <cgroups@vger.kernel.org>, Linux MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] memcg: page_alloc: skip bulk allocator for __GFP_ACCOUNT
Date: Thu, 14 Oct 2021 20:43:16 +0300 [thread overview]
Message-ID: <f4fd9e5f-b054-41af-e8a8-7a3074f937d8@virtuozzo.com> (raw)
In-Reply-To: <YWhLeAL5RPfLjrlO@cmpxchg.org>
On 14.10.2021 18:23, Johannes Weiner wrote:
> On Thu, Oct 14, 2021 at 08:01:16AM -0700, Shakeel Butt wrote:
>> Regarding xfs_buf_alloc_pages(), it is not using __GFP_ACCOUNT
>
> It probably should, actually. Sorry, somewhat off-topic, but we've
> seen this consume quite large amounts of memory. __GFP_ACCOUNT and
> vmstat tracking seems overdue for this one.
If this will be required, you can use
[PATCH mm v5] memcg: enable memory accounting in __alloc_pages_bulk
https://lkml.org/lkml/2021/10/14/197
As far as I understand it will not be used right now,
however I decided to submit it anyway, perhaps it may be needed later.
Thank you,
Vasily Averin
prev parent reply other threads:[~2021-10-14 17:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 19:43 [PATCH] memcg: page_alloc: skip bulk allocator for __GFP_ACCOUNT Shakeel Butt
2021-10-13 22:03 ` Roman Gushchin
2021-10-13 22:26 ` Shakeel Butt
2021-10-13 23:15 ` Roman Gushchin
2021-10-13 23:45 ` Shakeel Butt
2021-10-14 0:06 ` Roman Gushchin
2021-10-14 0:08 ` Matthew Wilcox
2021-10-14 7:05 ` Vasily Averin
2021-10-14 7:18 ` Michal Hocko
2021-10-14 7:16 ` Michal Hocko
2021-10-14 15:01 ` Shakeel Butt
2021-10-14 15:13 ` Michal Hocko
2021-10-14 15:23 ` Johannes Weiner
2021-10-14 17:43 ` Vasily Averin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4fd9e5f-b054-41af-e8a8-7a3074f937d8@virtuozzo.com \
--to=vvs@virtuozzo.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=shakeelb@google.com \
--cc=urezki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).