From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0ED2FC38145 for ; Wed, 7 Sep 2022 03:29:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8B38A8D0001; Tue, 6 Sep 2022 23:29:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 863396B0073; Tue, 6 Sep 2022 23:29:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 72B008D0001; Tue, 6 Sep 2022 23:29:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 634036B0072 for ; Tue, 6 Sep 2022 23:29:25 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 25C8D8032A for ; Wed, 7 Sep 2022 03:29:25 +0000 (UTC) X-FDA: 79883859090.22.744B164 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf09.hostedemail.com (Postfix) with ESMTP id 1481A140089 for ; Wed, 7 Sep 2022 03:29:23 +0000 (UTC) Received: from dggpemm500024.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4MMnjf4yKFznWK2; Wed, 7 Sep 2022 11:26:46 +0800 (CST) Received: from dggpemm500014.china.huawei.com (7.185.36.153) by dggpemm500024.china.huawei.com (7.185.36.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 7 Sep 2022 11:29:20 +0800 Received: from [10.174.178.120] (10.174.178.120) by dggpemm500014.china.huawei.com (7.185.36.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 7 Sep 2022 11:29:19 +0800 Message-ID: Date: Wed, 7 Sep 2022 11:29:19 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.1.2 CC: , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH -next v3 2/2] mm: sysctl: Introduce per zone watermark_scale_factor Content-Language: en-US To: References: <20220905032858.1462927-1-mawupeng1@huawei.com> <20220905032858.1462927-3-mawupeng1@huawei.com> From: mawupeng In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.120] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm500014.china.huawei.com (7.185.36.153) X-CFilter-Loop: Reflected ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662521364; a=rsa-sha256; cv=none; b=E4YFFWZMxUJEvSHOwv5nuHCUzHvkGO9IUbc/rsuYF+/uxUdIks5SoWLEw7uPJxI1T6wzy2 Vr+CW+bsCZJyWL+OOkI9K4jzsTSIxW6RIRiWovrUwsKOE1a5eqwsbAbPeJl1PEHOTX2faw wjCAYDF8uSO+Q6600+tczt0vKEwgSWw= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; spf=pass (imf09.hostedemail.com: domain of mawupeng1@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=mawupeng1@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662521364; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4jWT3BskEQ6e948Yqb9RRgS9ug8o0krWUAuKDYOTDzM=; b=mVFtlt7GOla+3va3Og0q7qeFvm7/MuwiAa7BWoWNzAb/DxqZnAoYCTY5mbf2+2hk3E1fbl E2zN7dTTBljPu1P0xt+x3WhKxqUmZ1cBrg3vgQUaIjMhruIheMJNBVcdGE5CYhEanpw2iP mFNXBIsV7k2Viz03NLUc0sb4pqDtMkM= X-Stat-Signature: i7bgz149g7ixchuqza6dosayodcee7ks X-Rspamd-Queue-Id: 1481A140089 Authentication-Results: imf09.hostedemail.com; dkim=none; spf=pass (imf09.hostedemail.com: domain of mawupeng1@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=mawupeng1@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-Rspamd-Server: rspam11 X-Rspam-User: X-HE-Tag: 1662521363-65668 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/9/7 2:23, Luis Chamberlain wrote: > On Mon, Sep 05, 2022 at 11:28:58AM +0800, Wupeng Ma wrote: >> diff --git a/kernel/sysctl.c b/kernel/sysctl.c >> index 205d605cacc5..d16d06c71e5a 100644 >> --- a/kernel/sysctl.c >> +++ b/kernel/sysctl.c >> @@ -2251,8 +2251,6 @@ static struct ctl_table vm_table[] = { >> .maxlen = sizeof(watermark_scale_factor), >> .mode = 0644, >> .proc_handler = watermark_scale_factor_sysctl_handler, >> - .extra1 = SYSCTL_ONE, >> - .extra2 = SYSCTL_THREE_THOUSAND, >> }, >> { >> .procname = "percpu_pagelist_high_fraction", > > Please move the sysctl from kernel/sysctl.c to mm/page_alloc.c while > at it, you can git log the kernel/sysctl.c for prior moves and for > the motivations. No need to keep expanding on the existing table. > > Luis Ok. I will move this sysctl to mm/page_alloc.c next version.