From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1602DC433DB for ; Sat, 30 Jan 2021 22:07:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 87CDE64E05 for ; Sat, 30 Jan 2021 22:07:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 87CDE64E05 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7EDE86B0005; Sat, 30 Jan 2021 17:07:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 779586B0006; Sat, 30 Jan 2021 17:07:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 642246B006C; Sat, 30 Jan 2021 17:07:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0043.hostedemail.com [216.40.44.43]) by kanga.kvack.org (Postfix) with ESMTP id 4A60F6B0005 for ; Sat, 30 Jan 2021 17:07:34 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 0A1D41EE6 for ; Sat, 30 Jan 2021 22:07:34 +0000 (UTC) X-FDA: 77763828828.12.mine09_5900a0c275b4 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin12.hostedemail.com (Postfix) with ESMTP id DBB2B1801119D for ; Sat, 30 Jan 2021 22:07:33 +0000 (UTC) X-HE-Tag: mine09_5900a0c275b4 X-Filterd-Recvd-Size: 4117 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by imf30.hostedemail.com (Postfix) with ESMTP for ; Sat, 30 Jan 2021 22:07:33 +0000 (UTC) Received: by mail-pl1-f173.google.com with SMTP id b17so7827929plz.6 for ; Sat, 30 Jan 2021 14:07:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=/P/b4VQw8CInKf0Exrq1ninzQwAk3br3MdPWZqjCM5w=; b=RnuxL8ThemW1uGFiJS+C2acS9C2US8HUzkp5RgN0kj9o1dwU0VOBcuKG6XOtZssWLQ I3RQ7n3hildS5pk9uJaw188Ax4uVQNBeA8cN7tDqnZUpSmxvM7CwSBF4gHnCXdSvKOFc t+KTIlRo1kTmTIWzbXPph6cQVhQTNtyVtbLmvVi9QVIzzDG+RfDVpGRLjnxerJIByljY GUSp20jDiFJNRUVhpibuvr1hc8VY97QRsVChOp0WFifjy4m1Y5gfDsGkVGM3g/ezfmM3 dSgBjkLJdPbem0ZO+HR1WpA8thVwubtjK0L0ppbyzgLhkYbF5WYkycJ4pj+4oWIJO4F5 et3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=/P/b4VQw8CInKf0Exrq1ninzQwAk3br3MdPWZqjCM5w=; b=RltPa7mAJrWBBfgm/ZjB7wsEKjGlTH3nFDSRJfXQj3bj54KUWRQY1/FslT/yvgS1/V rrO4rcTLEq/LWM3OtR9UB1EEICSPcMd+xuVXx92PjU04ZaLjqj4rQMjpQg5s+tNsEGn0 1yDT5yqoP159h+pzns1q/3M/8f8cDyBHtl7rKzVhLxamGWj+ioR6oi03WrQcjJ/gBQpa ZdZz6AfAGEVbupw33c434IXCGELlb2Hv4bz8BsKAVomYS2enGTgB5epfUFUDZ2XQibhE COp4s7T43xXtk76yNlnPuCPPq8xNflONNUjAGbDds0zpWAzzWXtVFQ2jRBTprsZVUfNN nl1g== X-Gm-Message-State: AOAM533hRI8tw2aEQVQbjp5Fb3lZay8Rf8RieGJv0wII0vJu005Uf3nt PklzymsTTaXXNGxGarBO3Z1q5g== X-Google-Smtp-Source: ABdhPJzF4+1uWzCoKE7IesB3JWQ/9H0IiQv7PngPRUVmqwH3eeUfxC9UjmOq+5lDB4sP8lod17N5aA== X-Received: by 2002:a17:90a:9905:: with SMTP id b5mr10339808pjp.195.1612044452393; Sat, 30 Jan 2021 14:07:32 -0800 (PST) Received: from [2620:15c:17:3:4a0f:cfff:fe51:6667] ([2620:15c:17:3:4a0f:cfff:fe51:6667]) by smtp.gmail.com with ESMTPSA id b14sm12004292pju.14.2021.01.30.14.07.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 Jan 2021 14:07:31 -0800 (PST) Date: Sat, 30 Jan 2021 14:07:30 -0800 (PST) From: David Rientjes To: Miaohe Lin cc: akpm@linux-foundation.org, mike.kravetz@oracle.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] hugetlbfs: show pagesize in unit of GB if possible In-Reply-To: <20210130090339.4378-1-linmiaohe@huawei.com> Message-ID: References: <20210130090339.4378-1-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 30 Jan 2021, Miaohe Lin wrote: > Hugepage size in unit of GB is supported. We could show pagesize in unit of > GB to make it more friendly to read. Also rework the calculation code of > page size unit to make it more readable. > > Signed-off-by: Miaohe Lin > --- > fs/hugetlbfs/inode.c | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c > index 3a08fbae3b53..40a9795f250a 100644 > --- a/fs/hugetlbfs/inode.c > +++ b/fs/hugetlbfs/inode.c > @@ -1014,11 +1014,15 @@ static int hugetlbfs_show_options(struct seq_file *m, struct dentry *root) > if (sbinfo->max_inodes != -1) > seq_printf(m, ",nr_inodes=%lu", sbinfo->max_inodes); > > - hpage_size /= 1024; > - mod = 'K'; > - if (hpage_size >= 1024) { > - hpage_size /= 1024; > + if (hpage_size >= SZ_1G) { > + hpage_size /= SZ_1G; > + mod = 'G'; > + } else if (hpage_size >= SZ_1M) { > + hpage_size /= SZ_1M; > mod = 'M'; > + } else { > + hpage_size /= SZ_1K; > + mod = 'K'; > } > seq_printf(m, ",pagesize=%lu%c", hpage_size, mod); > if (spool) { NACK, this can break existing userspace parsing.