From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD9F3C4338F for ; Wed, 18 Aug 2021 16:14:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 51416610F8 for ; Wed, 18 Aug 2021 16:14:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 51416610F8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 681C16B006C; Wed, 18 Aug 2021 12:14:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 631C86B0072; Wed, 18 Aug 2021 12:14:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 520488D0001; Wed, 18 Aug 2021 12:14:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0180.hostedemail.com [216.40.44.180]) by kanga.kvack.org (Postfix) with ESMTP id 378F76B006C for ; Wed, 18 Aug 2021 12:14:47 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id D1FB916902 for ; Wed, 18 Aug 2021 16:14:46 +0000 (UTC) X-FDA: 78488699772.24.9279099 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by imf24.hostedemail.com (Postfix) with ESMTP id 5E134B0056E6 for ; Wed, 18 Aug 2021 16:14:45 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10080"; a="238469263" X-IronPort-AV: E=Sophos;i="5.84,330,1620716400"; d="scan'208";a="238469263" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Aug 2021 09:14:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,330,1620716400"; d="scan'208";a="641385365" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga005.jf.intel.com with ESMTP; 18 Aug 2021 09:14:40 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Wed, 18 Aug 2021 09:14:39 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Wed, 18 Aug 2021 09:14:39 -0700 Received: from fmsmsx610.amr.corp.intel.com ([10.18.126.90]) by fmsmsx610.amr.corp.intel.com ([10.18.126.90]) with mapi id 15.01.2242.010; Wed, 18 Aug 2021 09:14:39 -0700 From: "Luck, Tony" To: Borislav Petkov CC: Jue Wang , Ding Hui , "naoya.horiguchi@nec.com" , "osalvador@suse.de" , "Song, Youquan" , "huangcun@sangfor.com.cn" , "x86@kernel.org" , "linux-edac@vger.kernel.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH v2 0/3] More machine check recovery fixes Thread-Topic: [PATCH v2 0/3] More machine check recovery fixes Thread-Index: AQHXk8gpkFvZ1Gbe80CQzogjtbcrGqt5byJw Date: Wed, 18 Aug 2021 16:14:38 +0000 Message-ID: References: <20210706190620.1290391-1-tony.luck@intel.com> <20210818002942.1607544-1-tony.luck@intel.com> In-Reply-To: <20210818002942.1607544-1-tony.luck@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 x-originating-ip: [10.1.200.100] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Rspamd-Queue-Id: 5E134B0056E6 Authentication-Results: imf24.hostedemail.com; dkim=none; spf=none (imf24.hostedemail.com: domain of tony.luck@intel.com has no SPF policy when checking 192.55.52.88) smtp.mailfrom=tony.luck@intel.com; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=intel.com (policy=none) X-Rspamd-Server: rspam01 X-Stat-Signature: tc6mxhs1beaibwsaho1ogezry4qnsn5t X-HE-Tag: 1629303285-653116 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000016, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > Changes since v1: > 1) Fix bug in kill_me_never() that forgot to clear p->mce_count so > repeated recovery in the same task would trigger the panic for > "Machine checks to different user pages" > [Note to Jue Wang ... this *might* be why your test that injects > two errors into the same buffer passed to a write(2) syscall > failed with this message] I recreated Jue's specific test today with uncorrected errors in two pages passed to a write(2) syscall. buf =3D alloc(2 pages); inject(buf + 0x440); inject*buf + 0x11c0); n =3D write(fd, buf, 8K); Result was that the write returned 0x440 (i.e. bytes written up to the first poison location). -Tony