* [PATCH] mm: cma: improve pr_debug log in cma_release()
@ 2020-11-25 15:32 Charan Teja Reddy
2020-11-25 15:49 ` Souptick Joarder
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Charan Teja Reddy @ 2020-11-25 15:32 UTC (permalink / raw)
To: akpm, iamjoonsoo.kim, linux-mm; +Cc: linux-kernel, vinmenon, Charan Teja Reddy
It is required to print 'count' of pages, along with the pages, passed
to cma_release to debug the cases of mismatched count value passed
between cma_alloc() and cma_release() from a code path.
As an example, consider the below scenario:
1) CMA pool size is 4MB and
2) User doing the erroneous step of allocating 2 pages but freeing 1
page in a loop from this CMA pool.
The step 2 causes cma_alloc() to return NULL at one point of time
because of -ENOMEM condition.
And the current pr_debug logs is not giving the info about these types
of allocation patterns because of count value not being printed in
cma_release().
We are printing the count value in the trace logs, just extend the same
to pr_debug logs too.
Signed-off-by: Charan Teja Reddy <charante@codeaurora.org>
---
mm/cma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/cma.c b/mm/cma.c
index 7f415d7..07c904b 100644
--- a/mm/cma.c
+++ b/mm/cma.c
@@ -512,7 +512,7 @@ bool cma_release(struct cma *cma, const struct page *pages, unsigned int count)
if (!cma || !pages)
return false;
- pr_debug("%s(page %p)\n", __func__, (void *)pages);
+ pr_debug("%s(page %p, count %zu)\n", __func__, (void *)pages, count);
pfn = page_to_pfn(pages);
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
member of the Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] mm: cma: improve pr_debug log in cma_release()
2020-11-25 15:32 [PATCH] mm: cma: improve pr_debug log in cma_release() Charan Teja Reddy
@ 2020-11-25 15:49 ` Souptick Joarder
2020-11-25 16:39 ` David Hildenbrand
2020-11-27 15:49 ` Vlastimil Babka
2 siblings, 0 replies; 4+ messages in thread
From: Souptick Joarder @ 2020-11-25 15:49 UTC (permalink / raw)
To: Charan Teja Reddy
Cc: Andrew Morton, Joonsoo Kim, Linux-MM, linux-kernel, vinmenon
On Wed, Nov 25, 2020 at 9:02 PM Charan Teja Reddy
<charante@codeaurora.org> wrote:
>
> It is required to print 'count' of pages, along with the pages, passed
> to cma_release to debug the cases of mismatched count value passed
> between cma_alloc() and cma_release() from a code path.
>
> As an example, consider the below scenario:
> 1) CMA pool size is 4MB and
> 2) User doing the erroneous step of allocating 2 pages but freeing 1
> page in a loop from this CMA pool.
> The step 2 causes cma_alloc() to return NULL at one point of time
> because of -ENOMEM condition.
>
> And the current pr_debug logs is not giving the info about these types
> of allocation patterns because of count value not being printed in
> cma_release().
>
> We are printing the count value in the trace logs, just extend the same
> to pr_debug logs too.
>
> Signed-off-by: Charan Teja Reddy <charante@codeaurora.org>
Reviewed-by: Souptick Joarder <jrdr.linux@gmail.com>
> ---
> mm/cma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/cma.c b/mm/cma.c
> index 7f415d7..07c904b 100644
> --- a/mm/cma.c
> +++ b/mm/cma.c
> @@ -512,7 +512,7 @@ bool cma_release(struct cma *cma, const struct page *pages, unsigned int count)
> if (!cma || !pages)
> return false;
>
> - pr_debug("%s(page %p)\n", __func__, (void *)pages);
> + pr_debug("%s(page %p, count %zu)\n", __func__, (void *)pages, count);
>
> pfn = page_to_pfn(pages);
>
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
> member of the Code Aurora Forum, hosted by The Linux Foundation
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mm: cma: improve pr_debug log in cma_release()
2020-11-25 15:32 [PATCH] mm: cma: improve pr_debug log in cma_release() Charan Teja Reddy
2020-11-25 15:49 ` Souptick Joarder
@ 2020-11-25 16:39 ` David Hildenbrand
2020-11-27 15:49 ` Vlastimil Babka
2 siblings, 0 replies; 4+ messages in thread
From: David Hildenbrand @ 2020-11-25 16:39 UTC (permalink / raw)
To: Charan Teja Reddy, akpm, iamjoonsoo.kim, linux-mm; +Cc: linux-kernel, vinmenon
On 25.11.20 16:32, Charan Teja Reddy wrote:
> It is required to print 'count' of pages, along with the pages, passed
> to cma_release to debug the cases of mismatched count value passed
> between cma_alloc() and cma_release() from a code path.
>
> As an example, consider the below scenario:
> 1) CMA pool size is 4MB and
> 2) User doing the erroneous step of allocating 2 pages but freeing 1
> page in a loop from this CMA pool.
> The step 2 causes cma_alloc() to return NULL at one point of time
> because of -ENOMEM condition.
>
> And the current pr_debug logs is not giving the info about these types
> of allocation patterns because of count value not being printed in
> cma_release().
>
> We are printing the count value in the trace logs, just extend the same
> to pr_debug logs too.
>
> Signed-off-by: Charan Teja Reddy <charante@codeaurora.org>
> ---
> mm/cma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/cma.c b/mm/cma.c
> index 7f415d7..07c904b 100644
> --- a/mm/cma.c
> +++ b/mm/cma.c
> @@ -512,7 +512,7 @@ bool cma_release(struct cma *cma, const struct page *pages, unsigned int count)
> if (!cma || !pages)
> return false;
>
> - pr_debug("%s(page %p)\n", __func__, (void *)pages);
> + pr_debug("%s(page %p, count %zu)\n", __func__, (void *)pages, count);
>
> pfn = page_to_pfn(pages);
>
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mm: cma: improve pr_debug log in cma_release()
2020-11-25 15:32 [PATCH] mm: cma: improve pr_debug log in cma_release() Charan Teja Reddy
2020-11-25 15:49 ` Souptick Joarder
2020-11-25 16:39 ` David Hildenbrand
@ 2020-11-27 15:49 ` Vlastimil Babka
2 siblings, 0 replies; 4+ messages in thread
From: Vlastimil Babka @ 2020-11-27 15:49 UTC (permalink / raw)
To: Charan Teja Reddy, akpm, iamjoonsoo.kim, linux-mm; +Cc: linux-kernel, vinmenon
On 11/25/20 4:32 PM, Charan Teja Reddy wrote:
> It is required to print 'count' of pages, along with the pages, passed
> to cma_release to debug the cases of mismatched count value passed
> between cma_alloc() and cma_release() from a code path.
>
> As an example, consider the below scenario:
> 1) CMA pool size is 4MB and
> 2) User doing the erroneous step of allocating 2 pages but freeing 1
> page in a loop from this CMA pool.
> The step 2 causes cma_alloc() to return NULL at one point of time
> because of -ENOMEM condition.
>
> And the current pr_debug logs is not giving the info about these types
> of allocation patterns because of count value not being printed in
> cma_release().
>
> We are printing the count value in the trace logs, just extend the same
> to pr_debug logs too.
>
> Signed-off-by: Charan Teja Reddy <charante@codeaurora.org>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
> ---
> mm/cma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/cma.c b/mm/cma.c
> index 7f415d7..07c904b 100644
> --- a/mm/cma.c
> +++ b/mm/cma.c
> @@ -512,7 +512,7 @@ bool cma_release(struct cma *cma, const struct page *pages, unsigned int count)
> if (!cma || !pages)
> return false;
>
> - pr_debug("%s(page %p)\n", __func__, (void *)pages);
> + pr_debug("%s(page %p, count %zu)\n", __func__, (void *)pages, count);
>
> pfn = page_to_pfn(pages);
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-11-27 15:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-25 15:32 [PATCH] mm: cma: improve pr_debug log in cma_release() Charan Teja Reddy
2020-11-25 15:49 ` Souptick Joarder
2020-11-25 16:39 ` David Hildenbrand
2020-11-27 15:49 ` Vlastimil Babka
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).