From: David Hildenbrand <david@redhat.com>
To: Matthew Wilcox <willy@infradead.org>,
Pasha Tatashin <pasha.tatashin@soleen.com>
Cc: akpm@linux-foundation.org, corbet@lwn.net, linux-mm@kvack.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
rick.p.edgecombe@intel.com
Subject: Re: [PATCH 2/3] mm/page_table_check: Do WARN_ON instead of BUG_ON by default
Date: Mon, 26 Sep 2022 10:28:26 +0200 [thread overview]
Message-ID: <f8ff6148-2775-4465-809b-36a4e5a4c403@redhat.com> (raw)
In-Reply-To: <Yx4IEvkmAlcTIP6v@casper.infradead.org>
On 11.09.22 18:08, Matthew Wilcox wrote:
> On Sun, Sep 11, 2022 at 09:59:22AM +0000, Pasha Tatashin wrote:
>> Currently, page_table_check when detects errors panics kernel. Instead,
>> print a warning, and panic only when specifically requested via kernel
>> parameter:
>>
>> page_table_check=panic
>
> Why are the page table checks so special that they deserve their own
> command line parameter? Why shouldn't this be controlled by the usual
> panic_on_warn option?
>
I agree.
https://lkml.kernel.org/r/20220923113426.52871-2-david@redhat.com
Use of WARN_ON_ONCE is the way to go nowadays.
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2022-09-26 8:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-11 9:59 [PATCH 0/3] page table check default to warn instead of panic Pasha Tatashin
2022-09-11 9:59 ` [PATCH 1/3] mm/page_table_check: Check writable zero page in page table check Pasha Tatashin
2022-09-12 15:58 ` Edgecombe, Rick P
2022-09-26 8:26 ` David Hildenbrand
2022-09-11 9:59 ` [PATCH 2/3] mm/page_table_check: Do WARN_ON instead of BUG_ON by default Pasha Tatashin
2022-09-11 16:08 ` Matthew Wilcox
2022-09-11 20:42 ` Pasha Tatashin
2022-09-26 8:28 ` David Hildenbrand [this message]
2022-09-26 1:16 ` [mm/page_table_check] 6e807506f4: WARNING:at_mm/page_table_check.c:#page_table_check_set kernel test robot
2022-09-11 9:59 ` [PATCH 3/3] doc/vm: add information about page_table_check=panic Pasha Tatashin
2022-09-12 20:23 ` [PATCH 0/3] page table check default to warn instead of panic Andrew Morton
2022-09-20 18:11 ` Pasha Tatashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8ff6148-2775-4465-809b-36a4e5a4c403@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pasha.tatashin@soleen.com \
--cc=rick.p.edgecombe@intel.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).