* [PATCH] microblaze: fix min_low_pfn/max_low_pfn build errors
@ 2020-08-29 0:01 Randy Dunlap
2020-08-29 21:37 ` David Rientjes
2020-08-31 14:04 ` Michal Simek
0 siblings, 2 replies; 3+ messages in thread
From: Randy Dunlap @ 2020-08-29 0:01 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, kernel test robot, linux-mm, Andrew Morton,
David Rientjes, Mike Rapoport, Michal Simek, Michal Simek
Fix min_low_pfn/max_low_pfn build errors for arch/microblaze/: (e.g.)
ERROR: "min_low_pfn" [drivers/rpmsg/virtio_rpmsg_bus.ko] undefined!
ERROR: "min_low_pfn" [drivers/hwtracing/intel_th/intel_th_msu_sink.ko] undefined!
ERROR: "min_low_pfn" [drivers/hwtracing/intel_th/intel_th_msu.ko] undefined!
ERROR: "min_low_pfn" [drivers/mmc/core/mmc_core.ko] undefined!
ERROR: "min_low_pfn" [drivers/md/dm-crypt.ko] undefined!
ERROR: "min_low_pfn" [drivers/net/wireless/ath/ath6kl/ath6kl_sdio.ko] undefined!
ERROR: "min_low_pfn" [crypto/tcrypt.ko] undefined!
ERROR: "min_low_pfn" [crypto/asymmetric_keys/asym_tpm.ko] undefined!
Mike had/has an alternate patch for Microblaze:
https://lore.kernel.org/lkml/20200630111519.GA1951986@linux.ibm.com/
David suggested just exporting min_low_pfn & max_low_pfn in
mm/memblock.c:
https://lore.kernel.org/lkml/alpine.DEB.2.22.394.2006291911220.1118534@chino.kir.corp.google.com/
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-mm@kvack.org
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: David Rientjes <rientjes@google.com>
Cc: Mike Rapoport <rppt@linux.ibm.com>
Cc: Michal Simek <monstr@monstr.eu>
Cc: Michal Simek <michal.simek@xilinx.com>
---
arch/microblaze/mm/init.c | 3 +++
1 file changed, 3 insertions(+)
--- linux-next-20200825.orig/arch/microblaze/mm/init.c
+++ linux-next-20200825/arch/microblaze/mm/init.c
@@ -46,6 +46,9 @@ unsigned long memory_size;
EXPORT_SYMBOL(memory_size);
unsigned long lowmem_size;
+EXPORT_SYMBOL(min_low_pfn);
+EXPORT_SYMBOL(max_low_pfn);
+
#ifdef CONFIG_HIGHMEM
pte_t *kmap_pte;
EXPORT_SYMBOL(kmap_pte);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] microblaze: fix min_low_pfn/max_low_pfn build errors
2020-08-29 0:01 [PATCH] microblaze: fix min_low_pfn/max_low_pfn build errors Randy Dunlap
@ 2020-08-29 21:37 ` David Rientjes
2020-08-31 14:04 ` Michal Simek
1 sibling, 0 replies; 3+ messages in thread
From: David Rientjes @ 2020-08-29 21:37 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, kernel test robot, linux-mm, Andrew Morton,
Mike Rapoport, Michal Simek, Michal Simek
On Fri, 28 Aug 2020, Randy Dunlap wrote:
> Fix min_low_pfn/max_low_pfn build errors for arch/microblaze/: (e.g.)
>
> ERROR: "min_low_pfn" [drivers/rpmsg/virtio_rpmsg_bus.ko] undefined!
> ERROR: "min_low_pfn" [drivers/hwtracing/intel_th/intel_th_msu_sink.ko] undefined!
> ERROR: "min_low_pfn" [drivers/hwtracing/intel_th/intel_th_msu.ko] undefined!
> ERROR: "min_low_pfn" [drivers/mmc/core/mmc_core.ko] undefined!
> ERROR: "min_low_pfn" [drivers/md/dm-crypt.ko] undefined!
> ERROR: "min_low_pfn" [drivers/net/wireless/ath/ath6kl/ath6kl_sdio.ko] undefined!
> ERROR: "min_low_pfn" [crypto/tcrypt.ko] undefined!
> ERROR: "min_low_pfn" [crypto/asymmetric_keys/asym_tpm.ko] undefined!
>
> Mike had/has an alternate patch for Microblaze:
> https://lore.kernel.org/lkml/20200630111519.GA1951986@linux.ibm.com/
>
> David suggested just exporting min_low_pfn & max_low_pfn in
> mm/memblock.c:
> https://lore.kernel.org/lkml/alpine.DEB.2.22.394.2006291911220.1118534@chino.kir.corp.google.com/
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: linux-mm@kvack.org
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: David Rientjes <rientjes@google.com>
> Cc: Mike Rapoport <rppt@linux.ibm.com>
> Cc: Michal Simek <monstr@monstr.eu>
> Cc: Michal Simek <michal.simek@xilinx.com>
Acked-by: David Rientjes <rientjes@google.com>
Thanks Randy!
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] microblaze: fix min_low_pfn/max_low_pfn build errors
2020-08-29 0:01 [PATCH] microblaze: fix min_low_pfn/max_low_pfn build errors Randy Dunlap
2020-08-29 21:37 ` David Rientjes
@ 2020-08-31 14:04 ` Michal Simek
1 sibling, 0 replies; 3+ messages in thread
From: Michal Simek @ 2020-08-31 14:04 UTC (permalink / raw)
To: Randy Dunlap, linux-kernel
Cc: kernel test robot, linux-mm, Andrew Morton, David Rientjes,
Mike Rapoport, Michal Simek, Michal Simek
Hi,
On 29. 08. 20 2:01, Randy Dunlap wrote:
> Fix min_low_pfn/max_low_pfn build errors for arch/microblaze/: (e.g.)
>
> ERROR: "min_low_pfn" [drivers/rpmsg/virtio_rpmsg_bus.ko] undefined!
> ERROR: "min_low_pfn" [drivers/hwtracing/intel_th/intel_th_msu_sink.ko] undefined!
> ERROR: "min_low_pfn" [drivers/hwtracing/intel_th/intel_th_msu.ko] undefined!
> ERROR: "min_low_pfn" [drivers/mmc/core/mmc_core.ko] undefined!
> ERROR: "min_low_pfn" [drivers/md/dm-crypt.ko] undefined!
> ERROR: "min_low_pfn" [drivers/net/wireless/ath/ath6kl/ath6kl_sdio.ko] undefined!
> ERROR: "min_low_pfn" [crypto/tcrypt.ko] undefined!
> ERROR: "min_low_pfn" [crypto/asymmetric_keys/asym_tpm.ko] undefined!
>
> Mike had/has an alternate patch for Microblaze:
> https://lore.kernel.org/lkml/20200630111519.GA1951986@linux.ibm.com/
>
> David suggested just exporting min_low_pfn & max_low_pfn in
> mm/memblock.c:
> https://lore.kernel.org/lkml/alpine.DEB.2.22.394.2006291911220.1118534@chino.kir.corp.google.com/
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: linux-mm@kvack.org
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: David Rientjes <rientjes@google.com>
> Cc: Mike Rapoport <rppt@linux.ibm.com>
> Cc: Michal Simek <monstr@monstr.eu>
> Cc: Michal Simek <michal.simek@xilinx.com>
> ---
> arch/microblaze/mm/init.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> --- linux-next-20200825.orig/arch/microblaze/mm/init.c
> +++ linux-next-20200825/arch/microblaze/mm/init.c
> @@ -46,6 +46,9 @@ unsigned long memory_size;
> EXPORT_SYMBOL(memory_size);
> unsigned long lowmem_size;
>
> +EXPORT_SYMBOL(min_low_pfn);
> +EXPORT_SYMBOL(max_low_pfn);
> +
> #ifdef CONFIG_HIGHMEM
> pte_t *kmap_pte;
> EXPORT_SYMBOL(kmap_pte);
>
Acked-by: Michal Simek <monstr@monstr.eu>
Mike: Feel free to take it via memblock tree as you mentioned in
alternate patch.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-31 14:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-29 0:01 [PATCH] microblaze: fix min_low_pfn/max_low_pfn build errors Randy Dunlap
2020-08-29 21:37 ` David Rientjes
2020-08-31 14:04 ` Michal Simek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).