From: Vlastimil Babka <vbabka@suse.cz>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>,
Kees Cook <keescook@chromium.org>,
linux-mm@kvack.org
Cc: Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Hyeonggon Yoo <42.hyeyoo@gmail.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/slab_common: repair kernel-doc for __ksize()
Date: Thu, 3 Nov 2022 18:11:04 +0100 [thread overview]
Message-ID: <fccfaa2a-07f0-7d4d-027b-ec283a1cb748@suse.cz> (raw)
In-Reply-To: <20221031092920.976-1-lukas.bulwahn@gmail.com>
On 10/31/22 10:29, Lukas Bulwahn wrote:
> Commit 445d41d7a7c1 ("Merge branch 'slab/for-6.1/kmalloc_size_roundup' into
> slab/for-next") resolved a conflict of two concurrent changes to __ksize().
>
> However, it did not adjust the kernel-doc comment of __ksize(), while the
> name of the argument to __ksize() was renamed.
>
> Hence, ./scripts/ kernel-doc -none mm/slab_common.c warns about it.
>
> Adjust the kernel-doc comment for __ksize() for make W=1 happiness.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Thanks! Adding to slab/for-6.1-rc4/fixes
Vlastimil
> ---
> mm/slab_common.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/slab_common.c b/mm/slab_common.c
> index 33b1886b06eb..74a991fd9d31 100644
> --- a/mm/slab_common.c
> +++ b/mm/slab_common.c
> @@ -1010,7 +1010,7 @@ EXPORT_SYMBOL(kfree);
>
> /**
> * __ksize -- Report full size of underlying allocation
> - * @objp: pointer to the object
> + * @object: pointer to the object
> *
> * This should only be used internally to query the true size of allocations.
> * It is not meant to be a way to discover the usable size of an allocation
> @@ -1018,7 +1018,7 @@ EXPORT_SYMBOL(kfree);
> * the originally requested allocation size may trigger KASAN, UBSAN_BOUNDS,
> * and/or FORTIFY_SOURCE.
> *
> - * Return: size of the actual memory used by @objp in bytes
> + * Return: size of the actual memory used by @object in bytes
> */
> size_t __ksize(const void *object)
> {
prev parent reply other threads:[~2022-11-03 17:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-31 9:29 [PATCH] mm/slab_common: repair kernel-doc for __ksize() Lukas Bulwahn
2022-10-31 11:10 ` Hyeonggon Yoo
2022-11-03 17:11 ` Vlastimil Babka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fccfaa2a-07f0-7d4d-027b-ec283a1cb748@suse.cz \
--to=vbabka@suse.cz \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=keescook@chromium.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lukas.bulwahn@gmail.com \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).