From: David Hildenbrand <david@redhat.com>
To: Wei Yang <richardw.yang@linux.intel.com>,
n-horiguchi@ah.jp.nec.com, akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mm/memory-failure.c: not necessary to recalculate hpage
Date: Wed, 20 Nov 2019 16:07:38 +0100 [thread overview]
Message-ID: <fdba31c8-d0c0-83a8-62d1-c04c1e894218@redhat.com> (raw)
In-Reply-To: <20191118082003.26240-2-richardw.yang@linux.intel.com>
On 18.11.19 09:20, Wei Yang wrote:
> hpage is not changed.
>
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
> ---
> mm/memory-failure.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/mm/memory-failure.c b/mm/memory-failure.c
> index 392ac277b17d..9784f4339ae7 100644
> --- a/mm/memory-failure.c
> +++ b/mm/memory-failure.c
> @@ -1319,7 +1319,6 @@ int memory_failure(unsigned long pfn, int flags)
> }
> unlock_page(p);
> VM_BUG_ON_PAGE(!page_count(p), p);
> - hpage = compound_head(p);
> }
>
> /*
>
I am *absolutely* no transparent huge page expert (sorry :) ), but won't
the split_huge_page(p) eventually split the compound page, such that
compound_head(p) will return something else after that call?
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2019-11-20 15:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-18 8:20 [PATCH 1/2] mm/memory-failure.c: PageHuge is handled at the beginning of memory_failure Wei Yang
2019-11-18 8:20 ` [PATCH 2/2] mm/memory-failure.c: not necessary to recalculate hpage Wei Yang
2019-11-20 15:07 ` David Hildenbrand [this message]
2019-11-21 1:05 ` Wei Yang
2019-12-02 22:28 ` Wei Yang
2019-12-05 15:06 ` David Hildenbrand
2019-12-06 1:48 ` Wei Yang
2020-01-08 12:20 ` David Hildenbrand
2020-01-09 1:58 ` Wei Yang
2019-11-19 12:23 ` [PATCH 1/2] mm/memory-failure.c: PageHuge is handled at the beginning of memory_failure David Hildenbrand
2019-11-20 0:46 ` Wei Yang
2019-11-20 15:04 ` David Hildenbrand
2019-11-21 1:07 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fdba31c8-d0c0-83a8-62d1-c04c1e894218@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=richardw.yang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).