From: Paolo Bonzini <pbonzini@redhat.com>
To: Dan Williams <dan.j.williams@intel.com>,
Zhang Yi <yi.z.zhang@linux.intel.com>
Cc: "KVM list" <kvm@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
linux-nvdimm <linux-nvdimm@lists.01.org>,
"Jan Kara" <jack@suse.cz>, "Christoph Hellwig" <hch@lst.de>,
"Zhang, Yu C" <yu.c.zhang@intel.com>,
"Linux MM" <linux-mm@kvack.org>,
rkrcmar@redhat.com, "Zhang, Yi Z" <yi.z.zhang@intel.com>,
"Jérôme Glisse" <jglisse@redhat.com>
Subject: Re: [PATCH 3/3] kvm: add a function to check if page is from NVDIMM pmem.
Date: Wed, 4 Jul 2018 17:27:17 +0200 [thread overview]
Message-ID: <fe420914-212f-a18e-b6ec-f2b7a451c0d2@redhat.com> (raw)
In-Reply-To: <CAPcyv4is0T1SjsaC4Z80ND9Q_032_Tsa0hQwkO84T0FCRj5MkA@mail.gmail.com>
On 04/07/2018 16:50, Dan Williams wrote:
>> + return is_zone_device_page(page) &&
>> + ((page->pgmap->type == MEMORY_DEVICE_FS_DAX) ||
>> + (page->pgmap->type == MEMORY_DEVICE_DEV_DAX));
> Jerome, might there be any use case to pass MEMORY_DEVICE_PUBLIC
> memory to a guest vm?
>
An even better reason to place this in mm.h. :) There should be an
function to tell you if a reserved page has accessed/dirty bits etc.,
that's all that KVM needs to know.
Paolo
next prev parent reply other threads:[~2018-07-04 15:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-04 15:30 [PATCH 0/3] Fix kvm misconceives NVDIMM pages as reserved mmio Zhang Yi
2018-07-04 15:30 ` [PATCH 1/3] kvm: remove redundant reserved page check Zhang Yi
2018-07-04 15:30 ` [PATCH 2/3] mm: introduce memory type MEMORY_DEVICE_DEV_DAX Zhang Yi
2018-07-04 14:50 ` Dan Williams
2018-07-05 13:20 ` zhangyi6
2018-07-04 15:30 ` [PATCH 3/3] kvm: add a function to check if page is from NVDIMM pmem Zhang Yi
2018-07-04 14:50 ` Dan Williams
2018-07-04 15:27 ` Paolo Bonzini [this message]
2018-07-04 15:25 ` Paolo Bonzini
2018-07-05 13:19 ` Zhang,Yi
2018-07-09 12:36 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe420914-212f-a18e-b6ec-f2b7a451c0d2@redhat.com \
--to=pbonzini@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=jglisse@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=rkrcmar@redhat.com \
--cc=yi.z.zhang@intel.com \
--cc=yi.z.zhang@linux.intel.com \
--cc=yu.c.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).