From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6D69C433E2 for ; Wed, 2 Sep 2020 03:46:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AFA80206EB for ; Wed, 2 Sep 2020 03:46:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AFA80206EB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5F6A86B0037; Tue, 1 Sep 2020 23:46:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 582206B0055; Tue, 1 Sep 2020 23:46:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 46F936B005A; Tue, 1 Sep 2020 23:46:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0042.hostedemail.com [216.40.44.42]) by kanga.kvack.org (Postfix) with ESMTP id 2CF416B0037 for ; Tue, 1 Sep 2020 23:46:44 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id E4C65181AEF15 for ; Wed, 2 Sep 2020 03:46:43 +0000 (UTC) X-FDA: 77216734686.23.bread24_06022d42709d Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin23.hostedemail.com (Postfix) with ESMTP id B588C37606 for ; Wed, 2 Sep 2020 03:46:43 +0000 (UTC) X-HE-Tag: bread24_06022d42709d X-Filterd-Recvd-Size: 3367 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Wed, 2 Sep 2020 03:46:43 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 71E69D6E; Tue, 1 Sep 2020 20:46:42 -0700 (PDT) Received: from [192.168.0.130] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6E0F23F66F; Tue, 1 Sep 2020 20:46:38 -0700 (PDT) From: Anshuman Khandual Subject: Re: [PATCH v3 08/13] mm/debug_vm_pgtable/thp: Use page table depost/withdraw with THP To: Christophe Leroy , "Aneesh Kumar K.V" , linux-mm@kvack.org, akpm@linux-foundation.org Cc: mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, linux-snps-arc@lists.infradead.org, x86@kernel.org, linux-arch@vger.kernel.org, Gerald Schaefer , Vineet Gupta , Mike Rapoport , Qian Cai References: <20200827080438.315345-1-aneesh.kumar@linux.ibm.com> <20200827080438.315345-9-aneesh.kumar@linux.ibm.com> <9beaaf93-b2dd-6d56-7737-9f022760f246@linux.ibm.com> <2fb4ac88-d417-2bdd-3c56-a816c356636a@linux.ibm.com> <5d25b02a-887a-432e-7ecd-cc5cbcea9b02@csgroup.eu> Message-ID: Date: Wed, 2 Sep 2020 09:15:58 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <5d25b02a-887a-432e-7ecd-cc5cbcea9b02@csgroup.eu> Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Rspamd-Queue-Id: B588C37606 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 09/01/2020 01:21 PM, Christophe Leroy wrote: >=20 >=20 > Le 01/09/2020 =C3=A0 09:40, Aneesh Kumar K.V a =C3=A9crit=C2=A0: >> On 9/1/20 12:20 PM, Christophe Leroy wrote: >>> >>> >>> Le 01/09/2020 =C3=A0 08:25, Aneesh Kumar K.V a =C3=A9crit=C2=A0: >>>> On 9/1/20 8:52 AM, Anshuman Khandual wrote: >>>>> >>>>> >>>>> >>>>> There is a checkpatch.pl warning here. >>>>> >>>>> WARNING: Possible unwrapped commit description (prefer a maximum 75= chars per line) >>>>> #7: >>>>> Architectures like ppc64 use deposited page table while updating th= e huge pte >>>>> >>>>> total: 0 errors, 1 warnings, 40 lines checked >>>>> >>>> >>>> I will ignore all these, because they are not really important IMHO. >>>> >>> >>> When doing a git log in a 80 chars terminal window, having wrapping l= ines is not really convenient. It should be easy to avoid it. >>> >> >> We have been ignoring that for a long time=C2=A0 isn't it? >> >> For example ppc64 checkpatch already had >> --max-line-length=3D90 >> >> >> There was also recent discussion whether 80 character limit is valid a= ny more. But I do keep it restricted to 80 character where ever it is eas= y/make sense. >> >=20 > Here we are not talking about the code, but the commit log. >=20 > As far as I know, the discussions about 80 character lines, 90 lines in= powerpc etc ... is for the code. >=20 > We still aim at keeping lines not longer than 75 chars in the commit lo= g. Agreed.