From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F184C63793 for ; Thu, 22 Jul 2021 16:19:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0D4ED6128A for ; Thu, 22 Jul 2021 16:19:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D4ED6128A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5D5536B0036; Thu, 22 Jul 2021 12:19:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 584BF6B005D; Thu, 22 Jul 2021 12:19:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 472BE6B006C; Thu, 22 Jul 2021 12:19:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2E4A36B0036 for ; Thu, 22 Jul 2021 12:19:22 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id CD0EE181AEF30 for ; Thu, 22 Jul 2021 16:19:21 +0000 (UTC) X-FDA: 78390733722.10.58A0D27 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf21.hostedemail.com (Postfix) with ESMTP id 2DEC3D00B7FA for ; Thu, 22 Jul 2021 16:19:21 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id A48C21FF27; Thu, 22 Jul 2021 16:19:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1626970759; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0q21Z/BbvVIO6X34zWJ2vfraU5Z7wl7yH5zp7SNGE60=; b=khUcQbVgut1X3AOW+eNuLktX4uW5tAa7ZtCVYE8UWArR2JBIb+jIV18fkHBC8euVev2eSQ Pajo8WjKvslGWaSmx+TroqDpbsu8Ktp2m9TKaMOBKcEm8wjz6jHz1+i/S0cs3kr7TFA5DB PcaRRHHO6xEZy2OhNIGMewnj2pQovqs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1626970759; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0q21Z/BbvVIO6X34zWJ2vfraU5Z7wl7yH5zp7SNGE60=; b=2UFj1itsYttSr22WgDTGgFzUx4QJTI67kHJ3BtFh9hwON+eLNpAhkaW24FyFjRmG2yflZf jBRm3IwSMiRFznCQ== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 7A887A7FF8; Thu, 22 Jul 2021 16:19:19 +0000 (UTC) Date: Thu, 22 Jul 2021 18:19:19 +0200 Message-ID: From: Takashi Iwai To: Dan Carpenter Cc: kbuild@lists.01.org, Takashi Iwai , lkp@intel.com, kbuild-all@lists.01.org, Linux Memory Management List Subject: Re: [linux-next:master 1517/2389] sound/pci/als4000.c:930 snd_card_als4000_probe() warn: 'pci' not released on lines: 852,872. In-Reply-To: <202107221413.qyIXVv60-lkp@intel.com> References: <202107221413.qyIXVv60-lkp@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=khUcQbVg; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=2UFj1its; spf=pass (imf21.hostedemail.com: domain of tiwai@suse.de designates 195.135.220.29 as permitted sender) smtp.mailfrom=tiwai@suse.de; dmarc=none X-Rspamd-Server: rspam05 X-Stat-Signature: zi9kfsigbq6mo4otwy8itoume7ucwikm X-Rspamd-Queue-Id: 2DEC3D00B7FA X-HE-Tag: 1626970761-354741 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 22 Jul 2021 11:28:17 +0200, Dan Carpenter wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: b1347210b01daa977ea980268927aa99198ceccc > commit: 0e175f665960c7be30aba47afbee4f2d121ea5fc [1517/2389] ALSA: als4000: Allocate resources with device-managed APIs > config: x86_64-randconfig-m001-20210722 (attached as .config) > compiler: gcc-10 (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > Reported-by: Dan Carpenter > > smatch warnings: > sound/pci/als4000.c:930 snd_card_als4000_probe() warn: 'pci' not released on lines: 852,872. > > vim +/pci +930 sound/pci/als4000.c > > e23e7a14362072 Bill Pemberton 2012-12-06 809 static int snd_card_als4000_probe(struct pci_dev *pci, > ^1da177e4c3f41 Linus Torvalds 2005-04-16 810 const struct pci_device_id *pci_id) > ^1da177e4c3f41 Linus Torvalds 2005-04-16 811 { > ^1da177e4c3f41 Linus Torvalds 2005-04-16 812 static int dev; > 17c39d9a59cbf4 Takashi Iwai 2005-11-17 813 struct snd_card *card; > 17c39d9a59cbf4 Takashi Iwai 2005-11-17 814 struct snd_card_als4000 *acard; > c0874449849175 Andreas Mohr 2008-08-20 815 unsigned long iobase; > 17c39d9a59cbf4 Takashi Iwai 2005-11-17 816 struct snd_sb *chip; > 17c39d9a59cbf4 Takashi Iwai 2005-11-17 817 struct snd_opl3 *opl3; > ^1da177e4c3f41 Linus Torvalds 2005-04-16 818 unsigned short word; > ^1da177e4c3f41 Linus Torvalds 2005-04-16 819 int err; > ^1da177e4c3f41 Linus Torvalds 2005-04-16 820 > ^1da177e4c3f41 Linus Torvalds 2005-04-16 821 if (dev >= SNDRV_CARDS) > ^1da177e4c3f41 Linus Torvalds 2005-04-16 822 return -ENODEV; > ^1da177e4c3f41 Linus Torvalds 2005-04-16 823 if (!enable[dev]) { > ^1da177e4c3f41 Linus Torvalds 2005-04-16 824 dev++; > ^1da177e4c3f41 Linus Torvalds 2005-04-16 825 return -ENOENT; > ^1da177e4c3f41 Linus Torvalds 2005-04-16 826 } > ^1da177e4c3f41 Linus Torvalds 2005-04-16 827 > ^1da177e4c3f41 Linus Torvalds 2005-04-16 828 /* enable PCI device */ > 0e175f665960c7 Takashi Iwai 2021-07-15 829 err = pcim_enable_device(pci); > 61ea06e8a88163 Takashi Iwai 2021-06-08 830 if (err < 0) > ^1da177e4c3f41 Linus Torvalds 2005-04-16 831 return err; > 61ea06e8a88163 Takashi Iwai 2021-06-08 832 > ^1da177e4c3f41 Linus Torvalds 2005-04-16 833 /* check, if we can restrict PCI DMA transfers to 24 bits */ > 669f65eaeb969e Takashi Iwai 2021-01-14 834 if (dma_set_mask_and_coherent(&pci->dev, DMA_BIT_MASK(24))) { > d85d878efb3047 Takashi Iwai 2014-02-25 835 dev_err(&pci->dev, "architecture does not support 24bit PCI busmaster DMA\n"); > ^1da177e4c3f41 Linus Torvalds 2005-04-16 836 return -ENXIO; > ^1da177e4c3f41 Linus Torvalds 2005-04-16 837 } > ^1da177e4c3f41 Linus Torvalds 2005-04-16 838 > 61ea06e8a88163 Takashi Iwai 2021-06-08 839 err = pci_request_regions(pci, "ALS4000"); > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > 0e175f665960c7 Takashi Iwai 2021-07-15 840 if (err < 0) > ^1da177e4c3f41 Linus Torvalds 2005-04-16 841 return err; > c0874449849175 Andreas Mohr 2008-08-20 842 iobase = pci_resource_start(pci, 0); > ^1da177e4c3f41 Linus Torvalds 2005-04-16 843 > ^1da177e4c3f41 Linus Torvalds 2005-04-16 844 pci_read_config_word(pci, PCI_COMMAND, &word); > ^1da177e4c3f41 Linus Torvalds 2005-04-16 845 pci_write_config_word(pci, PCI_COMMAND, word | PCI_COMMAND_IO); > ^1da177e4c3f41 Linus Torvalds 2005-04-16 846 pci_set_master(pci); > ^1da177e4c3f41 Linus Torvalds 2005-04-16 847 > 0e175f665960c7 Takashi Iwai 2021-07-15 848 err = snd_devm_card_new(&pci->dev, index[dev], id[dev], THIS_MODULE, > e58de7baf7de11 Takashi Iwai 2008-12-28 849 sizeof(*acard) /* private_data: acard */, > e58de7baf7de11 Takashi Iwai 2008-12-28 850 &card); > 0e175f665960c7 Takashi Iwai 2021-07-15 851 if (err < 0) > e58de7baf7de11 Takashi Iwai 2008-12-28 852 return err; > ^^^^^^^^^^ > Smatch complains because there is no error handling. Maybe the other > error paths use devm_ magic? Or more likely Smatch just isn't smart > enough... I believe those are false-positive. When the PCI device is already managed via pcim_enable_device(), all resources (even the ones without pcim_ or devm_) are freed automagically. thanks, Takashi