From: Greg Thelen <gthelen@google.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Shakeel Butt <shakeelb@google.com>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] memcg, oom: move out_of_memory back to the charge path
Date: Tue, 03 Jul 2018 16:29:00 -0700 [thread overview]
Message-ID: <xr93woubj3ur.fsf@gthelen.svl.corp.google.com> (raw)
In-Reply-To: <20180703071658.GC16767@dhcp22.suse.cz>
Michal Hocko <mhocko@kernel.org> wrote:
> On Tue 03-07-18 00:08:05, Greg Thelen wrote:
>> Michal Hocko <mhocko@kernel.org> wrote:
>>
>> > On Fri 29-06-18 11:59:04, Greg Thelen wrote:
>> >> Michal Hocko <mhocko@kernel.org> wrote:
>> >>
>> >> > On Thu 28-06-18 16:19:07, Greg Thelen wrote:
>> >> >> Michal Hocko <mhocko@kernel.org> wrote:
>> >> > [...]
>> >> >> > + if (mem_cgroup_out_of_memory(memcg, mask, order))
>> >> >> > + return OOM_SUCCESS;
>> >> >> > +
>> >> >> > + WARN(1,"Memory cgroup charge failed because of no reclaimable memory! "
>> >> >> > + "This looks like a misconfiguration or a kernel bug.");
>> >> >>
>> >> >> I'm not sure here if the warning should here or so strongly worded. It
>> >> >> seems like the current task could be oom reaped with MMF_OOM_SKIP and
>> >> >> thus mem_cgroup_out_of_memory() will return false. So there's nothing
>> >> >> alarming in that case.
>> >> >
>> >> > If the task is reaped then its charges should be released as well and
>> >> > that means that we should get below the limit. Sure there is some room
>> >> > for races but this should be still unlikely. Maybe I am just
>> >> > underestimating though.
>> >> >
>> >> > What would you suggest instead?
>> >>
>> >> I suggest checking MMF_OOM_SKIP or deleting the warning.
>> >
>> > So what do you do when you have MMF_OOM_SKIP task? Do not warn? Checking
>> > for all the tasks would be quite expensive and remembering that from the
>> > task selection not nice either. Why do you think it would help much?
>>
>> I assume we could just check current's MMF_OOM_SKIP - no need to check
>> all tasks.
>
> I still do not follow. If you are after a single task memcg then we
> should be ok. try_charge has a runaway for oom victims
> if (unlikely(tsk_is_oom_victim(current) ||
> fatal_signal_pending(current) ||
> current->flags & PF_EXITING))
> goto force;
>
> regardless of MMF_OOM_SKIP. So if there is a single process in the
> memcg, we kill it and the oom reaper kicks in and sets MMF_OOM_SKIP then
> we should bail out there. Or do I miss your intention?
For a single task memcg it seems that racing process cgroup migration
could trigger the new warning (I have attempted to reproduce this):
Processes A,B in memcg M1,M2. M1 is oom.
Process A[M1] Process B[M2]
M1 is oom
try_charge(M1)
Move A M1=>M2
mem_cgroup_oom()
mem_cgroup_out_of_memory()
out_of_memory()
select_bad_process()
sees nothing in M1
return 0
return 0
WARN()
Another variant might be possible, this time with global oom:
Processes A,B in memcg M1,M2. M1 is oom.
Process A[M1] Process B[M2]
try_charge()
trigger global oom
reaper sets A.MMF_OOM_SKIP
mem_cgroup_oom()
mem_cgroup_out_of_memory()
out_of_memory()
select_bad_process()
sees nothing in M1
return 0
return 0
WARN()
These seem unlikely, so I'm fine with taking a wait-and-see approach.
prev parent reply other threads:[~2018-07-03 23:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-28 15:11 [PATCH] memcg, oom: move out_of_memory back to the charge path Michal Hocko
2018-06-28 23:19 ` Greg Thelen
2018-06-29 7:21 ` Michal Hocko
2018-06-29 18:59 ` Greg Thelen
2018-07-02 10:03 ` Michal Hocko
2018-07-03 7:08 ` Greg Thelen
2018-07-03 7:16 ` Michal Hocko
2018-07-03 23:29 ` Greg Thelen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xr93woubj3ur.fsf@gthelen.svl.corp.google.com \
--to=gthelen@google.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=shakeelb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).