From: "Christian Löhle" <CLoehle@hyperstone.com>
To: Jesper Nilsson <jesper.nilsson@axis.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"marten.lindahl@axis.com" <marten.lindahl@axis.com>,
"jh80.chung@samsung.com" <jh80.chung@samsung.com>,
"ulf.hansson@linaro.org" <ulf.hansson@linaro.org>
Subject: Re: [PATCH] mmc: dw_mmc: avoid long timeout if register invalid
Date: Mon, 20 Sep 2021 09:34:34 +0000 [thread overview]
Message-ID: <0c002d216fa44df39fef87001079ca84@hyperstone.com> (raw)
In-Reply-To: <20210917134123.GL12780@axis.com>
From: Jesper Nilsson <jesper.nilsson@axis.com>
Sent: Friday, September 17, 2021 3:41 PM
To: Christian Löhle
Cc: linux-kernel@vger.kernel.org; linux-mmc@vger.kernel.org; marten.lindahl@axis.com; jh80.chung@samsung.com; ulf.hansson@linaro.org
Subject: Re: [PATCH] mmc: dw_mmc: avoid long timeout if register invalid
>One second could be to short, we have seen some cards take up
>to 10s on write operations. Although that was quite a few years ago.
>
>TMOUT is only used for reads if I understand correctly,
>so it should be ok anyways.
>
>/Jesper
Yes, apart from it only affecting reads, the calculated timeout is only that high if the register still holds the reset value.
I've only seen and would expect this for initialization 'read' commands, like ACMD13, or ACMD51.
I have chosen 1s to hit an expectation that I would consider normal, that a card is initialized in a couple of seconds after plugging in, or never.
Regards,
Christian=
Hyperstone GmbH | Line-Eid-Strasse 3 | 78467 Konstanz
Managing Directors: Dr. Jan Peter Berns.
Commercial register of local courts: Freiburg HRB381782
next prev parent reply other threads:[~2021-09-20 9:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210917075050epcas1p1962cd1c7c388b20ad17cb841461dae1b@epcas1p1.samsung.com>
2021-09-17 7:50 ` [PATCH] mmc: dw_mmc: avoid long timeout if register invalid Christian Löhle
2021-09-17 13:41 ` Jesper Nilsson
2021-09-20 9:34 ` Christian Löhle [this message]
2021-09-24 9:49 ` Jaehoon Chung
2021-09-29 6:53 ` Christian Löhle
2021-10-01 0:15 ` Jaehoon Chung
2021-09-30 6:53 ` [PATCHv2] " Christian Löhle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c002d216fa44df39fef87001079ca84@hyperstone.com \
--to=cloehle@hyperstone.com \
--cc=jesper.nilsson@axis.com \
--cc=jh80.chung@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=marten.lindahl@axis.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).