linux-mmc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: zhengbin <zhengbin13@huawei.com>
To: <ulf.hansson@linaro.org>, <linux-mmc@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Cc: <zhengbin13@huawei.com>
Subject: [PATCH 5/6] mmc: davinci: use true,false for bool variable
Date: Tue, 24 Dec 2019 15:32:14 +0800	[thread overview]
Message-ID: <1577172735-18869-6-git-send-email-zhengbin13@huawei.com> (raw)
In-Reply-To: <1577172735-18869-1-git-send-email-zhengbin13@huawei.com>

Fixes coccicheck warning:

drivers/mmc/host/davinci_mmc.c:480:1-13: WARNING: Assignment of 0/1 to bool variable
drivers/mmc/host/davinci_mmc.c:607:1-13: WARNING: Assignment of 0/1 to bool variable
drivers/mmc/host/davinci_mmc.c:1270:3-16: WARNING: Assignment of 0/1 to bool variable

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
 drivers/mmc/host/davinci_mmc.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c
index f01fecd..fe94907 100644
--- a/drivers/mmc/host/davinci_mmc.c
+++ b/drivers/mmc/host/davinci_mmc.c
@@ -477,7 +477,7 @@ static int mmc_davinci_start_dma_transfer(struct mmc_davinci_host *host,
 		}
 	}

-	host->do_dma = 1;
+	host->do_dma = true;
 	ret = mmc_davinci_send_dma_request(host, data);

 	return ret;
@@ -604,7 +604,7 @@ static void mmc_davinci_request(struct mmc_host *mmc, struct mmc_request *req)
 		return;
 	}

-	host->do_dma = 0;
+	host->do_dma = false;
 	mmc_davinci_prepare_data(host, req);
 	mmc_davinci_start_command(host, req->cmd);
 }
@@ -1267,7 +1267,7 @@ static int davinci_mmcsd_probe(struct platform_device *pdev)
 		if (ret == -EPROBE_DEFER)
 			goto dma_probe_defer;
 		else if (ret)
-			host->use_dma = 0;
+			host->use_dma = false;
 	}

 	mmc->caps |= MMC_CAP_WAIT_WHILE_BUSY;
--
2.7.4


  parent reply	other threads:[~2019-12-24  7:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-24  7:32 [PATCH 0/6] mmc: use true,false for bool variable zhengbin
2019-12-24  7:32 ` [PATCH 1/6] mmc: core: " zhengbin
2019-12-24  7:32 ` [PATCH 2/6] mmc: sdhci-tegra: " zhengbin
2019-12-24  7:32 ` [PATCH 3/6] mmc: sdhci-msm: " zhengbin
2019-12-24  7:32 ` [PATCH 4/6] mmc: omap_hsmmc: " zhengbin
2019-12-24  7:32 ` zhengbin [this message]
2019-12-24  7:32 ` [PATCH 6/6] mmc: owl: " zhengbin
2020-01-16 14:39 ` [PATCH 0/6] mmc: " Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1577172735-18869-6-git-send-email-zhengbin13@huawei.com \
    --to=zhengbin13@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).