From: Chun-Hung Wu <chun-hung.wu@mediatek.com>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: "Hulk Robot" <hulkci@huawei.com>,
"Chaotian Jing (井朝天)" <Chaotian.Jing@mediatek.com>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH -next] mmc: mediatek: make function msdc_cqe_disable() static
Date: Fri, 31 Jul 2020 14:54:23 +0800 [thread overview]
Message-ID: <1596178463.18010.1.camel@mtkswgap22> (raw)
In-Reply-To: <20200727171129.2945-1-weiyongjun1@huawei.com>
On Tue, 2020-07-28 at 01:11 +0800, Wei Yongjun wrote:
> The sparse tool complains as follows:
>
> drivers/mmc/host/mtk-sd.c:2269:6: warning:
> symbol 'msdc_cqe_disable' was not declared. Should it be static?
>
> This function is not used outside of mtk-sd.c, so this commit
> marks it static.
>
> Fixes: 88bd652b3c74 ("mmc: mediatek: command queue support")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/mmc/host/mtk-sd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index 734e403a142e..4e2583f69a63 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -2266,7 +2266,7 @@ static void msdc_cqe_enable(struct mmc_host *mmc)
> msdc_set_timeout(host, 1000000000ULL, 0);
> }
>
> -void msdc_cqe_disable(struct mmc_host *mmc, bool recovery)
> +static void msdc_cqe_disable(struct mmc_host *mmc, bool recovery)
> {
> struct msdc_host *host = mmc_priv(mmc);
>
>
Acked-by: Chun-Hung Wu <chun-hung.wu@mediatek.com>
next prev parent reply other threads:[~2020-07-31 6:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 17:11 [PATCH -next] mmc: mediatek: make function msdc_cqe_disable() static Wei Yongjun
2020-07-31 6:54 ` Chun-Hung Wu [this message]
2020-08-05 6:29 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1596178463.18010.1.camel@mtkswgap22 \
--to=chun-hung.wu@mediatek.com \
--cc=Chaotian.Jing@mediatek.com \
--cc=hulkci@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=ulf.hansson@linaro.org \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).