From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Ohad Ben-Cohen <ohad@wizery.com>,
linux-mmc@vger.kernel.org, Magnus Damm <damm@opensource.se>,
Simon Horman <horms@verge.net.au>,
Linux PM mailing list <linux-pm@lists.linux-foundation.org>
Subject: Re: [PATCH/RFC] MMC: remove unbalanced pm_runtime_suspend()
Date: Fri, 22 Apr 2011 00:06:09 +0200 [thread overview]
Message-ID: <201104220006.09982.rjw@sisk.pl> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1104211741090.1939-100000@iolanthe.rowland.org>
On Thursday, April 21, 2011, Alan Stern wrote:
> On Thu, 21 Apr 2011, Rafael J. Wysocki wrote:
>
> > > > If we choose this approach, then yes, we should provide a suitable API, but
> > > > I'm still thinking it would be simpler to move the pm_runtime_put_sync() before driver_sysfs_remove() and make the rule as I said previously. :-)
> > >
> > > The problem is synchronization. At what point is the driver supposed
> > > to stop queuing runtime PM requests? It would have to be sometime
> > > before the pm_runtime_barrier() call. How is the driver supposed to
> > > know when that point is reached? The remove routine isn't called until
> > > later.
> >
> > Executing the driver's callback is not an ideal solution either, because
> > it simply may be insufficient (it may be necessary to execute the power
> > domain and/or subsystem callbacks, pretty much what rpm_suspend() does,
> > but without taking the usage counter into consideration).
>
> That's why I suggested a new API. It could do the right callbacks.
>
> > Moreover, if we want the driver's ->remove() to do the cleanup anyway,
> > there's not much point in doing any cleanup before in the core. Also,
> > there's a little problem that the bus ->remove() is called before the
> > driver's ->remove(), so it may not be entirely possible to power down
> > the device when the driver's ->remove() is called already.
>
> Actually, the bus->remove() callback (if there is one) is responsible
> for invoking the driver's callback.
Ah, sorry, I misread the code in __device_release_driver() (too little
coffee perhaps).
> The subsystem should be smart enough to handle runtime PM requests while
> the driver's remove callback is running.
If we make such a rule, we may as well remove all of the runtime PM
calls from __device_release_driver().
> > I think the current code is better than any of the alternatives considered
> > so far.
>
> Then you think Guennadi should leave his patch as it is, including the
> "reversed" put/get?
This, or we need to remove the runtime PM calls from __device_release_driver().
I'm a bit worried about the driver_sysfs_remove() and the bus notifier that
in theory may affect the runtime PM callbacks potentially executed before
->remove() is called.
Rafael
next prev parent reply other threads:[~2011-04-21 22:05 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-19 10:46 [PATCH/RFC] MMC: remove unbalanced pm_runtime_suspend() Guennadi Liakhovetski
2011-04-19 12:44 ` Ohad Ben-Cohen
2011-04-19 13:23 ` Guennadi Liakhovetski
2011-04-19 14:16 ` Ohad Ben-Cohen
2011-04-19 14:26 ` Alan Stern
2011-04-19 22:59 ` Guennadi Liakhovetski
2011-04-20 14:22 ` Alan Stern
2011-04-20 14:50 ` Guennadi Liakhovetski
2011-04-20 15:12 ` Alan Stern
2011-04-20 20:06 ` Rafael J. Wysocki
2011-04-20 21:16 ` Alan Stern
2011-04-20 21:44 ` Rafael J. Wysocki
2011-04-21 13:58 ` Alan Stern
2011-04-21 18:00 ` Rafael J. Wysocki
2011-04-21 18:36 ` Alan Stern
2011-04-21 20:05 ` Rafael J. Wysocki
2011-04-21 21:48 ` Alan Stern
2011-04-21 22:06 ` Rafael J. Wysocki [this message]
2011-04-22 15:20 ` Alan Stern
2011-04-22 20:22 ` Rafael J. Wysocki
2011-04-22 20:25 ` Rafael J. Wysocki
2011-04-22 21:20 ` Alan Stern
2011-04-22 22:11 ` Rafael J. Wysocki
2011-04-25 10:29 ` [linux-pm] " Rafael J. Wysocki
2011-04-26 10:44 ` Guennadi Liakhovetski
2011-04-26 11:51 ` Rafael J. Wysocki
2011-04-28 22:12 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201104220006.09982.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=damm@opensource.se \
--cc=g.liakhovetski@gmx.de \
--cc=horms@verge.net.au \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=ohad@wizery.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).