From: Chuhong Yuan <hslester96@gmail.com>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
Chuhong Yuan <hslester96@gmail.com>
Subject: [PATCH] mmc: renesas_sdhi: add checks for pinctrl_lookup_state
Date: Fri, 18 Oct 2019 21:13:38 +0800 [thread overview]
Message-ID: <20191018131338.11713-1-hslester96@gmail.com> (raw)
renesas_sdhi_probe misses checks for pinctrl_lookup_state and may miss
failures.
Add checks for them to fix the problem.
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
drivers/mmc/host/renesas_sdhi_core.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c
index d4ada5cca2d1..dc5ad6632df3 100644
--- a/drivers/mmc/host/renesas_sdhi_core.c
+++ b/drivers/mmc/host/renesas_sdhi_core.c
@@ -694,8 +694,13 @@ int renesas_sdhi_probe(struct platform_device *pdev,
if (!IS_ERR(priv->pinctrl)) {
priv->pins_default = pinctrl_lookup_state(priv->pinctrl,
PINCTRL_STATE_DEFAULT);
+ if (IS_ERR(priv->pins_default))
+ return PTR_ERR(priv->pins_default);
+
priv->pins_uhs = pinctrl_lookup_state(priv->pinctrl,
"state_uhs");
+ if (IS_ERR(priv->pins_uhs))
+ return PTR_ERR(priv->pins_uhs);
}
host = tmio_mmc_host_alloc(pdev, mmc_data);
--
2.20.1
next reply other threads:[~2019-10-18 13:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 13:13 Chuhong Yuan [this message]
2019-10-21 14:32 ` [PATCH] mmc: renesas_sdhi: add checks for pinctrl_lookup_state Ulf Hansson
2019-10-21 20:10 ` Wolfram Sang
2019-10-23 15:33 ` Wolfram Sang
2019-10-30 15:09 ` Ulf Hansson
2019-10-31 22:12 ` Wolfram Sang
2019-11-07 8:30 ` Geert Uytterhoeven
2019-11-24 3:20 ` Chuhong Yuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191018131338.11713-1-hslester96@gmail.com \
--to=hslester96@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).