linux-mmc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: "Michael ." <keltoiboy@gmail.com>
Cc: Dominik Brodowski <linux@dominikbrodowski.net>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	Trevor Jacobs <trevor_jacobs@aol.com>,
	Kris Cleveland <tridentperfusion@yahoo.com>,
	Jeff <bluerocksaddles@willitsonline.com>,
	Morgan Klym <moklym@gmail.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Philip Langdale <philipl@overt.org>,
	Pierre Ossman <pierre@ossman.eu>,
	Maxim Levitsky <maximlevitsky@gmail.com>,
	linux-mmc@vger.kernel.org
Subject: Re: PCI device function not being enumerated [Was: PCMCIA not working on Panasonic Toughbook CF-29]
Date: Tue, 29 Oct 2019 12:02:50 -0500	[thread overview]
Message-ID: <20191029170250.GA43972@google.com> (raw)
In-Reply-To: <CAFjuqNihuEb4_5Lny5X7vA258c0ogemVg8pQ5Y_ANgOsqhSXhg@mail.gmail.com>

[+cc Ulf, Philip, Pierre, Maxim, linux-mmc; see [1] for beginning of
thread, [2] for problem report and the patch Michael tested]

On Tue, Oct 29, 2019 at 07:58:27PM +1100, Michael . wrote:
> Bjorn and Dominik.
> I am happy to let you know the patch did the trick, it compiled well
> on 5.4-rc4 and my friends in the CC list have tested the modified
> kernel and confirmed that both slots are now working as they should.
> As a group of dedicated Toughbook users and Linux users please accept
> our thanks your efforts and assistance is greatly appreciated.
> 
> Now that we know this patch works what kernel do you think it will be
> released in? Will it make 5.4 or will it be put into 5.5 development
> for further testing?

That patch was not intended to be a fix; it was just to test my guess
that the quirk might be related.

Removing the quirk solved the problem *you're* seeing, but the quirk
was added in the first place to solve some other problem, and if we
simply remove the quirk, we may reintroduce the original problem.

So we have to look at the history and figure out some way to solve
both problems.  I cc'd some people who might have insight.  Here are
some commits that look relevant:

  5ae70296c85f ("mmc: Disabler for Ricoh MMC controller")
  03cd8f7ebe0c ("ricoh_mmc: port from driver to pci quirk")


[1] https://lore.kernel.org/r/CAFjuqNi+knSb9WVQOahCVFyxsiqoGgwoM7Z1aqDBebNzp_-jYw@mail.gmail.com/
[2] https://lore.kernel.org/r/20191021160952.GA229204@google.com/

       reply	other threads:[~2019-10-29 17:02 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAFjuqNihuEb4_5Lny5X7vA258c0ogemVg8pQ5Y_ANgOsqhSXhg@mail.gmail.com>
2019-10-29 17:02 ` Bjorn Helgaas [this message]
2020-02-22 16:56   ` PCI device function not being enumerated [Was: PCMCIA not working on Panasonic Toughbook CF-29] Bjorn Helgaas
2020-02-22 18:14     ` Michael .
2020-02-25 15:03     ` Ulf Hansson
2020-02-25 19:15       ` Bjorn Helgaas
2020-02-25 23:46       ` bluerocksaddles
2020-02-26  1:13       ` Arvind Sankar
2020-02-26  1:50         ` Michael .
2020-02-26  3:12           ` Trevor Jacobs
2020-02-26  4:51             ` Arvind Sankar
2020-02-26  5:20               ` Philip Langdale
2020-02-26  6:10                 ` Michael .
2020-02-26 19:46                   ` bluerocksaddles
2020-07-28  1:50                     ` Michael .
2020-08-02  5:58                       ` Michael .

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191029170250.GA43972@google.com \
    --to=helgaas@kernel.org \
    --cc=bluerocksaddles@willitsonline.com \
    --cc=keltoiboy@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux@dominikbrodowski.net \
    --cc=maximlevitsky@gmail.com \
    --cc=moklym@gmail.com \
    --cc=philipl@overt.org \
    --cc=pierre@ossman.eu \
    --cc=trevor_jacobs@aol.com \
    --cc=tridentperfusion@yahoo.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).