From: Ulf Hansson <ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Ulf Hansson <ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Adrian Hunter
<adrian.hunter-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Douglas Anderson
<dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
Matthias Kaehlcke <mka-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Cc: Kalle Valo <kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>,
Wen Gong <wgong-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Erik Stromdahl
<erik.stromdahl-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Eyal Reizer <eyalreizer-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH v3 0/3] mmc: Fixup HW reset for SDIO cards
Date: Tue, 12 Nov 2019 13:40:18 +0100 [thread overview]
Message-ID: <20191112124021.8718-1-ulf.hansson@linaro.org> (raw)
Changes in v3:
- Added tags.
- Drop unnecessary initialization of variable.
- Rename adapter->is_adapter_up to adapter->is_up in the mwifiex driver.
Changes in v2:
- Add adaptations to the mwifiex driver.
- Keep existing synchronous reset behaviour if the SDIO card has a
single func driver.
The cover-letter from v2:
It has turned out that it's not a good idea to try to power cycle and to
re-initialize the SDIO card, as currently done through mmc_hw_reset(). This
because there may be multiple SDIO funcs attached to the same SDIO card and
some of the others that didn't execute the call to mmc_hw_reset(), may then
simply experience an undefined behaviour.
The following patches in this series attempts to address this problem, by
reworking the mmc_hw_reset() behaviour for SDIO and by adopting the Marvel
mwifiex driver to these changes.
Note that, I don't have the HW at hand so the the code has only compile tested.
Test on HW is greatly appreciated!
Ulf Hansson (3):
mwifiex: Re-work support for SDIO HW reset
mmc: core: Drop check for mmc_card_is_removable() in mmc_rescan()
mmc: core: Re-work HW reset for SDIO cards
drivers/mmc/core/core.c | 12 +++-----
drivers/mmc/core/core.h | 2 ++
drivers/mmc/core/sdio.c | 28 ++++++++++++++++-
drivers/mmc/core/sdio_bus.c | 9 +++++-
drivers/net/wireless/marvell/mwifiex/main.c | 5 +++-
drivers/net/wireless/marvell/mwifiex/main.h | 1 +
drivers/net/wireless/marvell/mwifiex/sdio.c | 33 ++++++++++++++-------
include/linux/mmc/card.h | 1 +
8 files changed, 69 insertions(+), 22 deletions(-)
--
2.17.1
next reply other threads:[~2019-11-12 12:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 12:40 Ulf Hansson [this message]
[not found] ` <20191112124021.8718-1-ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2019-11-12 12:40 ` [PATCH v3 1/3] mwifiex: Re-work support for SDIO HW reset Ulf Hansson
[not found] ` <20191112124021.8718-2-ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2019-11-14 15:13 ` Kalle Valo
[not found] ` <87zhgybids.fsf-R2sXevljlEEH1xkMTmwrwqxOck334EZe@public.gmane.org>
2019-11-14 15:20 ` Ulf Hansson
2019-11-12 12:40 ` [PATCH v3 2/3] mmc: core: Drop check for mmc_card_is_removable() in mmc_rescan() Ulf Hansson
2019-11-12 12:40 ` [PATCH v3 3/3] mmc: core: Re-work HW reset for SDIO cards Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191112124021.8718-1-ulf.hansson@linaro.org \
--to=ulf.hansson-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
--cc=adrian.hunter-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=erik.stromdahl-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=eyalreizer-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mka-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
--cc=wgong-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).