From: Christoph Hellwig <hch@infradead.org>
To: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
Cc: Jun Nie <jun.nie@linaro.org>,
Christoph Hellwig <hch@infradead.org>,
"ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"adrian.hunter@intel.com" <adrian.hunter@intel.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
linux-block@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH 4/4] mmc: sdhci: Add DMA memory boundary workaround
Date: Tue, 3 Dec 2019 01:18:24 -0800 [thread overview]
Message-ID: <20191203091824.GA4685@infradead.org> (raw)
In-Reply-To: <20191203165123.4e6f9e28@xhacker.debian>
On Tue, Dec 03, 2019 at 09:05:23AM +0000, Jisheng Zhang wrote:
> > >
> > > eg. drivers/mmc/host/sdhci-of-dwcmshc.c
> > >
> > Thanks for the suggestion! Christoph's suggestion can prevent the the issue
> > from the block layer, thus the code can be shared across all
>
> To be honest, I did consider similar solution from block layer, I.E set
> the seg_boundary_mask, when submitting the workaround last year, but per
> my understanding, SDHCI limitation is the physical DMA addr can't span one
> specific boundary,
As in exactly one boundary and not an alignment? Where the one
boundary is not a power of two and thus can't be expressed?
> so setting seg_boundary_mask w/ blk_queue_segment_boundary
> can't work. I'm not sure I understand blk_queue_segment_boundary() properly.
> May Christoph help to clarify?
>
> From another side, drivers/ata/libata-sff.c also workaround the 64K phy DMA
> boundary limitation itself rather than from block layer.
As far as I can tell that workaround should use the segment boundary
setting as well.
next prev parent reply other threads:[~2019-12-03 9:18 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-02 14:41 [PATCH 0/4] mmc: Add sdhci workaround stability enhencement Jun Nie
2019-12-02 14:41 ` [PATCH 1/4] mmc: sdhci: Add delay after power off Jun Nie
2019-12-03 7:26 ` Adrian Hunter
2019-12-02 14:41 ` [PATCH 2/4] mmc: sdhci: dt: Add DMA boundary and HS400 properties Jun Nie
2019-12-13 23:01 ` Rob Herring
2019-12-17 14:56 ` Jun Nie
2019-12-02 14:41 ` [PATCH 3/4] mmc: sdhci: Set ctrl_hs400 value in dts Jun Nie
2019-12-03 7:52 ` Adrian Hunter
2019-12-02 14:41 ` [PATCH 4/4] mmc: sdhci: Add DMA memory boundary workaround Jun Nie
2019-12-02 17:52 ` Christoph Hellwig
2019-12-03 3:29 ` Jun Nie
2019-12-03 7:36 ` Christoph Hellwig
2019-12-04 6:00 ` Jun Nie
2019-12-04 7:14 ` Jisheng Zhang
2019-12-10 9:36 ` Ulf Hansson
2019-12-03 2:47 ` Jisheng Zhang
2019-12-03 3:33 ` Jun Nie
2019-12-03 9:05 ` Jisheng Zhang
2019-12-03 9:18 ` Christoph Hellwig [this message]
2019-12-03 9:49 ` Jisheng Zhang
2019-12-03 13:06 ` Christoph Hellwig
2019-12-04 7:11 ` Jisheng Zhang
2019-12-03 9:49 ` Jisheng Zhang
2019-12-03 13:04 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191203091824.GA4685@infradead.org \
--to=hch@infradead.org \
--cc=Jisheng.Zhang@synaptics.com \
--cc=adrian.hunter@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=jun.nie@linaro.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).