* [PATCH] mmc: sdhci-msm: Mark sdhci_msm_cqe_disable static
@ 2020-02-06 16:21 Stephen Boyd
2020-02-06 17:34 ` Doug Anderson
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Stephen Boyd @ 2020-02-06 16:21 UTC (permalink / raw)
To: Ulf Hansson
Cc: linux-kernel, linux-mmc, Ritesh Harjani,
Veerabhadrarao Badiganti, Adrian Hunter, Douglas Anderson
This function is not exported and only used in this file. Mark it
static.
Cc: Ritesh Harjani <riteshh@codeaurora.org>
Cc: Veerabhadrarao Badiganti <vbadigan@codeaurora.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
---
drivers/mmc/host/sdhci-msm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
index c3a160c18047..3955fa5db43c 100644
--- a/drivers/mmc/host/sdhci-msm.c
+++ b/drivers/mmc/host/sdhci-msm.c
@@ -1590,7 +1590,7 @@ static u32 sdhci_msm_cqe_irq(struct sdhci_host *host, u32 intmask)
return 0;
}
-void sdhci_msm_cqe_disable(struct mmc_host *mmc, bool recovery)
+static void sdhci_msm_cqe_disable(struct mmc_host *mmc, bool recovery)
{
struct sdhci_host *host = mmc_priv(mmc);
unsigned long flags;
--
Sent by a computer, using git, on the internet
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] mmc: sdhci-msm: Mark sdhci_msm_cqe_disable static
2020-02-06 16:21 [PATCH] mmc: sdhci-msm: Mark sdhci_msm_cqe_disable static Stephen Boyd
@ 2020-02-06 17:34 ` Doug Anderson
2020-02-07 7:22 ` Adrian Hunter
2020-02-13 13:56 ` Ulf Hansson
2 siblings, 0 replies; 4+ messages in thread
From: Doug Anderson @ 2020-02-06 17:34 UTC (permalink / raw)
To: Stephen Boyd
Cc: Ulf Hansson, LKML, Linux MMC List, Ritesh Harjani,
Veerabhadrarao Badiganti, Adrian Hunter
Hi,
On Thu, Feb 6, 2020 at 8:21 AM Stephen Boyd <swboyd@chromium.org> wrote:
>
> This function is not exported and only used in this file. Mark it
> static.
>
> Cc: Ritesh Harjani <riteshh@codeaurora.org>
> Cc: Veerabhadrarao Badiganti <vbadigan@codeaurora.org>
> Cc: Adrian Hunter <adrian.hunter@intel.com>
> Cc: Douglas Anderson <dianders@chromium.org>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> ---
> drivers/mmc/host/sdhci-msm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Fixes: 87a8df0dce6a ("mmc: sdhci-msm: Add CQHCI support for sdhci-msm")
Reviewed-by: Douglas Anderson <dianders@chromium.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mmc: sdhci-msm: Mark sdhci_msm_cqe_disable static
2020-02-06 16:21 [PATCH] mmc: sdhci-msm: Mark sdhci_msm_cqe_disable static Stephen Boyd
2020-02-06 17:34 ` Doug Anderson
@ 2020-02-07 7:22 ` Adrian Hunter
2020-02-13 13:56 ` Ulf Hansson
2 siblings, 0 replies; 4+ messages in thread
From: Adrian Hunter @ 2020-02-07 7:22 UTC (permalink / raw)
To: Stephen Boyd, Ulf Hansson
Cc: linux-kernel, linux-mmc, Ritesh Harjani,
Veerabhadrarao Badiganti, Douglas Anderson
On 6/02/20 6:21 pm, Stephen Boyd wrote:
> This function is not exported and only used in this file. Mark it
> static.
>
> Cc: Ritesh Harjani <riteshh@codeaurora.org>
> Cc: Veerabhadrarao Badiganti <vbadigan@codeaurora.org>
> Cc: Adrian Hunter <adrian.hunter@intel.com>
> Cc: Douglas Anderson <dianders@chromium.org>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/host/sdhci-msm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
> index c3a160c18047..3955fa5db43c 100644
> --- a/drivers/mmc/host/sdhci-msm.c
> +++ b/drivers/mmc/host/sdhci-msm.c
> @@ -1590,7 +1590,7 @@ static u32 sdhci_msm_cqe_irq(struct sdhci_host *host, u32 intmask)
> return 0;
> }
>
> -void sdhci_msm_cqe_disable(struct mmc_host *mmc, bool recovery)
> +static void sdhci_msm_cqe_disable(struct mmc_host *mmc, bool recovery)
> {
> struct sdhci_host *host = mmc_priv(mmc);
> unsigned long flags;
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mmc: sdhci-msm: Mark sdhci_msm_cqe_disable static
2020-02-06 16:21 [PATCH] mmc: sdhci-msm: Mark sdhci_msm_cqe_disable static Stephen Boyd
2020-02-06 17:34 ` Doug Anderson
2020-02-07 7:22 ` Adrian Hunter
@ 2020-02-13 13:56 ` Ulf Hansson
2 siblings, 0 replies; 4+ messages in thread
From: Ulf Hansson @ 2020-02-13 13:56 UTC (permalink / raw)
To: Stephen Boyd
Cc: Linux Kernel Mailing List, linux-mmc, Ritesh Harjani,
Veerabhadrarao Badiganti, Adrian Hunter, Douglas Anderson
On Thu, 6 Feb 2020 at 17:21, Stephen Boyd <swboyd@chromium.org> wrote:
>
> This function is not exported and only used in this file. Mark it
> static.
>
> Cc: Ritesh Harjani <riteshh@codeaurora.org>
> Cc: Veerabhadrarao Badiganti <vbadigan@codeaurora.org>
> Cc: Adrian Hunter <adrian.hunter@intel.com>
> Cc: Douglas Anderson <dianders@chromium.org>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Applied for fixes, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci-msm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
> index c3a160c18047..3955fa5db43c 100644
> --- a/drivers/mmc/host/sdhci-msm.c
> +++ b/drivers/mmc/host/sdhci-msm.c
> @@ -1590,7 +1590,7 @@ static u32 sdhci_msm_cqe_irq(struct sdhci_host *host, u32 intmask)
> return 0;
> }
>
> -void sdhci_msm_cqe_disable(struct mmc_host *mmc, bool recovery)
> +static void sdhci_msm_cqe_disable(struct mmc_host *mmc, bool recovery)
> {
> struct sdhci_host *host = mmc_priv(mmc);
> unsigned long flags;
> --
> Sent by a computer, using git, on the internet
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-02-13 13:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-06 16:21 [PATCH] mmc: sdhci-msm: Mark sdhci_msm_cqe_disable static Stephen Boyd
2020-02-06 17:34 ` Doug Anderson
2020-02-07 7:22 ` Adrian Hunter
2020-02-13 13:56 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).