Linux-mmc Archive on lore.kernel.org
 help / color / Atom feed
* [RFC PATCH 0/3] Introduce pm_ptr() / pm_sleep_ptr()
@ 2020-02-11 16:03 Paul Cercueil
  2020-02-11 16:03 ` [RFC PATCH 1/3] PM: introduce pm_ptr() and pm_sleep_ptr() Paul Cercueil
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Paul Cercueil @ 2020-02-11 16:03 UTC (permalink / raw)
  To: Rafael J . Wysocki, Len Brown, Pavel Machek
  Cc: Ulf Hansson, od, linux-pm, linux-mmc, linux-kernel, Paul Cercueil

Hi,

I've seen many times things like:

#ifdef CONFIG_PM_SLEEP
static SIMPLE_DEV_PM_OPS(foo_pm_ops, foo_suspend, foo_resume);
#define FOO_PM_OPS (&foo_pm_ops)
#else
#define FOO_PM_OPS NULL
#endif
static struct platform_driver foo_driver = {
		.driver.pm = FOO_PM_OPS,
};

And always wondered why there was no of-match-ptr-like macro to make
things cleaner.

So this RFC adds two macros, pm_ptr() and pm_sleep_ptr(), which resolve
to their argument when CONFIG_PM or CONFIG_PM_SLEEP (respectively) are
enabled, or NULL otherwise.

Patch 3/3 is an example of what it would look like when used in a
driver.

Comments welcome.

Cheers,
-Paul


Paul Cercueil (3):
  PM: introduce pm_ptr() and pm_sleep_ptr()
  PM: Make *_DEV_PM_OPS macros use __maybe_unused
  mmc: jz4740: Use pm_sleep_ptr() macro

 drivers/mmc/host/jz4740_mmc.c | 12 +++---------
 include/linux/pm.h            | 16 ++++++++++++++--
 2 files changed, 17 insertions(+), 11 deletions(-)

-- 
2.25.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [RFC PATCH 1/3] PM: introduce pm_ptr() and pm_sleep_ptr()
  2020-02-11 16:03 [RFC PATCH 0/3] Introduce pm_ptr() / pm_sleep_ptr() Paul Cercueil
@ 2020-02-11 16:03 ` Paul Cercueil
  2020-02-11 16:03 ` [RFC PATCH 2/3] PM: Make *_DEV_PM_OPS macros use __maybe_unused Paul Cercueil
  2020-02-11 16:03 ` [RFC PATCH 3/3] mmc: jz4740: Use pm_sleep_ptr() macro Paul Cercueil
  2 siblings, 0 replies; 4+ messages in thread
From: Paul Cercueil @ 2020-02-11 16:03 UTC (permalink / raw)
  To: Rafael J . Wysocki, Len Brown, Pavel Machek
  Cc: Ulf Hansson, od, linux-pm, linux-mmc, linux-kernel, Paul Cercueil

These macros are analogous to the infamous of_match_ptr(). If CONFIG_PM
or CONFIG_PM_SLEEP are enabled (respectively), these macros will resolve
to their argument, otherwise to NULL.

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
 include/linux/pm.h | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/include/linux/pm.h b/include/linux/pm.h
index e057d1fa2469..1e183d78a1ae 100644
--- a/include/linux/pm.h
+++ b/include/linux/pm.h
@@ -374,6 +374,18 @@ const struct dev_pm_ops name = { \
 	SET_RUNTIME_PM_OPS(suspend_fn, resume_fn, idle_fn) \
 }
 
+#ifdef CONFIG_PM
+#define pm_ptr(_ptr) (_ptr)
+#else
+#define pm_ptr(_ptr) NULL
+#endif
+
+#ifdef CONFIG_PM_SLEEP
+#define pm_sleep_ptr(_ptr) (_ptr)
+#else
+#define pm_sleep_ptr(_ptr) NULL
+#endif
+
 /*
  * PM_EVENT_ messages
  *
-- 
2.25.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [RFC PATCH 2/3] PM: Make *_DEV_PM_OPS macros use __maybe_unused
  2020-02-11 16:03 [RFC PATCH 0/3] Introduce pm_ptr() / pm_sleep_ptr() Paul Cercueil
  2020-02-11 16:03 ` [RFC PATCH 1/3] PM: introduce pm_ptr() and pm_sleep_ptr() Paul Cercueil
@ 2020-02-11 16:03 ` Paul Cercueil
  2020-02-11 16:03 ` [RFC PATCH 3/3] mmc: jz4740: Use pm_sleep_ptr() macro Paul Cercueil
  2 siblings, 0 replies; 4+ messages in thread
From: Paul Cercueil @ 2020-02-11 16:03 UTC (permalink / raw)
  To: Rafael J . Wysocki, Len Brown, Pavel Machek
  Cc: Ulf Hansson, od, linux-pm, linux-mmc, linux-kernel, Paul Cercueil

This way, when the dev_pm_ops instance is not referenced anywhere, it
will simply be dropped by the compiler without a warning.

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
 include/linux/pm.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/pm.h b/include/linux/pm.h
index 1e183d78a1ae..892e4fd198c0 100644
--- a/include/linux/pm.h
+++ b/include/linux/pm.h
@@ -351,7 +351,7 @@ struct dev_pm_ops {
  * to RAM and hibernation.
  */
 #define SIMPLE_DEV_PM_OPS(name, suspend_fn, resume_fn) \
-const struct dev_pm_ops name = { \
+const struct dev_pm_ops __maybe_unused name = { \
 	SET_SYSTEM_SLEEP_PM_OPS(suspend_fn, resume_fn) \
 }
 
@@ -369,7 +369,7 @@ const struct dev_pm_ops name = { \
  * .runtime_resume(), respectively (and analogously for hibernation).
  */
 #define UNIVERSAL_DEV_PM_OPS(name, suspend_fn, resume_fn, idle_fn) \
-const struct dev_pm_ops name = { \
+const struct dev_pm_ops __maybe_unused name = { \
 	SET_SYSTEM_SLEEP_PM_OPS(suspend_fn, resume_fn) \
 	SET_RUNTIME_PM_OPS(suspend_fn, resume_fn, idle_fn) \
 }
-- 
2.25.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [RFC PATCH 3/3] mmc: jz4740: Use pm_sleep_ptr() macro
  2020-02-11 16:03 [RFC PATCH 0/3] Introduce pm_ptr() / pm_sleep_ptr() Paul Cercueil
  2020-02-11 16:03 ` [RFC PATCH 1/3] PM: introduce pm_ptr() and pm_sleep_ptr() Paul Cercueil
  2020-02-11 16:03 ` [RFC PATCH 2/3] PM: Make *_DEV_PM_OPS macros use __maybe_unused Paul Cercueil
@ 2020-02-11 16:03 ` Paul Cercueil
  2 siblings, 0 replies; 4+ messages in thread
From: Paul Cercueil @ 2020-02-11 16:03 UTC (permalink / raw)
  To: Rafael J . Wysocki, Len Brown, Pavel Machek
  Cc: Ulf Hansson, od, linux-pm, linux-mmc, linux-kernel, Paul Cercueil

Use the newly introduced pm_sleep_ptr() macro to simplify the code.

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
 drivers/mmc/host/jz4740_mmc.c | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/drivers/mmc/host/jz4740_mmc.c b/drivers/mmc/host/jz4740_mmc.c
index fbae87d1f017..09554f9831de 100644
--- a/drivers/mmc/host/jz4740_mmc.c
+++ b/drivers/mmc/host/jz4740_mmc.c
@@ -1099,24 +1099,18 @@ static int jz4740_mmc_remove(struct platform_device *pdev)
 	return 0;
 }
 
-#ifdef CONFIG_PM_SLEEP
-
-static int jz4740_mmc_suspend(struct device *dev)
+static int __maybe_unused jz4740_mmc_suspend(struct device *dev)
 {
 	return pinctrl_pm_select_sleep_state(dev);
 }
 
-static int jz4740_mmc_resume(struct device *dev)
+static int __maybe_unused jz4740_mmc_resume(struct device *dev)
 {
 	return pinctrl_select_default_state(dev);
 }
 
 static SIMPLE_DEV_PM_OPS(jz4740_mmc_pm_ops, jz4740_mmc_suspend,
 	jz4740_mmc_resume);
-#define JZ4740_MMC_PM_OPS (&jz4740_mmc_pm_ops)
-#else
-#define JZ4740_MMC_PM_OPS NULL
-#endif
 
 static struct platform_driver jz4740_mmc_driver = {
 	.probe = jz4740_mmc_probe,
@@ -1124,7 +1118,7 @@ static struct platform_driver jz4740_mmc_driver = {
 	.driver = {
 		.name = "jz4740-mmc",
 		.of_match_table = of_match_ptr(jz4740_mmc_of_match),
-		.pm = JZ4740_MMC_PM_OPS,
+		.pm = pm_sleep_ptr(&jz4740_mmc_pm_ops),
 	},
 };
 
-- 
2.25.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-11 16:03 [RFC PATCH 0/3] Introduce pm_ptr() / pm_sleep_ptr() Paul Cercueil
2020-02-11 16:03 ` [RFC PATCH 1/3] PM: introduce pm_ptr() and pm_sleep_ptr() Paul Cercueil
2020-02-11 16:03 ` [RFC PATCH 2/3] PM: Make *_DEV_PM_OPS macros use __maybe_unused Paul Cercueil
2020-02-11 16:03 ` [RFC PATCH 3/3] mmc: jz4740: Use pm_sleep_ptr() macro Paul Cercueil

Linux-mmc Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mmc/0 linux-mmc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mmc linux-mmc/ https://lore.kernel.org/linux-mmc \
		linux-mmc@vger.kernel.org
	public-inbox-index linux-mmc

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-mmc


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git