From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FAKE_REPLY_C,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83A86C35671 for ; Sat, 22 Feb 2020 16:56:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 57A5420702 for ; Sat, 22 Feb 2020 16:56:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582390580; bh=EqB7+yBPCDMububIdS7k5fp4EdyyVlPZ9ggfTM342n8=; h=Date:From:To:Cc:Subject:In-Reply-To:List-ID:From; b=elNxwAz6wo0q7hcEf2ExXxiRK9inOR++KTdz1lEMfmUAxURZJLuHkqDkISBXnRSNN aSz9ZbWZ4nKTum7ecXloqY45ktzPZVwpQtGLvDHnhARGJU8HIOmnWjUVSl1Heo3Rpl kiMNRYPbFf76a+P33LavjV7AQDu8qpG169FFJSSQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726688AbgBVQ4U (ORCPT ); Sat, 22 Feb 2020 11:56:20 -0500 Received: from mail.kernel.org ([198.145.29.99]:55838 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726550AbgBVQ4T (ORCPT ); Sat, 22 Feb 2020 11:56:19 -0500 Received: from localhost (mobile-166-175-186-165.mycingular.net [166.175.186.165]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EA4AD206E2; Sat, 22 Feb 2020 16:56:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582390579; bh=EqB7+yBPCDMububIdS7k5fp4EdyyVlPZ9ggfTM342n8=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=dejzJCvRLDOSIJumWybT17cGCKL56Q1yehS6ddprC22dRI0vns3hJP+I4XR2B4L6b qXDejnVi83mJeDbZ8Br3ESpqRrGBEFx7RxurchKs/bzkVwc/aA3PN1kfOTfWWjV9J7 31vjmTXAn74TuKmjaMLsBAA2a+Xkl2ntE2YUWik8= Date: Sat, 22 Feb 2020 10:56:17 -0600 From: Bjorn Helgaas To: "Michael ." Cc: Dominik Brodowski , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Trevor Jacobs , Kris Cleveland , Jeff , Morgan Klym , Ulf Hansson , Philip Langdale , Pierre Ossman , Maxim Levitsky , linux-mmc@vger.kernel.org Subject: Re: PCI device function not being enumerated [Was: PCMCIA not working on Panasonic Toughbook CF-29] Message-ID: <20200222165617.GA207731@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191029170250.GA43972@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org On Tue, Oct 29, 2019 at 12:02:50PM -0500, Bjorn Helgaas wrote: > [+cc Ulf, Philip, Pierre, Maxim, linux-mmc; see [1] for beginning of > thread, [2] for problem report and the patch Michael tested] > > On Tue, Oct 29, 2019 at 07:58:27PM +1100, Michael . wrote: > > Bjorn and Dominik. > > I am happy to let you know the patch did the trick, it compiled well > > on 5.4-rc4 and my friends in the CC list have tested the modified > > kernel and confirmed that both slots are now working as they should. > > As a group of dedicated Toughbook users and Linux users please accept > > our thanks your efforts and assistance is greatly appreciated. > > > > Now that we know this patch works what kernel do you think it will be > > released in? Will it make 5.4 or will it be put into 5.5 development > > for further testing? > > That patch was not intended to be a fix; it was just to test my guess > that the quirk might be related. > > Removing the quirk solved the problem *you're* seeing, but the quirk > was added in the first place to solve some other problem, and if we > simply remove the quirk, we may reintroduce the original problem. > > So we have to look at the history and figure out some way to solve > both problems. I cc'd some people who might have insight. Here are > some commits that look relevant: > > 5ae70296c85f ("mmc: Disabler for Ricoh MMC controller") > 03cd8f7ebe0c ("ricoh_mmc: port from driver to pci quirk") > > > [1] https://lore.kernel.org/r/CAFjuqNi+knSb9WVQOahCVFyxsiqoGgwoM7Z1aqDBebNzp_-jYw@mail.gmail.com/ > [2] https://lore.kernel.org/r/20191021160952.GA229204@google.com/ I guess this problem is still unfixed? I hate the fact that we broke something that used to work. Maybe we need some sort of DMI check in ricoh_mmc_fixup_rl5c476() so we skip it for Toughbooks? Or maybe we limit the quirk to the machines where it was originally needed? Bjorn