* Re: [PATCH] mmc: cqhci: Fix a print format for the task descriptor
2020-07-15 7:33 [PATCH] mmc: cqhci: Fix a print format for the task descriptor Ben Chuang
@ 2020-07-15 7:52 ` Joe Perches
2020-08-05 6:35 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Joe Perches @ 2020-07-15 7:52 UTC (permalink / raw)
To: Ben Chuang, adrian.hunter, riteshh, asutoshd, ulf.hansson
Cc: linux-mmc, linux-kernel, kernelnewbies
On Wed, 2020-07-15 at 15:33 +0800, Ben Chuang wrote:
> The format string of the task descriptor should be "%016llx".
There are a lot of these:
$ git grep -P -n '\b0x\d+%'
arch/m68k/include/asm/mmu_context.h:166: pr_info("ksp load failed: mm=0x%p ksp=0x08%lx\n", mm, mmuar);
arch/powerpc/kvm/book3s_xive.c:1706: pr_devel(" val=0x016%llx (server=0x%x, guest_prio=%d)\n",
drivers/atm/eni.c:590: EVENT("bad PDU (descr=0x08%lx,length=%ld)\n",descr,
drivers/dma/ppc4xx/adma.c:4366: "uses 0x1%02x polynomial.\n", reg);
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c:3023: DRM_INFO("Using rlc debug ucode. mmRLC_GPM_GENERAL_6 ==0x08%x / fw_ver == %i \n",
drivers/gpu/drm/i915/intel_uncore.c:495: drm_dbg(&uncore->i915->drm, "GTFIFODBG = 0x08%x\n", fifodbg);
drivers/media/usb/gspca/ov519.c:2760: gspca_err(gspca_dev, "Unknown sensor: 0x76%02x\n",
drivers/mmc/host/cqhci.c:425: pr_debug("%s: cqhci: tag %d task descriptor 0x016%llx\n",
drivers/mmc/host/s3cmci.c:192: "#%u%s op:%i arg:0x%08x flags:0x08%x retries:%u",
drivers/net/can/flexcan.c:1517: "gpr %s req_gpr=0x02%x req_bit=%u ack_gpr=0x02%x ack_bit=%u\n",
drivers/net/ethernet/intel/i40e/i40e_debugfs.c:444: " info: cmd_reserved[] = 0x%02x 0x%02x 0x%02x 0x0%02x 0x%02x 0x%02x 0x%02x 0x0%02x\n",
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:1397: "i = %d buffer_info->dma = 0x08%llx buffer_info->length = 0x%x\n",
drivers/net/wireless/intel/iwlwifi/pcie/trans.c:2298: "Queue %d is %sactive on fifo %d and stuck for %u ms. SW [%d, %d] HW [%d, %d] FH TRB=0x0%x\n",
drivers/net/wireless/intersil/hostap/hostap_hw.c:779: "(%d,0x04%x,%d); reg=0x%04x\n",
drivers/net/wireless/realtek/rtw88/rtw8822c.c:429: rtw_dbg(rtwdev, RTW_DBG_RFK, "[DACK] ADCK 0x%08x=0x08%x\n",
drivers/scsi/mpt3sas/mpt3sas_scsih.c:6161: ioc_err(ioc, "device is not present handle(0x04%x)!!!\n",
drivers/scsi/mpt3sas/mpt3sas_scsih.c:6923: ioc_err(ioc, "device is not present handle(0x04%x)!!!\n",
drivers/staging/rtl8723bs/hal/hal_com_phycfg.c:328: DBG_871X("Invalid RegAddr 0x3%x in PHY_GetRateSectionIndexOfTxPowerByRate()", RegAddr);
drivers/usb/serial/spcp8x5.c:225: dev_dbg(&port->dev, "0xc0:0x22:0:6 %d - 0x02%x\n", ret, *buf);
drivers/video/fbdev/s1d13xxxfb.c:500: dbg_blit("(copyarea) bpp=%d=0x0%d, mem_offset1=%d, mem_offset2=%d\n", bpp, (bpp >> 1),
sound/pci/es1938.c:306: "snd_es1938_write_cmd timeout (0x02%x/0x02%x)\n", cmd, v);
sound/pci/es1938.c:319: dev_err(chip->card->dev, "get_byte timeout: status 0x02%x\n", v);
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mmc: cqhci: Fix a print format for the task descriptor
2020-07-15 7:33 [PATCH] mmc: cqhci: Fix a print format for the task descriptor Ben Chuang
2020-07-15 7:52 ` Joe Perches
@ 2020-08-05 6:35 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2020-08-05 6:35 UTC (permalink / raw)
To: Ben Chuang
Cc: Adrian Hunter, Harjani Ritesh, Asutosh Das, linux-mmc,
Linux Kernel Mailing List
On Wed, 15 Jul 2020 at 09:34, Ben Chuang <benchuanggli@gmail.com> wrote:
>
> The format string of the task descriptor should be "%016llx".
>
> Signed-off-by: Ben Chuang <benchuanggli@gmail.com>
Applied for next (a while ago), thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/cqhci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/cqhci.c b/drivers/mmc/host/cqhci.c
> index 75934f3c117e..280d64d0b809 100644
> --- a/drivers/mmc/host/cqhci.c
> +++ b/drivers/mmc/host/cqhci.c
> @@ -422,7 +422,7 @@ static void cqhci_prep_task_desc(struct mmc_request *mrq,
> CQHCI_BLK_COUNT(mrq->data->blocks) |
> CQHCI_BLK_ADDR((u64)mrq->data->blk_addr);
>
> - pr_debug("%s: cqhci: tag %d task descriptor 0x016%llx\n",
> + pr_debug("%s: cqhci: tag %d task descriptor 0x%016llx\n",
> mmc_hostname(mrq->host), mrq->tag, (unsigned long long)*data);
> }
>
> --
> 2.27.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread