[PATCH v1 0/2] mmc: sdhci-of-arasan: Fixed kernel-doc format warning

[PATCH v1 0/2] mmc: sdhci-of-arasan: Fixed kernel-doc format warning

[Muhammad Husaini Zulkifli]

Hi,

This patch series are to fix the kernel-doc format warning when using kernel-doc
script tool and to change code style of mapping the syscon field for readability
and consistency.

Kindly help to review this patch set.

Thanks.

Muhammad Husaini Zulkifli (2):
  mmc: sdhci-of-arasan: Fixed kernel-doc format warning
  mmc: sdhci-of-arasan: Change code style of mapping the syscon field

 drivers/mmc/host/sdhci-of-arasan.c | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

--
2.17.1

[PATCH v1 1/2] mmc: sdhci-of-arasan: Fixed kernel-doc format warning

[Muhammad Husaini Zulkifli]

Commit 36c6aadaae86 ("mmc: sdhci-of-arasan: Add support for Intel Keem Bay")
introduces syscon map sdhci_arasan_update_support64b(). Unfortunately,
kernel-doc format script tool has not been run before and causing warning
on the documentation style.

Below is the output when running the kernel-doc script tool:
drivers/mmc/host/sdhci-of-arasan.c:1388: warning: contents before sections

Let's fix this by using standard conventions kernel-doc format.

Fixes: 36c6aadaae86 ("mmc: sdhci-of-arasan: Add support for Intel Keem Bay")
Signed-off-by: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
Acked-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
---
 drivers/mmc/host/sdhci-of-arasan.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
index 4f3774bcda94..643313687b5e 100644
--- a/drivers/mmc/host/sdhci-of-arasan.c
+++ b/drivers/mmc/host/sdhci-of-arasan.c
@@ -1380,17 +1380,16 @@ static void sdhci_arasan_unregister_sdclk(struct device *dev)

 /**
  * sdhci_arasan_update_support64b - Set SUPPORT_64B (64-bit System Bus Support)
+ * @host:		The sdhci_host
+ * @value:		The value to write
  *
  * This should be set based on the System Address Bus.
  * 0: the Core supports only 32-bit System Address Bus.
  * 1: the Core supports 64-bit System Address Bus.
  *
- * NOTES:
- * - For Keem Bay, it is required to clear this bit. Its default value is 1'b1.
- *   Keem Bay does not support 64-bit access.
- *
- * @host:		The sdhci_host
- * @value:		The value to write
+ * NOTE:
+ * For Keem Bay, it is required to clear this bit. Its default value is 1'b1.
+ * Keem Bay does not support 64-bit access.
  */
 static void sdhci_arasan_update_support64b(struct sdhci_host *host, u32 value)
 {
--
2.17.1

[PATCH v1 2/2] mmc: sdhci-of-arasan: Change code style of mapping the syscon field

[Muhammad Husaini Zulkifli]

Change code style of mapping the syscon in sdhci_arasan_update_support64b()
for readability and consistency.

Signed-off-by: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
Acked-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
---
 drivers/mmc/host/sdhci-of-arasan.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
index 643313687b5e..8a406b62c6ad 100644
--- a/drivers/mmc/host/sdhci-of-arasan.c
+++ b/drivers/mmc/host/sdhci-of-arasan.c
@@ -1395,10 +1395,10 @@ static void sdhci_arasan_update_support64b(struct sdhci_host *host, u32 value)
 {
 	struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
 	struct sdhci_arasan_data *sdhci_arasan = sdhci_pltfm_priv(pltfm_host);
-	const struct sdhci_arasan_soc_ctl_map *soc_ctl_map =
-		sdhci_arasan->soc_ctl_map;
+	const struct sdhci_arasan_soc_ctl_map *soc_ctl_map;
 
 	/* Having a map is optional */
+	soc_ctl_map = sdhci_arasan->soc_ctl_map;
 	if (!soc_ctl_map)
 		return;
 
-- 
2.17.1

Re: [PATCH v1 0/2] mmc: sdhci-of-arasan: Fixed kernel-doc format warning

[Ulf Hansson]

On Mon, 11 Jan 2021 at 16:51, Muhammad Husaini Zulkifli
<muhammad.husaini.zulkifli@intel.com> wrote:
>
> Hi,
>
> This patch series are to fix the kernel-doc format warning when using kernel-doc
> script tool and to change code style of mapping the syscon field for readability
> and consistency.
>
> Kindly help to review this patch set.
>
> Thanks.
>
> Muhammad Husaini Zulkifli (2):
>   mmc: sdhci-of-arasan: Fixed kernel-doc format warning
>   mmc: sdhci-of-arasan: Change code style of mapping the syscon field
>
>  drivers/mmc/host/sdhci-of-arasan.c | 15 +++++++--------
>  1 file changed, 7 insertions(+), 8 deletions(-)
>
> --
> 2.17.1
>

Applied for next, thanks!

Kind regards
Uffe

RE: [PATCH v1 0/2] mmc: sdhci-of-arasan: Fixed kernel-doc format warning

[Zulkifli, Muhammad Husaini]

Hi Ulf,

Thanks. 

>-----Original Message-----
>From: Ulf Hansson <ulf.hansson@linaro.org>
>Sent: Wednesday, January 13, 2021 7:26 PM
>To: Zulkifli, Muhammad Husaini <muhammad.husaini.zulkifli@intel.com>
>Cc: Michal Simek <michal.simek@xilinx.com>; linux-mmc@vger.kernel.org;
>Linux ARM <linux-arm-kernel@lists.infradead.org>; Linux Kernel Mailing List
><linux-kernel@vger.kernel.org>; Hunter, Adrian <adrian.hunter@intel.com>;
>Shevchenko, Andriy <andriy.shevchenko@intel.com>
>Subject: Re: [PATCH v1 0/2] mmc: sdhci-of-arasan: Fixed kernel-doc format
>warning
>
>On Mon, 11 Jan 2021 at 16:51, Muhammad Husaini Zulkifli
><muhammad.husaini.zulkifli@intel.com> wrote:
>>
>> Hi,
>>
>> This patch series are to fix the kernel-doc format warning when using
>> kernel-doc script tool and to change code style of mapping the syscon
>> field for readability and consistency.
>>
>> Kindly help to review this patch set.
>>
>> Thanks.
>>
>> Muhammad Husaini Zulkifli (2):
>>   mmc: sdhci-of-arasan: Fixed kernel-doc format warning
>>   mmc: sdhci-of-arasan: Change code style of mapping the syscon field
>>
>>  drivers/mmc/host/sdhci-of-arasan.c | 15 +++++++--------
>>  1 file changed, 7 insertions(+), 8 deletions(-)
>>
>> --
>> 2.17.1
>>
>
>Applied for next, thanks!
>
>Kind regards
>Uffe