From: Kees Cook <keescook@chromium.org>
To: Bhaskara Budiredla <bbudiredla@marvell.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
Sunil Kovvuri Goutham <sgoutham@marvell.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [EXT] Re: [PATCH v4 1/2] mmc: Support kmsg dumper based on pstore/blk
Date: Tue, 19 Jan 2021 11:30:41 -0800 [thread overview]
Message-ID: <202101191130.4A8EC5F9@keescook> (raw)
In-Reply-To: <CY4PR1801MB207022E70C53D0DA87EB3F22DEA31@CY4PR1801MB2070.namprd18.prod.outlook.com>
On Tue, Jan 19, 2021 at 04:11:31AM +0000, Bhaskara Budiredla wrote:
> Do you see any issues to ACK this if the mmc pstore
> registration is through register_pstore_blk()?
> As Uffe said, eMMC would need to go through
> psblk_generic_blk_read()/write() instead of
> mmcpstore_read()/write().
I would be fine with that; yes.
--
Kees Cook
next prev parent reply other threads:[~2021-01-19 19:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-23 14:40 [PATCH v4 0/2] mmc: support crash logging to MMC block devices Bhaskara Budiredla
2020-12-23 14:40 ` [PATCH v4 1/2] mmc: Support kmsg dumper based on pstore/blk Bhaskara Budiredla
2021-01-13 11:46 ` Ulf Hansson
2021-01-19 4:11 ` [EXT] " Bhaskara Budiredla
2021-01-19 19:30 ` Kees Cook [this message]
2021-01-20 12:14 ` Bhaskara Budiredla
2020-12-23 14:40 ` [PATCH v4 2/2] mmc: cavium: Add MMC polling method to support kmsg panic/oops write Bhaskara Budiredla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202101191130.4A8EC5F9@keescook \
--to=keescook@chromium.org \
--cc=bbudiredla@marvell.com \
--cc=ccross@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=sgoutham@marvell.com \
--cc=tony.luck@intel.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).