From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: "linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>
Subject: Re: [PATCH 2/2] mmc: renesas_sdhi: do hard reset if possible
Date: Mon, 15 Mar 2021 13:31:17 +0100 [thread overview]
Message-ID: <20210315123117.GC1182@ninjato> (raw)
In-Reply-To: <TY2PR01MB3692BAF4BB03CDFE3D904B98D86F9@TY2PR01MB3692.jpnprd01.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 1194 bytes --]
> Adding the function itself seems OK. However, I checked the code, and then
> adding hard reset into renesas_sdhi_reset() seems to break the following:
> -----
> commit 5b0739d76227fd5a3f02f014385bfa9c86e0404b
> Author: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Date: Thu Aug 20 15:25:37 2020 +0200
>
> mmc: tmio: don't reset whole IP core when tuning fails
>
> SDHI needs to reset the SCC only, not the whole IP core. So, if tuning
> fails, don't handle specifics in the generic TMIO core, but in the
> specific drivers. For SDHI, we need to move around the reset routine a
> bit. It is not modified.
> ------
>
> So, perhaps, we have to fix renesas_sdhi_execute_tuning() somehow before
> adding hard reset. But, what do you think?
Thanks for the pointer, Shimoda-san! It seems it gets messy again, so
time for getting clearer, I think. I will introduce a reset_scc funtion
again which is seperate from reset_sdhi, so we have a clear distinction.
Then, I will call reset_scc from renesas_sdhi_execute_tuning() and the
rest stays with reset_sdhi. I have a prototype patch which I will test
some more and hopefully send out later.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-03-15 12:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 9:23 [PATCH 0/2] mmc: renesas_sdhi: reset via reset controller Wolfram Sang
2021-03-09 9:23 ` [PATCH 1/2] mmc: tmio: abort DMA before reset Wolfram Sang
2021-03-10 10:34 ` Niklas Söderlund
2021-03-09 9:23 ` [PATCH 2/2] mmc: renesas_sdhi: do hard reset if possible Wolfram Sang
2021-03-10 12:45 ` Yoshihiro Shimoda
2021-03-11 13:17 ` Wolfram Sang
2021-03-12 12:05 ` Yoshihiro Shimoda
2021-03-15 12:31 ` Wolfram Sang [this message]
2021-03-15 23:59 ` Yoshihiro Shimoda
2021-03-09 9:28 ` [PATCH 0/2] mmc: renesas_sdhi: reset via reset controller Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210315123117.GC1182@ninjato \
--to=wsa+renesas@sang-engineering.com \
--cc=geert@linux-m68k.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).