From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32B6AC4332F for ; Fri, 17 Sep 2021 15:55:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 18A86610A4 for ; Fri, 17 Sep 2021 15:55:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242615AbhIQP40 (ORCPT ); Fri, 17 Sep 2021 11:56:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241825AbhIQP4Z (ORCPT ); Fri, 17 Sep 2021 11:56:25 -0400 Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4E7FC0613C1 for ; Fri, 17 Sep 2021 08:55:02 -0700 (PDT) Received: by mail-pf1-x42b.google.com with SMTP id 203so1733297pfy.13 for ; Fri, 17 Sep 2021 08:55:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=7pWvqKzdntB6FDdZ0hZ4GT80npsWFPbvESQwerjuH7c=; b=B3Ko3FNcR8yQrEwob+w7bt573zp1X4ohJ08HUXI4vOccN13vmeEZRJy7u1W7Q54xr8 HhI8RkjNH2d+Cz2e5TWpFu3Bb3LwAr2c7nuuH+V7bfBMcjWeeqH+7+fQp2UTRCrCdjRC 5IQKckA+007Alwmvjn9C0LLsaM9NmcumDf4e4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7pWvqKzdntB6FDdZ0hZ4GT80npsWFPbvESQwerjuH7c=; b=MTveil99xNDKhqca7BRBYHshuhp73cEPxvA5GgWxH+0163M5d1VGC/0/BooVb7gXRj tcQOzHoB8MFZhNWF8b2Yvhpm6v0kt46fbZh/oxicmQVFLQYtuSTSyPQKoMw5wDjwsx84 ujzM3F3QZh/P5XSFhIo2QIMmJZe+XUanhXa9gvWP4HYOhS8RCgvXIJDQ/nNT35D2ltDK EYwMiRzVFATlQ4o8VINWY+uu9mz9RPzmOH46cIbG3wm/aG8ncWHInYprQ8xveRB/8nkp a7Gha1QWH4AYbPrP3ovaifgIePJBnOYhwaR0lgx7EigH3gOxRAJmW+7C9kmOzYclLV1v G4Ew== X-Gm-Message-State: AOAM531JHhv6IZ1ojtir68MT3vX8VJpsrhDxNz61T/Yhb1/s8q4ruHVK WkdS4LxqIJt8FDw0kN7ej19q3Q== X-Google-Smtp-Source: ABdhPJyijox7cLdCfudrGttWdWXm5KL45WjcPcwDiO9owHX94eR86zSJh15NIUpL854odfpVFX5EAg== X-Received: by 2002:a05:6a00:1596:b0:40d:bda5:372c with SMTP id u22-20020a056a00159600b0040dbda5372cmr11307531pfk.37.1631894102272; Fri, 17 Sep 2021 08:55:02 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id c15sm6607931pfl.181.2021.09.17.08.55.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Sep 2021 08:55:01 -0700 (PDT) Date: Fri, 17 Sep 2021 08:55:00 -0700 From: Kees Cook To: Brendan Higgins Cc: shuah@kernel.org, davidgow@google.com, arnd@arndb.de, rafael@kernel.org, jic23@kernel.org, lars@metafoo.de, ulf.hansson@linaro.org, andreas.noever@gmail.com, michael.jamet@intel.com, mika.westerberg@linux.intel.com, YehezkelShB@gmail.com, masahiroy@kernel.org, michal.lkml@markovi.net, ndesaulniers@google.com, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, gregkh@linuxfoundation.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, linux-usb@vger.kernel.org, linux-hardening@vger.kernel.org, linux-kbuild@vger.kernel.org Subject: Re: [PATCH v1 4/6] thunderbolt: build kunit tests without structleak plugin Message-ID: <202109170854.A99408F1@keescook> References: <20210917061104.2680133-1-brendanhiggins@google.com> <20210917061104.2680133-5-brendanhiggins@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210917061104.2680133-5-brendanhiggins@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org On Thu, Sep 16, 2021 at 11:11:02PM -0700, Brendan Higgins wrote: > The structleak plugin causes the stack frame size to grow immensely when > used with KUnit: > > drivers/thunderbolt/test.c:1529:1: error: the frame size of 1176 bytes is larger than 1024 bytes [-Werror=frame-larger-than=] > > Turn it off in this file. > > Linus already split up tests in this file, so this change *should* be > redundant now. > > Co-developed-by: Arnd Bergmann > Signed-off-by: Arnd Bergmann Reviewed-by: Kees Cook -- Kees Cook