From: Conor Dooley <conor@kernel.org>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Abel Vesa <abelvesa@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
kernel@pengutronix.de, Peng Fan <peng.fan@nxp.com>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Michael Trimarchi <michael@amarulasolutions.com>,
Mark Brown <broonie@kernel.org>,
Dario Binacchi <dario.binacchi@amarulasolutions.com>,
Anson Huang <Anson.Huang@nxp.com>, Marek Vasut <marex@denx.de>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-input@vger.kernel.org, linux-mmc@vger.kernel.org
Subject: Re: [PATCH v1 3/7] dt-bindings: timer: gpt: Support 3rd clock for i.MX6DL
Date: Thu, 1 Jun 2023 19:22:25 +0100 [thread overview]
Message-ID: <20230601-rising-motocross-19f7164e2933@spud> (raw)
In-Reply-To: <20230601101451.357662-4-o.rempel@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 1992 bytes --]
On Thu, Jun 01, 2023 at 12:14:47PM +0200, Oleksij Rempel wrote:
> Add support for a 3rd clock, 'osc_per', for i.MX6DL to the 'fsl,imxgpt'
> binding to resolve the following dtbs_check warning:
> imx6dl-alti6p.dtb: timer@2098000: clocks: [[2, 119], [2, 120], [2, 237]]
> is too long
> From schema: Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
> imx6dl-alti6p.dtb: timer@2098000: clock-names: ['ipg', 'per', 'osc_per']
> is too long
> From schema: Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
> .../devicetree/bindings/timer/fsl,imxgpt.yaml | 22 ++++++++++++++-----
> 1 file changed, 16 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
> index adf617b8f353..21ff51c3f38f 100644
> --- a/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
> +++ b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
> @@ -46,14 +46,24 @@ properties:
> maxItems: 1
>
> clocks:
> - items:
> - - description: SoC GPT ipg clock
> - - description: SoC GPT per clock
> + anyOf:
> + - items:
> + - description: SoC GPT ipg clock
> + - description: SoC GPT per clock
> + - items:
> + - description: SoC GPT ipg clock
> + - description: SoC GPT per clock
> + - description: SoC GPT osc_per clock
>
> clock-names:
> - items:
> - - const: ipg
> - - const: per
> + anyOf:
> + - items:
> + - const: ipg
> + - const: per
> + - items:
> + - const: ipg
> + - const: per
> + - const: osc_per
Hmm, should we not do per-compatible enforcement here so that the extra
clock is only used on the appropriate platforms?
Cheers,
Conor.
>
> required:
> - compatible
> --
> 2.39.2
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-06-01 18:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 10:14 [PATCH v1 0/7] Add support for various features to i.MX6 bindings Oleksij Rempel
2023-06-01 10:14 ` [PATCH v1 1/7] dt-bindings: mmc: fsl-imx-esdhc: Add imx6ul support Oleksij Rempel
2023-06-01 18:18 ` Conor Dooley
2023-06-01 18:19 ` Conor Dooley
2023-06-02 8:27 ` Krzysztof Kozlowski
2023-06-01 10:14 ` [PATCH v1 2/7] dt-bindings: timer: gpt: Add i.MX6UL support Oleksij Rempel
2023-06-01 18:20 ` Conor Dooley
2023-06-01 10:14 ` [PATCH v1 3/7] dt-bindings: timer: gpt: Support 3rd clock for i.MX6DL Oleksij Rempel
2023-06-01 18:22 ` Conor Dooley [this message]
2023-06-14 19:03 ` Rob Herring
2023-06-01 10:14 ` [PATCH v1 4/7] dt-bindings: crypto: fsl-dcp: Add i.MX6SL, i.MX6SLL, and i.MX6ULL support Oleksij Rempel
2023-06-01 18:26 ` Conor Dooley
2023-06-01 10:14 ` [PATCH v1 5/7] dt-bindings: clock: imx6ul: Support optional enet*_ref_pad clocks Oleksij Rempel
2023-06-14 19:13 ` Rob Herring
2023-06-01 10:14 ` [PATCH v1 6/7] dt-bindings: clock: imx6q: Allow single optional clock and add enet_ref_pad Oleksij Rempel
2023-06-14 19:18 ` Rob Herring
2023-06-01 10:14 ` [PATCH v1 7/7] dt-bindings: input: touchscreen: edt-ft5x06: Add 'threshold' property Oleksij Rempel
2023-06-14 19:21 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230601-rising-motocross-19f7164e2933@spud \
--to=conor@kernel.org \
--cc=Anson.Huang@nxp.com \
--cc=abelvesa@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=dario.binacchi@amarulasolutions.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=festevam@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=marex@denx.de \
--cc=michael@amarulasolutions.com \
--cc=mturquette@baylibre.com \
--cc=o.rempel@pengutronix.de \
--cc=peng.fan@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=tglx@linutronix.de \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).