Linux-mmc Archive on lore.kernel.org
 help / color / Atom feed
From: Michal Simek <michal.simek@xilinx.com>
To: Manish Narani <manish.narani@xilinx.com>,
	michal.simek@xilinx.com, adrian.hunter@intel.com,
	ulf.hansson@linaro.org, jolly.shah@xilinx.com,
	rajan.vaja@xilinx.com, nava.manne@xilinx.com,
	tejas.patel@xilinx.com
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org
Subject: Re: [PATCH 2/4] firmware: xilinx: Add DLL reset support
Date: Tue, 4 Feb 2020 12:39:44 +0100
Message-ID: <63fa8a5a-d87f-8fdd-3e6d-d95a14f562f2@xilinx.com> (raw)
In-Reply-To: <1579602095-30060-3-git-send-email-manish.narani@xilinx.com>

On 21. 01. 20 11:21, Manish Narani wrote:
> SD DLL resets are required for some of the operations on ZynqMP platform.
> Add DLL reset support in ZynqMP firmware driver for SD DLL reset.
> 
> Signed-off-by: Manish Narani <manish.narani@xilinx.com>
> ---
>  drivers/firmware/xilinx/zynqmp.c     | 1 +
>  include/linux/firmware/xlnx-zynqmp.h | 9 ++++++++-
>  2 files changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c
> index 89eb198cee5e..165ec0f1e10a 100644
> --- a/drivers/firmware/xilinx/zynqmp.c
> +++ b/drivers/firmware/xilinx/zynqmp.c
> @@ -469,6 +469,7 @@ static int zynqmp_pm_clock_getparent(u32 clock_id, u32 *parent_id)
>  static inline int zynqmp_is_valid_ioctl(u32 ioctl_id)
>  {
>  	switch (ioctl_id) {
> +	case IOCTL_SD_DLL_RESET:
>  	case IOCTL_SET_SD_TAPDELAY:
>  	case IOCTL_SET_PLL_FRAC_MODE:
>  	case IOCTL_GET_PLL_FRAC_MODE:
> diff --git a/include/linux/firmware/xlnx-zynqmp.h b/include/linux/firmware/xlnx-zynqmp.h
> index e41ad9e37136..01a6d972b8a8 100644
> --- a/include/linux/firmware/xlnx-zynqmp.h
> +++ b/include/linux/firmware/xlnx-zynqmp.h
> @@ -92,7 +92,8 @@ enum pm_ret_status {
>  };
>  
>  enum pm_ioctl_id {
> -	IOCTL_SET_SD_TAPDELAY = 7,
> +	IOCTL_SD_DLL_RESET = 6,
> +	IOCTL_SET_SD_TAPDELAY,
>  	IOCTL_SET_PLL_FRAC_MODE,
>  	IOCTL_GET_PLL_FRAC_MODE,
>  	IOCTL_SET_PLL_FRAC_DATA,
> @@ -262,6 +263,12 @@ enum tap_delay_type {
>  	PM_TAPDELAY_OUTPUT,
>  };
>  
> +enum dll_reset_type {
> +	PM_DLL_RESET_ASSERT,
> +	PM_DLL_RESET_RELEASE,
> +	PM_DLL_RESET_PULSE,
> +};
> +
>  /**
>   * struct zynqmp_pm_query_data - PM query data
>   * @qid:	query ID
> 

Acked-by: Michal Simek <michal.simek@xilinx.com>

Thanks,
Michal

  reply index

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-21 10:21 [PATCH 0/4] Enhancements and Bug Fixes in ZynqMP SDHCI Manish Narani
2020-01-21 10:21 ` [PATCH 1/4] firmware: xilinx: Add ZynqMP Tap Delay setup ioctl to the valid list Manish Narani
2020-02-04 11:39   ` Michal Simek
2020-01-21 10:21 ` [PATCH 2/4] firmware: xilinx: Add DLL reset support Manish Narani
2020-02-04 11:39   ` Michal Simek [this message]
2020-01-21 10:21 ` [PATCH 3/4] mmc: sdhci-of-arasan: Add support for DLL reset for ZynqMP platforms Manish Narani
2020-02-03 11:31   ` Adrian Hunter
2020-01-21 10:21 ` [PATCH 4/4] sdhci: arasan: Remove quirk for broken base clock Manish Narani
2020-02-03 11:31   ` Adrian Hunter
2020-02-04 11:42     ` Michal Simek
2020-02-04 12:29       ` Ulf Hansson
2020-02-04 12:31         ` Michal Simek
2020-02-03  7:20 ` [PATCH 0/4] Enhancements and Bug Fixes in ZynqMP SDHCI Manish Narani
2020-02-13 13:56 ` Ulf Hansson
2020-02-14  6:39   ` Manish Narani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63fa8a5a-d87f-8fdd-3e6d-d95a14f562f2@xilinx.com \
    --to=michal.simek@xilinx.com \
    --cc=adrian.hunter@intel.com \
    --cc=jolly.shah@xilinx.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=manish.narani@xilinx.com \
    --cc=nava.manne@xilinx.com \
    --cc=rajan.vaja@xilinx.com \
    --cc=tejas.patel@xilinx.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-mmc Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mmc/0 linux-mmc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mmc linux-mmc/ https://lore.kernel.org/linux-mmc \
		linux-mmc@vger.kernel.org
	public-inbox-index linux-mmc

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-mmc


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git