From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47661C10F27 for ; Mon, 9 Mar 2020 07:21:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 25B732072A for ; Mon, 9 Mar 2020 07:21:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726027AbgCIHVs (ORCPT ); Mon, 9 Mar 2020 03:21:48 -0400 Received: from mga05.intel.com ([192.55.52.43]:17766 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725796AbgCIHVs (ORCPT ); Mon, 9 Mar 2020 03:21:48 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Mar 2020 00:21:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,532,1574150400"; d="scan'208";a="235518625" Received: from ahunter-desktop.fi.intel.com (HELO [10.237.72.167]) ([10.237.72.167]) by fmsmga008.fm.intel.com with ESMTP; 09 Mar 2020 00:21:45 -0700 Subject: Re: [PATCH v2 01/11] mmc: sdhci: Introduce sdhci_set_power_and_bus_voltage() To: Nicolas Saenz Julienne , linux-kernel@vger.kernel.org Cc: phil@raspberrypi.com, linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, f.fainelli@gmail.com, stefan.wahren@i2se.com, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, Ulf Hansson References: <20200306174413.20634-1-nsaenzjulienne@suse.de> <20200306174413.20634-2-nsaenzjulienne@suse.de> From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: <76f253b4-c4d9-9f54-d161-8013494759f5@intel.com> Date: Mon, 9 Mar 2020 09:21:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200306174413.20634-2-nsaenzjulienne@suse.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org On 6/03/20 7:44 pm, Nicolas Saenz Julienne wrote: > Some controllers diverge from the standard way of setting power and need > their bus voltage register to be configured regardless of the whether > they use regulators. As this is a common pattern across sdhci hosts, > create a helper function. > > Signed-off-by: Nicolas Saenz Julienne Acked-by: Adrian Hunter > --- > drivers/mmc/host/sdhci.c | 19 +++++++++++++++++++ > drivers/mmc/host/sdhci.h | 3 +++ > 2 files changed, 22 insertions(+) > > diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c > index 9c3745118e49..6ed11f9554e8 100644 > --- a/drivers/mmc/host/sdhci.c > +++ b/drivers/mmc/host/sdhci.c > @@ -2010,6 +2010,25 @@ void sdhci_set_power(struct sdhci_host *host, unsigned char mode, > } > EXPORT_SYMBOL_GPL(sdhci_set_power); > > +/* > + * Some controllers need to configure a valid bus voltage on their power > + * register regardless of whether an external regulator is taking care of power > + * supply. This helper function takes care of it if set as the controller's > + * sdhci_ops.set_power callback. > + */ > +void sdhci_set_power_and_bus_voltage(struct sdhci_host *host, > + unsigned char mode, > + unsigned short vdd) > +{ > + if (!IS_ERR(host->mmc->supply.vmmc)) { > + struct mmc_host *mmc = host->mmc; > + > + mmc_regulator_set_ocr(mmc, mmc->supply.vmmc, vdd); > + } > + sdhci_set_power_noreg(host, mode, vdd); > +} > +EXPORT_SYMBOL_GPL(sdhci_set_power_and_bus_voltage); > + > /*****************************************************************************\ > * * > * MMC callbacks * > diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h > index cac2d97782e6..1be7c18264cd 100644 > --- a/drivers/mmc/host/sdhci.h > +++ b/drivers/mmc/host/sdhci.h > @@ -772,6 +772,9 @@ void sdhci_set_clock(struct sdhci_host *host, unsigned int clock); > void sdhci_enable_clk(struct sdhci_host *host, u16 clk); > void sdhci_set_power(struct sdhci_host *host, unsigned char mode, > unsigned short vdd); > +void sdhci_set_power_and_bus_voltage(struct sdhci_host *host, > + unsigned char mode, > + unsigned short vdd); > void sdhci_set_power_noreg(struct sdhci_host *host, unsigned char mode, > unsigned short vdd); > void sdhci_request(struct mmc_host *mmc, struct mmc_request *mrq); >