From: Adrian Hunter <adrian.hunter@intel.com>
To: Baolin Wang <baolin.wang7@gmail.com>, ulf.hansson@linaro.org
Cc: orsonzhai@gmail.com, zhang.lyra@gmail.com, arnd@arndb.de,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] Introduce the request_atomic() for the host
Date: Tue, 17 Mar 2020 15:25:05 +0200 [thread overview]
Message-ID: <7866e519-80ad-8678-6708-7726a53ea4f5@intel.com> (raw)
In-Reply-To: <cover.1584428736.git.baolin.wang7@gmail.com>
On 17/03/20 12:14 pm, Baolin Wang wrote:
> This patch set introduces a new request_atomic() interface for the
> MMC host controller, which is used to submit a request to host in
> the atomic context, such as in the irq hard handler, to reduce the
> request latency.
>
> Any comments are welcome. Thanks.
>
> Note: Adrian pointed out that it is not good if moving the polling of
> inhibit bits in sdhci_send_command() into the interrupt context, but
> now I have not found a better way to address Adrian's concern. Moveover
> this is an unusual abnormal case and the original code has the same
> problem, so I plan to create another patch set to talk about and fix
> this issue.
I tend to think the API requires the possibility for host controllers to
return "busy", so that should be sorted out first.
>
> Changes from v1:
> - Re-split the changes to make them more clear suggested by Ulf.
> - Factor out the auto CMD23 checking into a separate function.
>
> Baolin Wang (3):
> mmc: host: Introduce the request_atomic() for the host
> mmc: host: sdhci: Implement the request_atomic() API
> mmc: host: sdhci-sprd: Implement the request_atomic() API
>
> drivers/mmc/host/mmc_hsq.c | 5 ++++-
> drivers/mmc/host/sdhci-sprd.c | 23 ++++++++++++++++++++---
> drivers/mmc/host/sdhci.c | 27 +++++++++++++++++++--------
> drivers/mmc/host/sdhci.h | 1 +
> include/linux/mmc/host.h | 3 +++
> 5 files changed, 47 insertions(+), 12 deletions(-)
>
next prev parent reply other threads:[~2020-03-17 13:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 10:14 [PATCH v2 0/3] Introduce the request_atomic() for the host Baolin Wang
2020-03-17 10:14 ` [PATCH v2 1/3] mmc: host: " Baolin Wang
2020-03-17 10:14 ` [PATCH v2 2/3] mmc: host: sdhci: Implement the request_atomic() API Baolin Wang
2020-03-17 10:14 ` [PATCH v2 3/3] mmc: host: sdhci-sprd: " Baolin Wang
2020-03-17 13:25 ` Adrian Hunter [this message]
2020-03-17 13:49 ` [PATCH v2 0/3] Introduce the request_atomic() for the host Baolin Wang
2020-03-17 15:06 ` Adrian Hunter
2020-03-18 7:35 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7866e519-80ad-8678-6708-7726a53ea4f5@intel.com \
--to=adrian.hunter@intel.com \
--cc=arnd@arndb.de \
--cc=baolin.wang7@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=ulf.hansson@linaro.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).