Linux-mmc Archive on lore.kernel.org
 help / color / Atom feed
* Re: [PATCH v2] mmc: tegra: fix SDR50 tuning override
       [not found] <b20c4847980c2c385ff0d7677fa5101c4d040749.1578314098.git.mirq-linux@rere.qmqm.pl>
@ 2020-01-07  7:23 ` Adrian Hunter
  0 siblings, 0 replies; only message in thread
From: Adrian Hunter @ 2020-01-07  7:23 UTC (permalink / raw)
  To: Michał Mirosław
  Cc: linux-tegra, linux-kernel, linux-mmc, Ulf Hansson, Thierry Reding

On 6/01/20 2:36 pm, Michał Mirosław wrote:
> Commit 7ad2ed1dfcbe inadvertently mixed up a quirk flag's name and
> broke SDR50 tuning override. Use correct NVQUIRK_ name.
> 
> Fixes: 7ad2ed1dfcbe ("mmc: tegra: enable UHS-I modes")
> Cc: <stable@vger.kernel.org> # 4f6aa3264af4: mmc: tegra: Only advertise UHS modes if IO regulator is present
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>

You should have included Thierry's Reviewed-by and Tested-by

Otherwise:

Acked-by: Adrian Hunter <adrian.hunter@intel.com>

> ---
>  v2: converted 'Depends-On' tag to proper 'Cc: stable' lines
> ---
>  drivers/mmc/host/sdhci-tegra.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
> index 7bc950520fd9..403ac44a7378 100644
> --- a/drivers/mmc/host/sdhci-tegra.c
> +++ b/drivers/mmc/host/sdhci-tegra.c
> @@ -386,7 +386,7 @@ static void tegra_sdhci_reset(struct sdhci_host *host, u8 mask)
>  			misc_ctrl |= SDHCI_MISC_CTRL_ENABLE_DDR50;
>  		if (soc_data->nvquirks & NVQUIRK_ENABLE_SDR104)
>  			misc_ctrl |= SDHCI_MISC_CTRL_ENABLE_SDR104;
> -		if (soc_data->nvquirks & SDHCI_MISC_CTRL_ENABLE_SDR50)
> +		if (soc_data->nvquirks & NVQUIRK_ENABLE_SDR50)
>  			clk_ctrl |= SDHCI_CLOCK_CTRL_SDR50_TUNING_OVERRIDE;
>  	}
>  
> 


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <b20c4847980c2c385ff0d7677fa5101c4d040749.1578314098.git.mirq-linux@rere.qmqm.pl>
2020-01-07  7:23 ` [PATCH v2] mmc: tegra: fix SDR50 tuning override Adrian Hunter

Linux-mmc Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mmc/0 linux-mmc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mmc linux-mmc/ https://lore.kernel.org/linux-mmc \
		linux-mmc@vger.kernel.org
	public-inbox-index linux-mmc

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-mmc


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git