From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D720C33C99 for ; Tue, 7 Jan 2020 07:24:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 70567207E0 for ; Tue, 7 Jan 2020 07:24:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726651AbgAGHYQ (ORCPT ); Tue, 7 Jan 2020 02:24:16 -0500 Received: from mga12.intel.com ([192.55.52.136]:3977 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725874AbgAGHYP (ORCPT ); Tue, 7 Jan 2020 02:24:15 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Jan 2020 23:24:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,404,1571727600"; d="scan'208";a="395269223" Received: from ahunter-desktop.fi.intel.com (HELO [10.237.72.167]) ([10.237.72.167]) by orsmga005.jf.intel.com with ESMTP; 06 Jan 2020 23:24:13 -0800 Subject: Re: [PATCH v2] mmc: tegra: fix SDR50 tuning override To: =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, Ulf Hansson , Thierry Reding References: From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: <9ad68894-fe90-4fb1-47b9-2304dee5b902@intel.com> Date: Tue, 7 Jan 2020 09:23:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org On 6/01/20 2:36 pm, Michał Mirosław wrote: > Commit 7ad2ed1dfcbe inadvertently mixed up a quirk flag's name and > broke SDR50 tuning override. Use correct NVQUIRK_ name. > > Fixes: 7ad2ed1dfcbe ("mmc: tegra: enable UHS-I modes") > Cc: # 4f6aa3264af4: mmc: tegra: Only advertise UHS modes if IO regulator is present > Cc: > Signed-off-by: Michał Mirosław You should have included Thierry's Reviewed-by and Tested-by Otherwise: Acked-by: Adrian Hunter > --- > v2: converted 'Depends-On' tag to proper 'Cc: stable' lines > --- > drivers/mmc/host/sdhci-tegra.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c > index 7bc950520fd9..403ac44a7378 100644 > --- a/drivers/mmc/host/sdhci-tegra.c > +++ b/drivers/mmc/host/sdhci-tegra.c > @@ -386,7 +386,7 @@ static void tegra_sdhci_reset(struct sdhci_host *host, u8 mask) > misc_ctrl |= SDHCI_MISC_CTRL_ENABLE_DDR50; > if (soc_data->nvquirks & NVQUIRK_ENABLE_SDR104) > misc_ctrl |= SDHCI_MISC_CTRL_ENABLE_SDR104; > - if (soc_data->nvquirks & SDHCI_MISC_CTRL_ENABLE_SDR50) > + if (soc_data->nvquirks & NVQUIRK_ENABLE_SDR50) > clk_ctrl |= SDHCI_CLOCK_CTRL_SDR50_TUNING_OVERRIDE; > } > >