From: Guenter Roeck <groeck@google.com>
To: Douglas Anderson <dianders@chromium.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
Guenter Roeck <groeck@chromium.org>,
Matthias Kaehlcke <mka@chromium.org>,
Nicolas Boichat <drinkcat@chromium.org>,
Ming Lei <ming.lei@redhat.com>,
linux-mmc@vger.kernel.org, Hannes Reinecke <hare@suse.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Jens Axboe <axboe@kernel.dk>, Omar Sandoval <osandov@fb.com>
Subject: Re: [PATCH] mmc: block: Fix memory leak in blk-mq when cleaning up
Date: Fri, 3 May 2019 17:20:41 -0700 [thread overview]
Message-ID: <CABXOdTdsB82EGn_9ZTQCS2TfcNSR6Mq5J9WjGYbdrKOPsd-jzg@mail.gmail.com> (raw)
In-Reply-To: <20190503233526.226272-1-dianders@chromium.org>
On Fri, May 3, 2019 at 4:35 PM Douglas Anderson <dianders@chromium.org> wrote:
>
> If I run the following on rk3288-veyron-minnie (a 2GB machine)
>
> cd /sys/bus/platform/drivers/dwmmc_rockchip
> for i in $(seq 1 3000); do
> echo "========================" $i
> echo ff0f0000.dwmmc > unbind
> sleep .5
> echo ff0f0000.dwmmc > bind
> while true; do
> if [ -e /dev/mmcblk2 ]; then
> break;
> fi
> sleep .1
> done
> done
>
> Then I start OOMing somewhere between iteration 200 and 250. Using
> kmemleak, I see reports like:
>
> unreferenced object 0xe39c5580 (size 64):
> comm "kworker/1:0", pid 17, jiffies 4294821091 (age 96.952s)
> hex dump (first 32 bytes):
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> backtrace:
> [<ad19d10a>] __kmalloc+0x1ec/0x2dc
> [<a28614c3>] blk_mq_alloc_tag_set+0x27c/0x2bc
> [<0955ae01>] mmc_init_queue+0xa8/0x2a8
> [<5102b986>] mmc_blk_alloc_req+0xf8/0x2d4
> [<f1c2214f>] mmc_blk_probe+0x4a8/0x6c0
> [<0dfdd9d5>] mmc_bus_probe+0x24/0x28
>
> It's pretty clear that we're missing a call to blk_mq_free_tag_set().
> Let's add it.
>
> Fixes: 81196976ed94 ("mmc: block: Add blk-mq support")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
Nice one.
Reviewed-by: Guenter Roeck <groeck@chromium.org>
> ---
>
> drivers/mmc/core/queue.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mmc/core/queue.c b/drivers/mmc/core/queue.c
> index 7c364a9c4eeb..09071e13282e 100644
> --- a/drivers/mmc/core/queue.c
> +++ b/drivers/mmc/core/queue.c
> @@ -480,6 +480,8 @@ void mmc_cleanup_queue(struct mmc_queue *mq)
> */
> flush_work(&mq->complete_work);
>
> + blk_mq_free_tag_set(&mq->tag_set);
> +
> mq->card = NULL;
> }
>
> --
> 2.21.0.1020.gf2820cf01a-goog
>
next prev parent reply other threads:[~2019-05-04 0:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-03 23:35 [PATCH] mmc: block: Fix memory leak in blk-mq when cleaning up Douglas Anderson
2019-05-03 23:52 ` Matthias Kaehlcke
2019-05-04 0:20 ` Guenter Roeck [this message]
[not found] ` <20190503233526.226272-1-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2019-05-04 11:57 ` Linus Walleij
2019-05-06 7:22 ` Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABXOdTdsB82EGn_9ZTQCS2TfcNSR6Mq5J9WjGYbdrKOPsd-jzg@mail.gmail.com \
--to=groeck@google.com \
--cc=adrian.hunter@intel.com \
--cc=axboe@kernel.dk \
--cc=dianders@chromium.org \
--cc=drinkcat@chromium.org \
--cc=groeck@chromium.org \
--cc=hare@suse.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=ming.lei@redhat.com \
--cc=mka@chromium.org \
--cc=osandov@fb.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).