From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0C78C433FE for ; Fri, 17 Sep 2021 18:41:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A83A961241 for ; Fri, 17 Sep 2021 18:41:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241110AbhIQSmZ (ORCPT ); Fri, 17 Sep 2021 14:42:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240624AbhIQSmY (ORCPT ); Fri, 17 Sep 2021 14:42:24 -0400 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 425BCC061764 for ; Fri, 17 Sep 2021 11:41:02 -0700 (PDT) Received: by mail-ed1-x52f.google.com with SMTP id z94so33190385ede.8 for ; Fri, 17 Sep 2021 11:41:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Cpak71tpwGIH8sDgLDrdJbMzVDQHoqt6rJZasCMwdzc=; b=PPZqYKySWRBXLCmQqLignaVRzeemkJWbOSVm4Nk3LB3/dwYqxZT99gFitFC859Cqmo 5dHLqIWjBbL09xTf3eNTCSAzEfwW62QnHoObFrYVOWn0PPzzY6lksRvKhahbrO9bPfvT /jfwN2l8iu/pKIRl254LqCHUDuwZMUECiAh00= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Cpak71tpwGIH8sDgLDrdJbMzVDQHoqt6rJZasCMwdzc=; b=OC42r8KWrdE7CLE0LVWa+ugK3Ai6C85cCKx8JubEYsLcEyOnDC9tLrYehymPW3CUJr qgQUE4Ds4KUcFlicyWGFstVxx7KM/LhwSKHggQJSjkmvWtcroitELfJ1GpId7PVxUQgk akM9/gzqP44bSYas/wdsFZjhFkAs0+gcVwBZKfnF4eminDckFaOvVEXeNK7X2C8r7djm VHg4H865VI9YoVBhzA5HUtMOcxJVNvAlnF3c3YPk8eJsZ1pxus1+8TF66UhBbh+3sjXT Bpi9+oW5E5x8M10/7BGj9aFJUjsPOUN9CkMYu3xyl5uYeGDCf8BlJ5Dua8NT8aKysM3F 9Eqg== X-Gm-Message-State: AOAM5319F4ZLrWJQFeqb2Mn+h22vEi+GZpG1JvzratWjlck7vZHBS50R wJ7UmV8HHJUwdDMKww7eytxxsEJETCBP+PBXmQw= X-Google-Smtp-Source: ABdhPJwoKf3gbN2aWsfxGF0C+pgfv1XGWlVumF7NF0zSIhLbosD105I2V5Bx+Yh2TgdXrhcagoowPw== X-Received: by 2002:a05:6402:3128:: with SMTP id dd8mr13662987edb.383.1631904060518; Fri, 17 Sep 2021 11:41:00 -0700 (PDT) Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com. [209.85.221.54]) by smtp.gmail.com with ESMTPSA id f25sm637188ejl.32.2021.09.17.11.41.00 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Sep 2021 11:41:00 -0700 (PDT) Received: by mail-wr1-f54.google.com with SMTP id i23so16691779wrb.2 for ; Fri, 17 Sep 2021 11:41:00 -0700 (PDT) X-Received: by 2002:a19:ae15:: with SMTP id f21mr9099719lfc.402.1631904049054; Fri, 17 Sep 2021 11:40:49 -0700 (PDT) MIME-Version: 1.0 References: <20210917061104.2680133-1-brendanhiggins@google.com> <20210917061104.2680133-6-brendanhiggins@google.com> <202109170856.8DDB49112D@keescook> In-Reply-To: <202109170856.8DDB49112D@keescook> From: Linus Torvalds Date: Fri, 17 Sep 2021 11:40:33 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v1 5/6] mmc: sdhci-of-aspeed: build kunit tests without structleak plugin To: Kees Cook Cc: Brendan Higgins , Shuah Khan , David Gow , Arnd Bergmann , Rafael Wysocki , Jonathan Cameron , Lars-Peter Clausen , Ulf Hansson , andreas.noever@gmail.com, michael.jamet@intel.com, Mika Westerberg , YehezkelShB@gmail.com, Masahiro Yamada , Michal Marek , Nick Desaulniers , "open list:KERNEL SELFTEST FRAMEWORK" , KUnit Development , Linux Kernel Mailing List , Greg Kroah-Hartman , linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, linux-usb@vger.kernel.org, linux-hardening@vger.kernel.org, Linux Kbuild mailing list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org On Fri, Sep 17, 2021 at 8:57 AM Kees Cook wrote: > > This isn't a stand-alone test object, so I'm less excited about > disabling STRUCTLEAK here. Yeah, please don't do this for things that aren't pure tests. You're now disabling security measures (even if I hate the gcc plugins and hope they will go away). Linus