From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Andreas Schwab <schwab@suse.de>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Tobias Schramm <t.schramm@manjaro.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mmc: mmc_spi: add spi:mmc-spi-slot alias
Date: Thu, 22 Jul 2021 13:28:43 +0300 [thread overview]
Message-ID: <CAHp75VfY-_xtRJyfez_4voDuOUcfJAfFjtnAipCt2_UA4wqbQg@mail.gmail.com> (raw)
In-Reply-To: <mvmczra64yj.fsf@suse.de>
On Thu, Jul 22, 2021 at 1:03 PM Andreas Schwab <schwab@suse.de> wrote:
> On Jul 21 2021, Andy Shevchenko wrote:
>
> > Or problem is somewhere else?
>
> I don't know. Why does the spi subsystem put "spi:mmc-spi-slot" into
> the modalias file, instead of "of:N(null)T(null)Cmmc-spi-slot" or
> similar? The same problem exists with the other spi port on the board,
> which has a jedec,spi-nor instance attached, also not auto loading.
You see, there are two unrelated drivers that share the same issue
(the common denominator is that they are SPI devices). I believe the
issue is somewhere in the SPI core rather than here.
Compare the code of
https://elixir.bootlin.com/linux/latest/source/drivers/i2c/i2c-core-base.c#L649
vs.
https://elixir.bootlin.com/linux/latest/source/drivers/spi/spi.c#L56
and
https://elixir.bootlin.com/linux/latest/source/drivers/i2c/i2c-core-base.c#L139
vs.
https://elixir.bootlin.com/linux/latest/source/drivers/spi/spi.c#L361
The culprit is this one:
https://lore.kernel.org/lkml/20190618052644.32446-1-bjorn.andersson@linaro.org/
and in my humble opinion must be reverted.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-07-22 10:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-21 13:26 [PATCH] mmc: mmc_spi: add spi:mmc-spi-slot alias Andreas Schwab
2021-07-21 14:33 ` Andy Shevchenko
2021-07-21 14:37 ` Andreas Schwab
2021-07-21 15:03 ` Andy Shevchenko
2021-07-21 15:15 ` Andreas Schwab
2021-07-21 15:45 ` Andy Shevchenko
2021-07-21 16:05 ` Andreas Schwab
2021-07-21 17:05 ` Andy Shevchenko
2021-07-21 19:53 ` Andreas Schwab
2021-07-21 20:05 ` Andy Shevchenko
2021-07-22 10:03 ` Andreas Schwab
2021-07-22 10:28 ` Andy Shevchenko [this message]
2021-07-22 10:36 ` Andy Shevchenko
2021-07-22 12:04 ` Andreas Schwab
2021-07-22 12:37 ` Andreas Schwab
-- strict thread matches above, loose matches on Subject: below --
2021-07-08 14:11 Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VfY-_xtRJyfez_4voDuOUcfJAfFjtnAipCt2_UA4wqbQg@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=schwab@suse.de \
--cc=srinivas.kandagatla@linaro.org \
--cc=t.schramm@manjaro.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).