From: Baolin Wang <baolin.wang@linaro.org>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
asutoshd@codeaurora.org, Orson Zhai <orsonzhai@gmail.com>,
Chunyan Zhang <zhang.lyra@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Linus Walleij <linus.walleij@linaro.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
baolin.wang7@gmail.com, linux-mmc <linux-mmc@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 4/4] mmc: host: sdhci: Add a variable to defer to complete data requests if needed
Date: Fri, 8 Nov 2019 19:27:01 +0800 [thread overview]
Message-ID: <CAMz4kuLT_3Hun_=ZiwRsqOcwxNoSasgFTfj7_1naBtVneSiJpg@mail.gmail.com> (raw)
In-Reply-To: <0c70b5cf-4453-b21b-5622-f97ff069cf1b@intel.com>
On Fri, 8 Nov 2019 at 19:24, Adrian Hunter <adrian.hunter@intel.com> wrote:
>
> On 8/11/19 1:08 PM, Baolin Wang wrote:
> > On 06/11/2019, Baolin Wang <baolin.wang@linaro.org> wrote:
> >> On Wed, 6 Nov 2019 at 20:02, Adrian Hunter <adrian.hunter@intel.com> wrote:
> >>>
> >>> To move ahead in the meantime without a new host API, just defer always
> >
> > Before new version, I want to make things clear in case I
> > misunderstood your points, so you mean I should set always_defer_done
> > = true for our Spreadtrum host driver in this patch? Or just like
> > below patch? Thanks.
> >
> > diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> > index 850241f..4bef066 100644
> > --- a/drivers/mmc/host/sdhci.c
> > +++ b/drivers/mmc/host/sdhci.c
> > @@ -3035,7 +3035,7 @@ static inline bool sdhci_defer_done(struct
> > sdhci_host *host,
> > {
> > struct mmc_data *data = mrq->data;
> >
> > - return host->pending_reset ||
> > + return host->pending_reset || host->always_defer_done ||
> > ((host->flags & SDHCI_REQ_USE_DMA) && data &&
> > data->host_cookie == COOKIE_MAPPED);
> > }
> > diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h
> > index d89cdb9..a73ce89 100644
> > --- a/drivers/mmc/host/sdhci.h
> > +++ b/drivers/mmc/host/sdhci.h
> > @@ -533,6 +533,7 @@ struct sdhci_host {
> > bool pending_reset; /* Cmd/data reset is pending */
> > bool irq_wake_enabled; /* IRQ wakeup is enabled */
> > bool v4_mode; /* Host Version 4 Enable */
> > + bool always_defer_done; /* Always defer to complete requests */
> >
> > struct mmc_request *mrqs_done[SDHCI_MAX_MRQS]; /* Requests done */
> > struct mmc_command *cmd; /* Current command */
> >
>
> Yes
Got it. Thanks for your confirming.
--
Baolin Wang
Best Regards
next prev parent reply other threads:[~2019-11-08 11:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-29 5:43 [PATCH v5 0/4] Add MMC software queue support Baolin Wang
2019-10-29 5:43 ` [PATCH v5 1/4] mmc: Add MMC host " Baolin Wang
2019-10-29 5:43 ` [PATCH v5 2/4] mmc: host: sdhci: Add request_done ops for struct sdhci_ops Baolin Wang
2019-10-29 5:43 ` [PATCH v5 3/4] mmc: host: sdhci-sprd: Add software queue support Baolin Wang
2019-10-29 5:43 ` [PATCH v5 4/4] mmc: host: sdhci: Add a variable to defer to complete data requests if needed Baolin Wang
2019-11-06 10:09 ` Adrian Hunter
2019-11-06 10:48 ` Baolin Wang
2019-11-06 12:01 ` Adrian Hunter
2019-11-06 12:17 ` Baolin Wang
2019-11-08 11:08 ` Baolin Wang
2019-11-08 11:23 ` Adrian Hunter
2019-11-08 11:27 ` Baolin Wang [this message]
2019-11-06 9:42 ` [PATCH v5 0/4] Add MMC software queue support Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMz4kuLT_3Hun_=ZiwRsqOcwxNoSasgFTfj7_1naBtVneSiJpg@mail.gmail.com' \
--to=baolin.wang@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=arnd@arndb.de \
--cc=asutoshd@codeaurora.org \
--cc=baolin.wang7@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=ulf.hansson@linaro.org \
--cc=vincent.guittot@linaro.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).