From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ulf Hansson Subject: Re: [PATCH] mmc: renesas_sdhi: add checks for pinctrl_lookup_state Date: Mon, 21 Oct 2019 16:32:49 +0200 Message-ID: References: <20191018131338.11713-1-hslester96@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20191018131338.11713-1-hslester96@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Chuhong Yuan , Wolfram Sang Cc: "linux-mmc@vger.kernel.org" , Linux Kernel Mailing List List-Id: linux-mmc@vger.kernel.org On Fri, 18 Oct 2019 at 15:13, Chuhong Yuan wrote: > > renesas_sdhi_probe misses checks for pinctrl_lookup_state and may miss > failures. > Add checks for them to fix the problem. > > Signed-off-by: Chuhong Yuan > --- > drivers/mmc/host/renesas_sdhi_core.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c > index d4ada5cca2d1..dc5ad6632df3 100644 > --- a/drivers/mmc/host/renesas_sdhi_core.c > +++ b/drivers/mmc/host/renesas_sdhi_core.c > @@ -694,8 +694,13 @@ int renesas_sdhi_probe(struct platform_device *pdev, > if (!IS_ERR(priv->pinctrl)) { > priv->pins_default = pinctrl_lookup_state(priv->pinctrl, > PINCTRL_STATE_DEFAULT); > + if (IS_ERR(priv->pins_default)) > + return PTR_ERR(priv->pins_default); > + > priv->pins_uhs = pinctrl_lookup_state(priv->pinctrl, > "state_uhs"); > + if (IS_ERR(priv->pins_uhs)) > + return PTR_ERR(priv->pins_uhs); > } This looks correct to me, as I guess if there is a pinctrl specified for device node of the controller, it means that it should be used!? I understand that this is only used for those variants that supports UHS-I via the renesas_sdhi_start_signal_voltage_switch(). Wolfram, is this fine you think? > > host = tmio_mmc_host_alloc(pdev, mmc_data); > -- > 2.20.1 > Kind regards Uffe