From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDC76C433DF for ; Tue, 19 May 2020 07:29:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 980D72075F for ; Tue, 19 May 2020 07:29:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ppCH2wak" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727087AbgESH3V (ORCPT ); Tue, 19 May 2020 03:29:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726892AbgESH3U (ORCPT ); Tue, 19 May 2020 03:29:20 -0400 Received: from mail-ua1-x941.google.com (mail-ua1-x941.google.com [IPv6:2607:f8b0:4864:20::941]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B33AAC061A0C for ; Tue, 19 May 2020 00:29:20 -0700 (PDT) Received: by mail-ua1-x941.google.com with SMTP id i5so4423949uaq.1 for ; Tue, 19 May 2020 00:29:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MGKa+ni4azruYMg4t2OX9ZfrcsxATG1wfkYBrvmx3ac=; b=ppCH2waksv32s+VVjjgoMAHZCn1L6IO+CmDuUgCw0Ah8QKNmJsagxzjFwL1icKfVL6 GMFWWLDxgqUgXutFVVzJi3VAwC3XUqmxCY6DikqwItRz2Z+sxzMOxZUIuGbPS7LMLFAo 2CrhGUnvrHNzcOhTf6J0cWp5Wo3JPer7NcqIN4d26PORoOmIKbmdOgEqFUpk8WacxsAB sb+1PA2XFj/jrKGRv1/6lcfY4xY1zeXqbaeFMama6eAdHX+1zaVPRgJV0L6RpsaTdRae i4ngUbPx2AjAShzmkOh4EQOybvPQ8BhHHrNYB7CrCeeFd2fNUK/+ptg132X2WpNow7o3 laUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MGKa+ni4azruYMg4t2OX9ZfrcsxATG1wfkYBrvmx3ac=; b=QoYSb6UD0jNnq00ED5nawK1F5+VGmVPCFbvYOfdUatGPvo4rmIZvuYyhDZFw5BMK9g DjKq67/orvdS2z0ScQl4xTp3pgZQ1wCNpJglibQqwxHS8g5NvfjQFYsGbP3FraXZgivk TYcoT+zUu4nHpX+jnZCOf6ytOKZ/OramVx796jvFIH0xpjNEiOo0Qh7h1VCVxS3Aq2nQ mjShguRi707Y+vquVtgcyefDp2FEZG97txnEoC5eUANOvLeA7j9ZuQhNrfYBdbzSu9fn u3lRKMqIFusM37YGpXfaAm32kb5JKXUI+diwgrpiBMgkLoMYbK4aIGh/6+f3pNn1S+t5 A5jA== X-Gm-Message-State: AOAM530/OzpiyIPnjDCrnMvXFTjEWbCSgipi9Sp2K3Oqwq4gxmJAsQK+ 9mcmUv3zJYTuy89JXcwdsiaLLtqit+NRoKlWNM/E4Q== X-Google-Smtp-Source: ABdhPJziq/dAaaMSV1g+QUyl2hxCAINBzMD1C8r8rFdoRyfZhqRSKCVUBriAlDSydtj6W9Tb1GcQRCiaHtbeQ3upsjw= X-Received: by 2002:ab0:5ca:: with SMTP id e68mr13796837uae.19.1589873359897; Tue, 19 May 2020 00:29:19 -0700 (PDT) MIME-Version: 1.0 References: <20200516154314.14769-1-digetx@gmail.com> In-Reply-To: <20200516154314.14769-1-digetx@gmail.com> From: Ulf Hansson Date: Tue, 19 May 2020 09:28:43 +0200 Message-ID: Subject: Re: [PATCH v1] sdhci: tegra: Remove warnings about missing device-tree properties To: Dmitry Osipenko Cc: Thierry Reding , Jonathan Hunter , Adrian Hunter , "linux-mmc@vger.kernel.org" , linux-tegra , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org On Sat, 16 May 2020 at 17:44, Dmitry Osipenko wrote: > > Several people asked me about the MMC warnings in the KMSG log and > I had to tell to ignore them because these warning are irrelevant to > pre-Tegra210 SoCs. Why are the warnings irrelevant? > It should be up to a board's device-tree writer to > properly describe all the necessary properties. Secondly, eventually all > device-tree bindings will be converted to YAML, which allows to validate > board DT files, giving a warning about missing properties. Hence let's > remove the noisy warnings to stop the confusion. Yep, makes sense. However, perhaps we should do this conversion then, rather than first drop the warnings? Kind regards Uffe > > Signed-off-by: Dmitry Osipenko > --- > drivers/mmc/host/sdhci-tegra.c | 28 ++++------------------------ > 1 file changed, 4 insertions(+), 24 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c > index 3e2c5101291d..83867629013d 100644 > --- a/drivers/mmc/host/sdhci-tegra.c > +++ b/drivers/mmc/host/sdhci-tegra.c > @@ -607,46 +607,26 @@ static void tegra_sdhci_parse_pad_autocal_dt(struct sdhci_host *host) > err = device_property_read_u32(host->mmc->parent, > "nvidia,pad-autocal-pull-up-offset-3v3-timeout", > &autocal->pull_up_3v3_timeout); > - if (err) { > - if (!IS_ERR(tegra_host->pinctrl_state_3v3) && > - (tegra_host->pinctrl_state_3v3_drv == NULL)) > - pr_warn("%s: Missing autocal timeout 3v3-pad drvs\n", > - mmc_hostname(host->mmc)); > + if (err) > autocal->pull_up_3v3_timeout = 0; > - } > > err = device_property_read_u32(host->mmc->parent, > "nvidia,pad-autocal-pull-down-offset-3v3-timeout", > &autocal->pull_down_3v3_timeout); > - if (err) { > - if (!IS_ERR(tegra_host->pinctrl_state_3v3) && > - (tegra_host->pinctrl_state_3v3_drv == NULL)) > - pr_warn("%s: Missing autocal timeout 3v3-pad drvs\n", > - mmc_hostname(host->mmc)); > + if (err) > autocal->pull_down_3v3_timeout = 0; > - } > > err = device_property_read_u32(host->mmc->parent, > "nvidia,pad-autocal-pull-up-offset-1v8-timeout", > &autocal->pull_up_1v8_timeout); > - if (err) { > - if (!IS_ERR(tegra_host->pinctrl_state_1v8) && > - (tegra_host->pinctrl_state_1v8_drv == NULL)) > - pr_warn("%s: Missing autocal timeout 1v8-pad drvs\n", > - mmc_hostname(host->mmc)); > + if (err) > autocal->pull_up_1v8_timeout = 0; > - } > > err = device_property_read_u32(host->mmc->parent, > "nvidia,pad-autocal-pull-down-offset-1v8-timeout", > &autocal->pull_down_1v8_timeout); > - if (err) { > - if (!IS_ERR(tegra_host->pinctrl_state_1v8) && > - (tegra_host->pinctrl_state_1v8_drv == NULL)) > - pr_warn("%s: Missing autocal timeout 1v8-pad drvs\n", > - mmc_hostname(host->mmc)); > + if (err) > autocal->pull_down_1v8_timeout = 0; > - } > > err = device_property_read_u32(host->mmc->parent, > "nvidia,pad-autocal-pull-up-offset-sdr104", > -- > 2.26.0 >