From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4A9CC352BE for ; Fri, 17 Apr 2020 08:05:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8F5DA20644 for ; Fri, 17 Apr 2020 08:05:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yakEra6h" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729569AbgDQIFV (ORCPT ); Fri, 17 Apr 2020 04:05:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1729550AbgDQIFT (ORCPT ); Fri, 17 Apr 2020 04:05:19 -0400 Received: from mail-vk1-xa44.google.com (mail-vk1-xa44.google.com [IPv6:2607:f8b0:4864:20::a44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7AE86C061A41 for ; Fri, 17 Apr 2020 01:05:19 -0700 (PDT) Received: by mail-vk1-xa44.google.com with SMTP id 10so342631vkr.7 for ; Fri, 17 Apr 2020 01:05:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vw2Yz9QKvnH8qm78kPmIMpthfuS5ToTfV4/eBO9aXZs=; b=yakEra6h63cypV6sApwJRt8QTk1typgQ4CUWktDZ3OaZbJmY+czocu/ZicycqNwDkT JOIu15o2SyBxO3YPCHZvYc8bWH6INqt4ZqgoKAyIauLORiCPzFt5M5ACHWGXW2hYdyH/ 6cYdwDNvlR9nkz9COyri//bhLKT9lamCNgXtlh6zx8xDx3li9Gqv1iH6RwOQJCe8Tki4 itvoWt2sG59DULq6Rl8gh+8HdsBK4UlEHfDhiv5K7OjcHUL9Uszq+t30cvWjVtTot6Mk 5/RvXvnrgcgfUhZ17C1+iB3xaZA3KqYelNiDD7PBUZ7r8ywLOpqNIK4gN6j62jaFIj9L q3Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vw2Yz9QKvnH8qm78kPmIMpthfuS5ToTfV4/eBO9aXZs=; b=s2nIKYGc1lWm/AXSa8WvspEvBcrEK5l0JEKNMQkWqHEoe33sdnSGgDDx7gAfccgZrH OH9BSa0Y79GI36WaU+Q3NfuqbY7vx4/13NjP2j6sitqeaVSIjD28rv0KrMmKirZ9YYPi baotvyrrZnflq/t2ps4oFicasBcxxLYgPTNlxoHL5Wpcq8joEWs1rDZswFHY8CXg6PB3 1Vy0P8hUtpgWiIkKMpPJmVoLdd7AsaKa1SqnKEWtugTDQC9ip7iiKiHHU16jyiwQWOjC mZwFJMIhTLACG4nzdUm6OvZlucjY8j/DCZ+4EGRTecYBz3hqxeG3JE9htuiE7aHJMsSx LVow== X-Gm-Message-State: AGi0Pub0TbuEmvEY3z+bVgYgBCPl1uUNon65sExV9rD4O8Wcd5gpDJnc qcQ8nzedsfynVW0yPDxFbJh3QsWWX0zLc3oKfo97Dw== X-Google-Smtp-Source: APiQypLoL1YUf3ZDQ50QAVVPjT9KC5UFb4LnKhTt6wcbcy1pMZpYbxuwtVXDiDhZcuVUwVfYGRbRIOQZDAqOlH9YkBI= X-Received: by 2002:a1f:5003:: with SMTP id e3mr1455112vkb.59.1587110718373; Fri, 17 Apr 2020 01:05:18 -0700 (PDT) MIME-Version: 1.0 References: <1583886030-11339-1-git-send-email-skomatineni@nvidia.com> <753ec108-858c-660e-af0a-f57922134609@nvidia.com> <512441d1-a9ba-912f-ed2e-46edad22278b@nvidia.com> In-Reply-To: <512441d1-a9ba-912f-ed2e-46edad22278b@nvidia.com> From: Ulf Hansson Date: Fri, 17 Apr 2020 10:04:42 +0200 Message-ID: Subject: Re: [PATCH v2 1/2] sdhci: tegra: Implement Tegra specific set_timeout callback To: Sowjanya Komatineni Cc: Naresh Kamboju , Greg Kroah-Hartman , Sasha Levin , Adrian Hunter , "(Exiting) Baolin Wang" , Kate Stewart , Thomas Gleixner , Bradley Bolen , Thierry Reding , Jon Hunter , Aniruddha Tvs Rao , linux-tegra , open list , "linux-mmc@vger.kernel.org" , lkft-triage@lists.linaro.org, linux- stable Content-Type: text/plain; charset="UTF-8" Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org On Thu, 16 Apr 2020 at 21:39, Sowjanya Komatineni wrote: > > > On 4/16/20 9:29 AM, Sowjanya Komatineni wrote: > > > > On 4/16/20 3:59 AM, Ulf Hansson wrote: > >> External email: Use caution opening links or attachments > >> > >> > >> On Wed, 15 Apr 2020 at 19:55, Naresh Kamboju > >> wrote: > >>> On Fri, 13 Mar 2020 at 06:41, Sowjanya Komatineni > >>> wrote: > >>>> Tegra host supports HW busy detection and timeouts based on the > >>>> count programmed in SDHCI_TIMEOUT_CONTROL register and max busy > >>>> timeout it supports is 11s in finite busy wait mode. > >>>> > >>>> Some operations like SLEEP_AWAKE, ERASE and flush cache through > >>>> SWITCH commands take longer than 11s and Tegra host supports > >>>> infinite HW busy wait mode where HW waits forever till the card > >>>> is busy without HW timeout. > >>>> > >>>> This patch implements Tegra specific set_timeout sdhci_ops to allow > >>>> switching between finite and infinite HW busy detection wait modes > >>>> based on the device command expected operation time. > >>>> > >>>> Signed-off-by: Sowjanya Komatineni > >>>> --- > >>>> drivers/mmc/host/sdhci-tegra.c | 31 +++++++++++++++++++++++++++++++ > >>>> 1 file changed, 31 insertions(+) > >>>> > >>>> diff --git a/drivers/mmc/host/sdhci-tegra.c > >>>> b/drivers/mmc/host/sdhci-tegra.c > >>>> index a25c3a4..fa8f6a4 100644 > >>>> --- a/drivers/mmc/host/sdhci-tegra.c > >>>> +++ b/drivers/mmc/host/sdhci-tegra.c > >>>> @@ -45,6 +45,7 @@ > >>>> #define SDHCI_TEGRA_CAP_OVERRIDES_DQS_TRIM_SHIFT 8 > >>>> > >>>> #define SDHCI_TEGRA_VENDOR_MISC_CTRL 0x120 > >>>> +#define SDHCI_MISC_CTRL_ERASE_TIMEOUT_LIMIT BIT(0) > >>>> #define SDHCI_MISC_CTRL_ENABLE_SDR104 0x8 > >>>> #define SDHCI_MISC_CTRL_ENABLE_SDR50 0x10 > >>>> #define SDHCI_MISC_CTRL_ENABLE_SDHCI_SPEC_300 0x20 > >>>> @@ -1227,6 +1228,34 @@ static u32 sdhci_tegra_cqhci_irq(struct > >>>> sdhci_host *host, u32 intmask) > >>>> return 0; > >>>> } > >>>> > >>>> +static void tegra_sdhci_set_timeout(struct sdhci_host *host, > >>>> + struct mmc_command *cmd) > >>>> +{ > >>>> + u32 val; > >>>> + > >>>> + /* > >>>> + * HW busy detection timeout is based on programmed data > >>>> timeout > >>>> + * counter and maximum supported timeout is 11s which may > >>>> not be > >>>> + * enough for long operations like cache flush, sleep > >>>> awake, erase. > >>>> + * > >>>> + * ERASE_TIMEOUT_LIMIT bit of VENDOR_MISC_CTRL register allows > >>>> + * host controller to wait for busy state until the card is > >>>> busy > >>>> + * without HW timeout. > >>>> + * > >>>> + * So, use infinite busy wait mode for operations that may > >>>> take > >>>> + * more than maximum HW busy timeout of 11s otherwise use > >>>> finite > >>>> + * busy wait mode. > >>>> + */ > >>>> + val = sdhci_readl(host, SDHCI_TEGRA_VENDOR_MISC_CTRL); > >>>> + if (cmd && cmd->busy_timeout >= 11 * HZ) > >>>> + val |= SDHCI_MISC_CTRL_ERASE_TIMEOUT_LIMIT; > >>>> + else > >>>> + val &= ~SDHCI_MISC_CTRL_ERASE_TIMEOUT_LIMIT; > >>>> + sdhci_writel(host, val, SDHCI_TEGRA_VENDOR_MISC_CTRL); > >>>> + > >>>> + __sdhci_set_timeout(host, cmd); > >>> kernel build on arm and arm64 architecture failed on stable-rc 4.19 > >>> (arm), 5.4 (arm64) and 5.5 (arm64) > >>> > >>> drivers/mmc/host/sdhci-tegra.c: In function 'tegra_sdhci_set_timeout': > >>> drivers/mmc/host/sdhci-tegra.c:1256:2: error: implicit declaration of > >>> function '__sdhci_set_timeout'; did you mean > >>> 'tegra_sdhci_set_timeout'? [-Werror=implicit-function-declaration] > >>> __sdhci_set_timeout(host, cmd); > >>> ^~~~~~~~~~~~~~~~~~~ > >>> tegra_sdhci_set_timeout > >>> > >>> Full build log, > >>> https://ci.linaro.org/view/lkft/job/openembedded-lkft-linux-stable-rc-5.5/DISTRO=lkft,MACHINE=am57xx-evm,label=docker-lkft/83/consoleText > >>> > >>> https://ci.linaro.org/view/lkft/job/openembedded-lkft-linux-stable-rc-5.4/DISTRO=lkft,MACHINE=juno,label=docker-lkft/158/consoleText > >>> > >>> https://ci.linaro.org/view/lkft/job/openembedded-lkft-linux-stable-rc-4.19/DISTRO=lkft,MACHINE=am57xx-evm,label=docker-lkft/511/consoleText > >>> > >>> > >>> - Naresh > >> Thanks for reporting! What a mess. > >> > >> It turns out that the commit that was queued for stable that is > >> causing the above errors, also requires another commit. > >> > >> The commit that was queued: > >> 5e958e4aacf4 ("sdhci: tegra: Implement Tegra specific set_timeout > >> callback") > >> > >> The additional commit needed (which was added in v5.6-rc1): > >> 7d76ed77cfbd ("mmc: sdhci: Refactor sdhci_set_timeout()") > >> > >> However, the above commit needs a manual backport (quite trivial, but > >> still) for the relevant stable kernels, to allow it to solve the build > >> problems. > >> > >> Greg, Sasha - I suggest you to drop the offending commit from the > >> stable kernels, for now. I think it's better to let Sowjanya deal with > >> the backports, then send them in small series instead. > >> > >> Kind regards > >> Uffe > > > > Hi Ufee, > > > > Will back-porting below commit cause any issues to other vendors? > > > > 7d76ed77cfbd ("mmc: sdhci: Refactor sdhci_set_timeout()") > > > sdhci-tegra driver in 4.19 is using same sdhci_ops for Tegra114 and > Tegra210 and separate sdhci_ops for T210 started from 4.20. > > 5e958e4aacf4 ("sdhci: tegra: Implement Tegra specific set_timeout callback") > > So above commit can't be applied to 4.19. So probably a separate patch > need to be created to apply for 4.19 and back port above commit along > with its dependency commit (7d76ed77cfbd ("mmc: sdhci: Refactor > sdhci_set_timeout()") for 5.4 and 5.4. Alright, seems reasonable. Just keep me/Adrian on cc when/if you post the patches so we can ack them. Kind regards Uffe