From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57276C2D0C8 for ; Tue, 10 Dec 2019 09:51:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 264F52073B for ; Tue, 10 Dec 2019 09:51:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vLSXt+0D" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727543AbfLJJvh (ORCPT ); Tue, 10 Dec 2019 04:51:37 -0500 Received: from mail-vs1-f68.google.com ([209.85.217.68]:41997 "EHLO mail-vs1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727510AbfLJJvh (ORCPT ); Tue, 10 Dec 2019 04:51:37 -0500 Received: by mail-vs1-f68.google.com with SMTP id b79so7483017vsd.9 for ; Tue, 10 Dec 2019 01:51:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kQDpaNJuTuBCwjRi4ZnQZs7rqwTgBbG2PPToht2ip2k=; b=vLSXt+0DuDKITzK3SqmZRrGE5FDWu0InRt15eBUNJ0X20O1kjN9pH9n+E14Yfx+C08 4qa4xgrg/WCYkwz5zm9rCafjbNNxEsFYcfIgIeKyNiP9qiAk9bXWIUVUI11kKR7PF2SU K0xhbqD1TW6QuAkV5pa9VHY4XCnoDktTOhRY9baV7BSYyERUlS1fBTR52DpdamphlyyL HdvmaILtNwnX2pqbIJPt0a7g5DAxyVyeG2u0isQftIhovS0a6gHORpWe6p+q+P9uaVkz qxWvNIj3uXa9d2JVvwOlYHSI6okmZsH+LDNjji2iJSRc0lxQQeI/CHCyVsB7lnrJay4l Qnjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kQDpaNJuTuBCwjRi4ZnQZs7rqwTgBbG2PPToht2ip2k=; b=cuk6g/UIXMMfVx4bUloYCd5VvWjKSBbs9TuptTGi6b1P79R7925JUvP4XvPhb3UD26 5Eq/7w5M7xJb437/S0cFKh3EdebgyMEkElO3mUYd0RknT9rqGTRK+WtdwQImg4zMrRjS dS5XnCOMe2DS1kq07/hoQRhJGrF8+xXkw6T1/IbQyFPcI0HFn/32d8u9E2z+CvvOMeKT yWO6bCvHFJ1CU0qRIjIhJxLa+KaFLooLNgKv0nINYbSFPOcraCTmySHANsmqXVfCYifB 2Ek5ALEwlJvRA/yJBNMGgPcq6dvkFA7/ptS7sDL0Cm/gV/ws2MUBVifktOYJKgOeCdNL +B8Q== X-Gm-Message-State: APjAAAVYLeqoYwSHkjyo9Ler9vawjh4A5+mA/8OKnAVZtCKWLgaQN15c nNnnNHrYevXgz0Qlg7m/EHw3FhIUltMvBlsQX+K3uw== X-Google-Smtp-Source: APXvYqxO1M9SsfvsEtMjn6bF+rEq7sRKb12tvZGh5y8skVng9zb4XL/QUI/Alr8nAhH+JJMWFI9x+cmtZA+MWjC/M9Y= X-Received: by 2002:a67:ff82:: with SMTP id v2mr23145347vsq.35.1575971496164; Tue, 10 Dec 2019 01:51:36 -0800 (PST) MIME-Version: 1.0 References: <20191128110422.25917-1-faiz_abbas@ti.com> In-Reply-To: <20191128110422.25917-1-faiz_abbas@ti.com> From: Ulf Hansson Date: Tue, 10 Dec 2019 10:51:00 +0100 Message-ID: Subject: Re: [PATCH] Revert "mmc: sdhci: Fix incorrect switch to HS mode" To: Faiz Abbas Cc: Linux Kernel Mailing List , "linux-mmc@vger.kernel.org" , Adrian Hunter , Al Cooper Content-Type: text/plain; charset="UTF-8" Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org On Thu, 28 Nov 2019 at 12:03, Faiz Abbas wrote: > > This reverts commit c894e33ddc1910e14d6f2a2016f60ab613fd8b37. > > This commit aims to treat SD High speed and SDR25 as the same while > setting UHS Timings in HOST_CONTROL2 which leads to failures with some > SD cards in AM65x. Revert this commit. > > The issue this commit was trying to fix can be implemented in a platform > specific callback instead of common sdhci code. > > Cc: > Signed-off-by: Faiz Abbas Applied for fixes, thanks! Kind regards Uffe > --- > drivers/mmc/host/sdhci.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c > index 3140fe2e5dba..296d955ede59 100644 > --- a/drivers/mmc/host/sdhci.c > +++ b/drivers/mmc/host/sdhci.c > @@ -1882,9 +1882,7 @@ void sdhci_set_uhs_signaling(struct sdhci_host *host, unsigned timing) > ctrl_2 |= SDHCI_CTRL_UHS_SDR104; > else if (timing == MMC_TIMING_UHS_SDR12) > ctrl_2 |= SDHCI_CTRL_UHS_SDR12; > - else if (timing == MMC_TIMING_SD_HS || > - timing == MMC_TIMING_MMC_HS || > - timing == MMC_TIMING_UHS_SDR25) > + else if (timing == MMC_TIMING_UHS_SDR25) > ctrl_2 |= SDHCI_CTRL_UHS_SDR25; > else if (timing == MMC_TIMING_UHS_SDR50) > ctrl_2 |= SDHCI_CTRL_UHS_SDR50; > -- > 2.19.2 >