From: Ulf Hansson <ulf.hansson@linaro.org>
To: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: Rob Herring <robh+dt@kernel.org>,
DTML <devicetree@vger.kernel.org>, Faiz Abbas <faiz_abbas@ti.com>,
Nishanth Menon <nm@ti.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Vignesh Raghavendra <vigneshr@ti.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>
Subject: Re: [PATCH] dt-bindings: mmc: sdhci-am654: fix compatible for j7200
Date: Tue, 19 Jan 2021 14:43:06 +0100 [thread overview]
Message-ID: <CAPDyKFp3K7G_36vB5BrMjhLgCD99xi4tL9sHGaunTGm+AqYeNw@mail.gmail.com> (raw)
In-Reply-To: <20210115193218.5809-1-grygorii.strashko@ti.com>
On Fri, 15 Jan 2021 at 20:32, Grygorii Strashko
<grygorii.strashko@ti.com> wrote:
>
> On TI J7200 SoC the SDHCI controller compatible defined as
> "ti,j7200-sdhci-8bit", "ti,j721e-sdhci-8bit"
> or
> "ti,j7200-sdhci-4bit", "ti,j721e-sdhci-4bit"
> which causes dtbs_check warnings:
> mmc@4f80000: compatible: ['ti,j7200-sdhci-8bit', 'ti,j721e-sdhci-8bit'] is too long
> mmc@4f80000: compatible: Additional items are not allowed ('ti,j721e-sdhci-8bit' was unexpected)
> mmc@4fb0000: compatible:0: 'ti,j7200-sdhci-4bit' is not one of ['ti,am654-sdhci-5.1', 'ti,j721e-sdhci-8bit',
> 'ti,j721e-sdhci-4bit', 'ti,j7200-sdhci-8bit', 'ti,j721e-sdhci-4bit', 'ti,am64-sdhci-8bit', 'ti,am64-sdhci-4bit']
> mmc@4fb0000: compatible: ['ti,j7200-sdhci-4bit', 'ti,j721e-sdhci-4bit'] is too long
> mmc@4fb0000: compatible: Additional items are not allowed ('ti,j721e-sdhci-4bit' was unexpected)
>
> Fix it by adding missing compatible strings and their combinations.
>
> Fixes: 407d0c2cdd12 ("dt-bindings: mmc: sdhci-am654: Convert sdhci-am654 controller documentation to json schema")
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> .../devicetree/bindings/mmc/sdhci-am654.yaml | 21 ++++++++++++-------
> 1 file changed, 13 insertions(+), 8 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-am654.yaml b/Documentation/devicetree/bindings/mmc/sdhci-am654.yaml
> index 34e53db29428..3a79e39253d2 100644
> --- a/Documentation/devicetree/bindings/mmc/sdhci-am654.yaml
> +++ b/Documentation/devicetree/bindings/mmc/sdhci-am654.yaml
> @@ -15,14 +15,19 @@ allOf:
>
> properties:
> compatible:
> - enum:
> - - ti,am654-sdhci-5.1
> - - ti,j721e-sdhci-8bit
> - - ti,j721e-sdhci-4bit
> - - ti,j7200-sdhci-8bit
> - - ti,j721e-sdhci-4bit
> - - ti,am64-sdhci-8bit
> - - ti,am64-sdhci-4bit
> + oneOf:
> + - const: ti,am654-sdhci-5.1
> + - const: ti,j721e-sdhci-8bit
> + - const: ti,j721e-sdhci-4bit
> + - const: ti,j721e-sdhci-4bit
> + - const: ti,am64-sdhci-8bit
> + - const: ti,am64-sdhci-4bit
> + - items:
> + - const: ti,j7200-sdhci-8bit
> + - const: ti,j721e-sdhci-8bit
> + - items:
> + - const: ti,j7200-sdhci-4bit
> + - const: ti,j721e-sdhci-4bit
>
> reg:
> maxItems: 2
> --
> 2.17.1
>
prev parent reply other threads:[~2021-01-19 18:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 19:32 [PATCH] dt-bindings: mmc: sdhci-am654: fix compatible for j7200 Grygorii Strashko
2021-01-19 13:43 ` Ulf Hansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFp3K7G_36vB5BrMjhLgCD99xi4tL9sHGaunTGm+AqYeNw@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=faiz_abbas@ti.com \
--cc=grygorii.strashko@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).