Linux-mmc Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] mmc: sdhci-of-esdhc: fix P2020 errata handling
@ 2019-12-16  3:18 Yangbo Lu
  2019-12-18 14:01 ` Ulf Hansson
  0 siblings, 1 reply; 2+ messages in thread
From: Yangbo Lu @ 2019-12-16  3:18 UTC (permalink / raw)
  To: linux-mmc, Ulf Hansson, Adrian Hunter, Yinbo Zhu; +Cc: Yangbo Lu

Two previous patches introduced below quirks for P2020 platforms.
- SDHCI_QUIRK_RESET_AFTER_REQUEST
- SDHCI_QUIRK_BROKEN_TIMEOUT_VAL

The patches made a mistake to add them in quirks2 of sdhci_host
structure, while they were defined for quirks.
	host->quirks2 |= SDHCI_QUIRK_RESET_AFTER_REQUEST;
	host->quirks2 |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL;

This patch is to fix them.
	host->quirks |= SDHCI_QUIRK_RESET_AFTER_REQUEST;
	host->quirks |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL;

Fixes: 05cb6b2a66fa ("mmc: sdhci-of-esdhc: add erratum eSDHC-A001 and A-008358 support")
Fixes: a46e42712596 ("mmc: sdhci-of-esdhc: add erratum eSDHC5 support")
Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>
---
 drivers/mmc/host/sdhci-of-esdhc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mmc/host/sdhci-of-esdhc.c b/drivers/mmc/host/sdhci-of-esdhc.c
index 7f87a90..4ca640e 100644
--- a/drivers/mmc/host/sdhci-of-esdhc.c
+++ b/drivers/mmc/host/sdhci-of-esdhc.c
@@ -1300,8 +1300,8 @@ static int sdhci_esdhc_probe(struct platform_device *pdev)
 		host->quirks &= ~SDHCI_QUIRK_NO_BUSY_IRQ;
 
 	if (of_find_compatible_node(NULL, NULL, "fsl,p2020-esdhc")) {
-		host->quirks2 |= SDHCI_QUIRK_RESET_AFTER_REQUEST;
-		host->quirks2 |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL;
+		host->quirks |= SDHCI_QUIRK_RESET_AFTER_REQUEST;
+		host->quirks |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL;
 	}
 
 	if (of_device_is_compatible(np, "fsl,p5040-esdhc") ||
-- 
2.7.4


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] mmc: sdhci-of-esdhc: fix P2020 errata handling
  2019-12-16  3:18 [PATCH] mmc: sdhci-of-esdhc: fix P2020 errata handling Yangbo Lu
@ 2019-12-18 14:01 ` Ulf Hansson
  0 siblings, 0 replies; 2+ messages in thread
From: Ulf Hansson @ 2019-12-18 14:01 UTC (permalink / raw)
  To: Yangbo Lu; +Cc: linux-mmc, Adrian Hunter, Yinbo Zhu

On Mon, 16 Dec 2019 at 04:19, Yangbo Lu <yangbo.lu@nxp.com> wrote:
>
> Two previous patches introduced below quirks for P2020 platforms.
> - SDHCI_QUIRK_RESET_AFTER_REQUEST
> - SDHCI_QUIRK_BROKEN_TIMEOUT_VAL
>
> The patches made a mistake to add them in quirks2 of sdhci_host
> structure, while they were defined for quirks.
>         host->quirks2 |= SDHCI_QUIRK_RESET_AFTER_REQUEST;
>         host->quirks2 |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL;
>
> This patch is to fix them.
>         host->quirks |= SDHCI_QUIRK_RESET_AFTER_REQUEST;
>         host->quirks |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL;
>
> Fixes: 05cb6b2a66fa ("mmc: sdhci-of-esdhc: add erratum eSDHC-A001 and A-008358 support")
> Fixes: a46e42712596 ("mmc: sdhci-of-esdhc: add erratum eSDHC5 support")
> Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>

Applied for fixes and added a stable tag, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/sdhci-of-esdhc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-of-esdhc.c b/drivers/mmc/host/sdhci-of-esdhc.c
> index 7f87a90..4ca640e 100644
> --- a/drivers/mmc/host/sdhci-of-esdhc.c
> +++ b/drivers/mmc/host/sdhci-of-esdhc.c
> @@ -1300,8 +1300,8 @@ static int sdhci_esdhc_probe(struct platform_device *pdev)
>                 host->quirks &= ~SDHCI_QUIRK_NO_BUSY_IRQ;
>
>         if (of_find_compatible_node(NULL, NULL, "fsl,p2020-esdhc")) {
> -               host->quirks2 |= SDHCI_QUIRK_RESET_AFTER_REQUEST;
> -               host->quirks2 |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL;
> +               host->quirks |= SDHCI_QUIRK_RESET_AFTER_REQUEST;
> +               host->quirks |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL;
>         }
>
>         if (of_device_is_compatible(np, "fsl,p5040-esdhc") ||
> --
> 2.7.4
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-16  3:18 [PATCH] mmc: sdhci-of-esdhc: fix P2020 errata handling Yangbo Lu
2019-12-18 14:01 ` Ulf Hansson

Linux-mmc Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mmc/0 linux-mmc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mmc linux-mmc/ https://lore.kernel.org/linux-mmc \
		linux-mmc@vger.kernel.org
	public-inbox-index linux-mmc

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-mmc


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git