From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 730DBC2D0CD for ; Wed, 18 Dec 2019 14:01:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 49CDA24672 for ; Wed, 18 Dec 2019 14:01:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tVAIlo8S" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727221AbfLROBy (ORCPT ); Wed, 18 Dec 2019 09:01:54 -0500 Received: from mail-vs1-f68.google.com ([209.85.217.68]:32887 "EHLO mail-vs1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726963AbfLROBy (ORCPT ); Wed, 18 Dec 2019 09:01:54 -0500 Received: by mail-vs1-f68.google.com with SMTP id n27so1450394vsa.0 for ; Wed, 18 Dec 2019 06:01:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=nWpZ8hAd7FUovUz3VnEeC9jKUVwXFStq4OLlcUe32fk=; b=tVAIlo8SBCEWTUL6sbCZVxY5xl1m14gicgIkuld11jK7G5ONmMleDzHNwIK33DUi70 cDk/Y7PgO0/R6yhq9tXzGNeXH4Q1M0Ajamh5wxpIPfCDcbCDgcLD+Djq15Dl72Ad0k9z CLmEBpXHiEQjd/SzN4W4f9JIPcclme1w1+YgVTL8QY7czFHk2tn9I27FU2xBoKSid3wb TxVYK/9aj9dD+ZjTG7IXhPPoO99FTRYhGBYdTMEcj+VE4lYTQn1gtCYRSdf2P49X68kx 9f0rXjru96p+slgnvel8TE/JtCATu38U6xMPWipb6hM1LLjo89QNsPF3xC3YVQ2PwSGP K+/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=nWpZ8hAd7FUovUz3VnEeC9jKUVwXFStq4OLlcUe32fk=; b=OOtYFrxrr/kuWZhB+JzGsFP8o0Q8HCWSwoj92oISmzVjjh1NQt5a34yAXaiqD0HaY4 qsLj+/yJ8AStaNsBxmB4nZt7R9ThR4oY+0KDH+/S+ZcPHK6chHCucHGdO/uPDX1nufrp AQmyG8JSGzJzQ0TpgJGQpPh0ieeewxU/5TYEPIHJWKO+59uzq7oGW2qttU/mVunQenme O0Vdzp5LfbpkGymvRp/WBxM+EiMtF9mCgxXxpw1itw7jxx7p7dEHJDGIZgr+Auym0mEC um/K87n+g9dM3wdgpaXj50lc9vOpnK22B7dfWDKfdLH5yEJRK2mYClT1U/OP5bYygFxC JZaQ== X-Gm-Message-State: APjAAAXEVJ4Wo01er5OQfyhOfxsRFFcXBywCn1/VIbkQ5hJucG/rudPq Zm+52NUJevLsLn3g9WctBlOGBKr6BdKQc+bU9U7tpQ== X-Google-Smtp-Source: APXvYqzkFH1g+PqryFVGtuG+lac1yFJaK7FtgFUUP582cfTjMgRsbmSAikWTkyPuUzV8Z+ThYeg5wJ031sxAgsbSxkM= X-Received: by 2002:a67:ff82:: with SMTP id v2mr1450518vsq.35.1576677713314; Wed, 18 Dec 2019 06:01:53 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Ulf Hansson Date: Wed, 18 Dec 2019 15:01:17 +0100 Message-ID: Subject: Re: [PATCH v2 0/4] mmc: simplify WP/CD GPIO handling To: =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= Cc: "linux-mmc@vger.kernel.org" , Adrian Hunter , Bartosz Golaszewski , Linus Walleij , "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org On Wed, 11 Dec 2019 at 03:40, Micha=C5=82 Miros=C5=82aw wrote: > > This series removes convoluted handling of inverted CD and WP lines in > SD/MMC host drivers when using GPIOs. > > First patch adds an API: gpiod_toggle_active_low() that switches line > inversion flag in the gpiod structure. Next two patches modify MMC > host's WP and CD initialization to apply all the inversions onto > gpiod's active-low flag. Final patch removes now-unused argument from > init functions. > > x86 allyesconfig build-tested. > > v2: move argument removal in sdhci-esdhc-imx.c to last patch > > Micha=C5=82 Miros=C5=82aw (4): > gpio: add gpiod_toggle_active_low() > mmc: rework wp-gpio handling > mmc: rework cd-gpio handling > mmc: remove mmc_gpiod_request_*(invert_gpio) > > drivers/gpio/gpiolib-of.c | 21 ------------------- > drivers/gpio/gpiolib.c | 11 ++++++++++ > drivers/mmc/core/host.c | 33 ++++++++---------------------- > drivers/mmc/core/slot-gpio.c | 31 ++++++++++------------------ > drivers/mmc/host/davinci_mmc.c | 4 ++-- > drivers/mmc/host/mmc_spi.c | 4 ++-- > drivers/mmc/host/mmci.c | 4 ++-- > drivers/mmc/host/pxamci.c | 12 +++++------ > drivers/mmc/host/s3cmci.c | 4 ++-- > drivers/mmc/host/sdhci-acpi.c | 2 +- > drivers/mmc/host/sdhci-esdhc-imx.c | 15 +++++++------- > drivers/mmc/host/sdhci-pci-core.c | 4 ++-- > drivers/mmc/host/sdhci-sirf.c | 2 +- > drivers/mmc/host/sdhci-spear.c | 2 +- > drivers/mmc/host/tmio_mmc_core.c | 2 +- > include/linux/gpio/consumer.h | 7 +++++++ > include/linux/mmc/slot-gpio.h | 5 ++--- > 17 files changed, 67 insertions(+), 96 deletions(-) > Applied for next, thanks! Kind regards Uffe