From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 277DCC2D0DB for ; Fri, 24 Jan 2020 13:10:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EE00F214AF for ; Fri, 24 Jan 2020 13:10:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gjmgAgx3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387676AbgAXNKY (ORCPT ); Fri, 24 Jan 2020 08:10:24 -0500 Received: from mail-vs1-f65.google.com ([209.85.217.65]:42869 "EHLO mail-vs1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387423AbgAXNKY (ORCPT ); Fri, 24 Jan 2020 08:10:24 -0500 Received: by mail-vs1-f65.google.com with SMTP id b79so1142571vsd.9 for ; Fri, 24 Jan 2020 05:10:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FgJ5lZH4Mb1Tzk/p5bRIKhcE7A+Y7euEYLcO1OpV4S8=; b=gjmgAgx3XOChzsVHsvnM5jQSiMZ4Fjx3NBVYIq2/dT3CH9ql1U7aAdqnR14513DZFT YCH8qYlXsmEWt6b1r3I4OAxTH8Hk8zQT0770sSu4j1UryQK2excH9kVrqUJQL+Z1HVuK ZRxv2qonE2OXIHbhU41udwALpiap6wfaL6E6mUiUMX8FBzbhBbFqVUz1IoqdD941o+rp g96vbjsxuLg7zYqFDMRrMQNHFyolL5jDENiFUrPIEwhM5Nf/gGAkkwqtpERmRCxKTNFs CWPzTUUwNYmAnFwuZlb3CQgCKwG4t4dH3hX7laxkMyuEdwEesH6wFkZTpIMSXWIkXhHz dkig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FgJ5lZH4Mb1Tzk/p5bRIKhcE7A+Y7euEYLcO1OpV4S8=; b=O8j50Lm1jEUFVFfj8Ore3RYbaEgQcOCubKKnII2DQ9ZjQVNgj9p17wWcz7MDXIo/gp DaPrKFuuzWVkGHNK1CiYsoWWVR36/JGryy/1QVTEB4vcROe61mbBA+z5v3ojHN4JdzCy wDYCK+1aQ+lOcf3fqjcCjruTUd9QITbpS2Sgvm72AV44FPZuWG1x46zf9R/654/KJxfb VQ/2wGJNfMw57KEbLUn8QRb7u8lq62g5b1+yjB/9ITkAnCs0lGflNe4dKe3wIOBQQZBy oaoU1eZkmOPR87jpE8KdX2e6A/44fUSACdWDiS7KuFJTM/VbX8YhjAEluF/Z2VaL3jch hcjQ== X-Gm-Message-State: APjAAAXtSw7mVDt6LUUGQd1qJPgRgxu1/rLogbbfhEIPe21SnbIYMdNA xKfLUnjXwCgbLQ49+Yekelq4pSnvXxZYjkJcCeD4+w== X-Google-Smtp-Source: APXvYqwTSyMti1aLrHxV4T1GbulSVX2llyodm3KWM+MmIFpyCh3UiqUM4MYq/lAoQMj2ylGIpLcWxal/hp0XVXJXDjA= X-Received: by 2002:a67:de15:: with SMTP id q21mr2060825vsk.165.1579871422965; Fri, 24 Jan 2020 05:10:22 -0800 (PST) MIME-Version: 1.0 References: <20200110134823.14882-1-ludovic.barre@st.com> <20200110134823.14882-4-ludovic.barre@st.com> In-Reply-To: <20200110134823.14882-4-ludovic.barre@st.com> From: Ulf Hansson Date: Fri, 24 Jan 2020 14:09:46 +0100 Message-ID: Subject: Re: [PATCH 3/9] mmc: mmci: add a reference at mmc_host_ops in mmci struct To: Ludovic Barre Cc: Rob Herring , Srinivas Kandagatla , Maxime Coquelin , Alexandre Torgue , Linux ARM , Linux Kernel Mailing List , DTML , "linux-mmc@vger.kernel.org" , linux-stm32@st-md-mailman.stormreply.com Content-Type: text/plain; charset="UTF-8" Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org On Fri, 10 Jan 2020 at 14:49, Ludovic Barre wrote: > > This patch adds mmc_host_ops pointer in mmci struct. > The variant init function may need to add a mmc_host_ops, > for example to add the execute_tuning support if this feature > is available. > > Signed-off-by: Ludovic Barre > --- > drivers/mmc/host/mmci.c | 1 + > drivers/mmc/host/mmci.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c > index 7b13d66cbb21..00b473f57047 100644 > --- a/drivers/mmc/host/mmci.c > +++ b/drivers/mmc/host/mmci.c > @@ -1923,6 +1923,7 @@ static int mmci_probe(struct amba_device *dev, > > host = mmc_priv(mmc); > host->mmc = mmc; > + host->mmc_ops = &mmci_ops; Nitpick: Can you please also move the assignment "mmc->ops = &mmci_ops;" to this place as well, as I think these belongs together. > > /* > * Some variant (STM32) doesn't have opendrain bit, nevertheless > diff --git a/drivers/mmc/host/mmci.h b/drivers/mmc/host/mmci.h > index ea6a0b5779d4..55acc0971a44 100644 > --- a/drivers/mmc/host/mmci.h > +++ b/drivers/mmc/host/mmci.h > @@ -407,6 +407,7 @@ struct mmci_host { > u32 mask1_reg; > u8 vqmmc_enabled:1; > struct mmci_platform_data *plat; > + struct mmc_host_ops *mmc_ops; > struct mmci_host_ops *ops; > struct variant_data *variant; > struct pinctrl *pinctrl; > -- > 2.17.1 > Kind regards Uffe